| Message ID | 20221116214841.1116735-7-robimarko@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/9] arm64: dts: qcom: ipq8074: fix Gen2 PCIe QMP PHY | expand |
Hi Robert, If you post a v2 for any reason, capitalize the subject line to match previous history: PCI: qcom: Rename host-init error label PCI: qcom: Drop unused post_deinit callback PCI: qcom: Sort device-id table PCI: qcom: Clean up IP configurations ... On Wed, Nov 16, 2022 at 10:48:39PM +0100, Robert Marko wrote: > IPQ8074 has one Gen2 and one Gen3 port, with Gen2 port already supported. > Add compatible for Gen3 port which uses the same controller as IPQ6018. > > Signed-off-by: Robert Marko <robimarko@gmail.com> > --- > drivers/pci/controller/dwc/pcie-qcom.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index 77e5dc7b88ad..97e8510c53fb 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -1817,6 +1817,7 @@ static const struct of_device_id qcom_pcie_match[] = { > { .compatible = "qcom,pcie-ipq8064", .data = &cfg_2_1_0 }, > { .compatible = "qcom,pcie-ipq8064-v2", .data = &cfg_2_1_0 }, > { .compatible = "qcom,pcie-ipq8074", .data = &cfg_2_3_3 }, > + { .compatible = "qcom,pcie-ipq8074-gen3", .data = &cfg_2_9_0 }, > { .compatible = "qcom,pcie-msm8996", .data = &cfg_2_3_2 }, > { .compatible = "qcom,pcie-qcs404", .data = &cfg_2_4_0 }, > { .compatible = "qcom,pcie-sa8540p", .data = &cfg_1_9_0 }, > -- > 2.38.1 >
On Thu, Nov 17, 2022 at 01:28:37PM -0600, Bjorn Helgaas wrote: > Hi Robert, > > If you post a v2 for any reason, capitalize the subject line to match > previous history: > > PCI: qcom: Rename host-init error label > PCI: qcom: Drop unused post_deinit callback > PCI: qcom: Sort device-id table > PCI: qcom: Clean up IP configurations > ... If he could do that while rebasing on top of my current pci/qcom branch that would be ideal, I tried to cherry-pick patches 5,6,7 but 5 does not apply. Thanks, Lorenzo > > On Wed, Nov 16, 2022 at 10:48:39PM +0100, Robert Marko wrote: > > IPQ8074 has one Gen2 and one Gen3 port, with Gen2 port already supported. > > Add compatible for Gen3 port which uses the same controller as IPQ6018. > > > > Signed-off-by: Robert Marko <robimarko@gmail.com> > > --- > > drivers/pci/controller/dwc/pcie-qcom.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > > index 77e5dc7b88ad..97e8510c53fb 100644 > > --- a/drivers/pci/controller/dwc/pcie-qcom.c > > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > > @@ -1817,6 +1817,7 @@ static const struct of_device_id qcom_pcie_match[] = { > > { .compatible = "qcom,pcie-ipq8064", .data = &cfg_2_1_0 }, > > { .compatible = "qcom,pcie-ipq8064-v2", .data = &cfg_2_1_0 }, > > { .compatible = "qcom,pcie-ipq8074", .data = &cfg_2_3_3 }, > > + { .compatible = "qcom,pcie-ipq8074-gen3", .data = &cfg_2_9_0 }, > > { .compatible = "qcom,pcie-msm8996", .data = &cfg_2_3_2 }, > > { .compatible = "qcom,pcie-qcs404", .data = &cfg_2_4_0 }, > > { .compatible = "qcom,pcie-sa8540p", .data = &cfg_1_9_0 }, > > -- > > 2.38.1 > >
On Fri, 13 Jan 2023 at 14:34, Lorenzo Pieralisi <lpieralisi@kernel.org> wrote: > > On Thu, Nov 17, 2022 at 01:28:37PM -0600, Bjorn Helgaas wrote: > > Hi Robert, > > > > If you post a v2 for any reason, capitalize the subject line to match > > previous history: > > > > PCI: qcom: Rename host-init error label > > PCI: qcom: Drop unused post_deinit callback > > PCI: qcom: Sort device-id table > > PCI: qcom: Clean up IP configurations > > ... > > If he could do that while rebasing on top of my current pci/qcom branch > that would be ideal, I tried to cherry-pick patches 5,6,7 but 5 does not > apply. Sure, I will send v2 with that now as after cherry-picking the SM8350 commits from pci/qcom they all still apply, will fixup the subject capitalization. Regards, Robert > > Thanks, > Lorenzo > > > > > On Wed, Nov 16, 2022 at 10:48:39PM +0100, Robert Marko wrote: > > > IPQ8074 has one Gen2 and one Gen3 port, with Gen2 port already supported. > > > Add compatible for Gen3 port which uses the same controller as IPQ6018. > > > > > > Signed-off-by: Robert Marko <robimarko@gmail.com> > > > --- > > > drivers/pci/controller/dwc/pcie-qcom.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > > > index 77e5dc7b88ad..97e8510c53fb 100644 > > > --- a/drivers/pci/controller/dwc/pcie-qcom.c > > > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > > > @@ -1817,6 +1817,7 @@ static const struct of_device_id qcom_pcie_match[] = { > > > { .compatible = "qcom,pcie-ipq8064", .data = &cfg_2_1_0 }, > > > { .compatible = "qcom,pcie-ipq8064-v2", .data = &cfg_2_1_0 }, > > > { .compatible = "qcom,pcie-ipq8074", .data = &cfg_2_3_3 }, > > > + { .compatible = "qcom,pcie-ipq8074-gen3", .data = &cfg_2_9_0 }, > > > { .compatible = "qcom,pcie-msm8996", .data = &cfg_2_3_2 }, > > > { .compatible = "qcom,pcie-qcs404", .data = &cfg_2_4_0 }, > > > { .compatible = "qcom,pcie-sa8540p", .data = &cfg_1_9_0 }, > > > -- > > > 2.38.1 > > >
On Wed, Nov 16, 2022 at 10:48:39PM +0100, Robert Marko wrote: > IPQ8074 has one Gen2 and one Gen3 port, with Gen2 port already supported. > Add compatible for Gen3 port which uses the same controller as IPQ6018. > > Signed-off-by: Robert Marko <robimarko@gmail.com> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org> Thanks, Mani > --- > drivers/pci/controller/dwc/pcie-qcom.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index 77e5dc7b88ad..97e8510c53fb 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -1817,6 +1817,7 @@ static const struct of_device_id qcom_pcie_match[] = { > { .compatible = "qcom,pcie-ipq8064", .data = &cfg_2_1_0 }, > { .compatible = "qcom,pcie-ipq8064-v2", .data = &cfg_2_1_0 }, > { .compatible = "qcom,pcie-ipq8074", .data = &cfg_2_3_3 }, > + { .compatible = "qcom,pcie-ipq8074-gen3", .data = &cfg_2_9_0 }, > { .compatible = "qcom,pcie-msm8996", .data = &cfg_2_3_2 }, > { .compatible = "qcom,pcie-qcs404", .data = &cfg_2_4_0 }, > { .compatible = "qcom,pcie-sa8540p", .data = &cfg_1_9_0 }, > -- > 2.38.1 >
diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index 77e5dc7b88ad..97e8510c53fb 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -1817,6 +1817,7 @@ static const struct of_device_id qcom_pcie_match[] = { { .compatible = "qcom,pcie-ipq8064", .data = &cfg_2_1_0 }, { .compatible = "qcom,pcie-ipq8064-v2", .data = &cfg_2_1_0 }, { .compatible = "qcom,pcie-ipq8074", .data = &cfg_2_3_3 }, + { .compatible = "qcom,pcie-ipq8074-gen3", .data = &cfg_2_9_0 }, { .compatible = "qcom,pcie-msm8996", .data = &cfg_2_3_2 }, { .compatible = "qcom,pcie-qcs404", .data = &cfg_2_4_0 }, { .compatible = "qcom,pcie-sa8540p", .data = &cfg_1_9_0 },
IPQ8074 has one Gen2 and one Gen3 port, with Gen2 port already supported. Add compatible for Gen3 port which uses the same controller as IPQ6018. Signed-off-by: Robert Marko <robimarko@gmail.com> --- drivers/pci/controller/dwc/pcie-qcom.c | 1 + 1 file changed, 1 insertion(+)