| Message ID | 20230118061256.2689-3-dakr@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | DRM GPUVA Manager & Nouveau VM_BIND UAPI | expand |
That one should probably be squashed into the original patch. Christian. Am 18.01.23 um 07:12 schrieb Danilo Krummrich: > Don't call drm_gem_object_get() unconditionally. > > Signed-off-by: Danilo Krummrich <dakr@redhat.com> > --- > drivers/gpu/drm/drm_exec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_exec.c b/drivers/gpu/drm/drm_exec.c > index ed2106c22786..5713a589a6a3 100644 > --- a/drivers/gpu/drm/drm_exec.c > +++ b/drivers/gpu/drm/drm_exec.c > @@ -282,7 +282,6 @@ int drm_exec_prepare_obj(struct drm_exec *exec, struct drm_gem_object *obj, > goto error_unlock; > } > > - drm_gem_object_get(obj); > return 0; > > error_unlock:
On 1/18/23 09:51, Christian König wrote: > That one should probably be squashed into the original patch. Yes, just wanted to make it obvious for you to pick it up in case you did not fix it already yourself. > > Christian. > > Am 18.01.23 um 07:12 schrieb Danilo Krummrich: >> Don't call drm_gem_object_get() unconditionally. >> >> Signed-off-by: Danilo Krummrich <dakr@redhat.com> >> --- >> drivers/gpu/drm/drm_exec.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/drm_exec.c b/drivers/gpu/drm/drm_exec.c >> index ed2106c22786..5713a589a6a3 100644 >> --- a/drivers/gpu/drm/drm_exec.c >> +++ b/drivers/gpu/drm/drm_exec.c >> @@ -282,7 +282,6 @@ int drm_exec_prepare_obj(struct drm_exec *exec, >> struct drm_gem_object *obj, >> goto error_unlock; >> } >> - drm_gem_object_get(obj); >> return 0; >> error_unlock: >
diff --git a/drivers/gpu/drm/drm_exec.c b/drivers/gpu/drm/drm_exec.c index ed2106c22786..5713a589a6a3 100644 --- a/drivers/gpu/drm/drm_exec.c +++ b/drivers/gpu/drm/drm_exec.c @@ -282,7 +282,6 @@ int drm_exec_prepare_obj(struct drm_exec *exec, struct drm_gem_object *obj, goto error_unlock; } - drm_gem_object_get(obj); return 0; error_unlock:
Don't call drm_gem_object_get() unconditionally. Signed-off-by: Danilo Krummrich <dakr@redhat.com> --- drivers/gpu/drm/drm_exec.c | 1 - 1 file changed, 1 deletion(-)