| Message ID | 20230118072656.18845-13-marcel@ziswiler.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: freescale: prepare and add apalis imx8 support | expand |
On 18/01/2023 08:26, Marcel Ziswiler wrote: > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > Added a comment about Apalis analogue audio being another todo. > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> You just added this file in previous patch. This should be squashed instead of splitting one logical change (adding new hardware) into multiple independent patches. Best regards, Krzysztof
On Wed, 2023-01-18 at 14:59 +0100, Krzysztof Kozlowski wrote: > On 18/01/2023 08:26, Marcel Ziswiler wrote: > > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > > Added a comment about Apalis analogue audio being another todo. > > > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > You just added this file in previous patch. This should be squashed > instead of splitting one logical change (adding new hardware) into > multiple independent patches. Remember, I explicitly did that for review purpose and even mentioned this in the cover letter. > Best regards, > Krzysztof
On 18/01/2023 15:33, Marcel Ziswiler wrote: > On Wed, 2023-01-18 at 14:59 +0100, Krzysztof Kozlowski wrote: >> On 18/01/2023 08:26, Marcel Ziswiler wrote: >>> From: Marcel Ziswiler <marcel.ziswiler@toradex.com> >>> >>> Added a comment about Apalis analogue audio being another todo. >>> >>> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> >> >> You just added this file in previous patch. This should be squashed >> instead of splitting one logical change (adding new hardware) into >> multiple independent patches. > > Remember, I explicitly did that for review purpose and even mentioned this in the cover letter. There is b4 diff for this purpose. Splitting patches makes them difficult to apply and confuse. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi index 25342c886144..060454f25c98 100644 --- a/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi @@ -110,6 +110,8 @@ &lsio_pwm3 { /* TODO: Apalis DAP1 */ +/* TODO: Apalis Analogue Audio */ + /* TODO: Apalis SATA1 */ /* TODO: Apalis SPDIF1 */ diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi index e720644d6892..caaafc9900a6 100644 --- a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi @@ -186,6 +186,8 @@ &lsio_pwm3 { /* TODO: Apalis DAP1 */ +/* TODO: Analogue Audio */ + /* TODO: Apalis SATA1 */ /* TODO: Apalis SPDIF1 */ diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi index d33c841515ca..5bc55a58db97 100644 --- a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi @@ -231,6 +231,8 @@ &lsio_pwm3 { /* TODO: Apalis DAP1 */ +/* TODO: Analogue Audio */ + /* TODO: Apalis SATA1 */ /* TODO: Apalis SPDIF1 */ diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi index 12ab749cc949..4c88678e2bc7 100644 --- a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi @@ -682,6 +682,8 @@ &lsio_pwm3 { /* TODO: Apalis DAP1 */ +/* TODO: Analogue Audio */ + /* TODO: Apalis SATA1 */ /* TODO: Apalis SPDIF1 */