| Message ID | 20230118072656.18845-17-marcel@ziswiler.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: freescale: prepare and add apalis imx8 support | expand |
On 18/01/2023 08:26, Marcel Ziswiler wrote: > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > Fix reserved-memory node names using dashes rather than underscores. > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > --- > > Changes in v4: > - New patch fixing reserved-memory node names. > > arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi > index 70c00b92cb05..6217e0a48f96 100644 > --- a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi > @@ -133,17 +133,17 @@ reserved-memory { > #size-cells = <2>; > ranges; > > - decoder_boot: decoder_boot@84000000 { > + decoder_boot: decoder-boot@84000000 { This is ridiculous. You just added it! If we consider original code as wrong, then you intentionally added wrong code just to fix it. No, that's not the way how it should be developed. Best regards, Krzysztof
On Wed, 2023-01-18 at 15:02 +0100, Krzysztof Kozlowski wrote: > On 18/01/2023 08:26, Marcel Ziswiler wrote: > > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > > Fix reserved-memory node names using dashes rather than underscores. > > > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > > --- > > > > Changes in v4: > > - New patch fixing reserved-memory node names. > > > > arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8- > > apalis-v1.1.dtsi > > index 70c00b92cb05..6217e0a48f96 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi > > @@ -133,17 +133,17 @@ reserved-memory { > > #size-cells = <2>; > > ranges; > > > > - decoder_boot: decoder_boot@84000000 { > > + decoder_boot: decoder-boot@84000000 { > > This is ridiculous. You just added it! If we consider original code as > wrong, then you intentionally added wrong code just to fix it. > > No, that's not the way how it should be developed. Shawn asked me to ease the review process which is exactly what I did. > Best regards, > Krzysztof
On 18/01/2023 15:36, Marcel Ziswiler wrote: > On Wed, 2023-01-18 at 15:02 +0100, Krzysztof Kozlowski wrote: >> On 18/01/2023 08:26, Marcel Ziswiler wrote: >>> From: Marcel Ziswiler <marcel.ziswiler@toradex.com> >>> >>> Fix reserved-memory node names using dashes rather than underscores. >>> >>> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> >>> >>> --- >>> >>> Changes in v4: >>> - New patch fixing reserved-memory node names. >>> >>> arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi | 12 ++++++------ >>> 1 file changed, 6 insertions(+), 6 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8- >>> apalis-v1.1.dtsi >>> index 70c00b92cb05..6217e0a48f96 100644 >>> --- a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi >>> +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi >>> @@ -133,17 +133,17 @@ reserved-memory { >>> #size-cells = <2>; >>> ranges; >>> >>> - decoder_boot: decoder_boot@84000000 { >>> + decoder_boot: decoder-boot@84000000 { >> >> This is ridiculous. You just added it! If we consider original code as >> wrong, then you intentionally added wrong code just to fix it. >> >> No, that's not the way how it should be developed. > > Shawn asked me to ease the review process which is exactly what I did. Any reason why b4 diff cannot be used? If your patchset fails b4 auto-detection of version, this should be fixed instead of fake split. Best regards, Krzysztof
On Wed, 2023-01-18 at 15:37 +0100, Krzysztof Kozlowski wrote: > On 18/01/2023 15:36, Marcel Ziswiler wrote: > > On Wed, 2023-01-18 at 15:02 +0100, Krzysztof Kozlowski wrote: > > > On 18/01/2023 08:26, Marcel Ziswiler wrote: > > > > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > > > > > > Fix reserved-memory node names using dashes rather than underscores. > > > > > > > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > > > > > > --- > > > > > > > > Changes in v4: > > > > - New patch fixing reserved-memory node names. > > > > > > > > arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi | 12 ++++++------ > > > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8- > > > > apalis-v1.1.dtsi > > > > index 70c00b92cb05..6217e0a48f96 100644 > > > > --- a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi > > > > +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi > > > > @@ -133,17 +133,17 @@ reserved-memory { > > > > #size-cells = <2>; > > > > ranges; > > > > > > > > - decoder_boot: decoder_boot@84000000 { > > > > + decoder_boot: decoder-boot@84000000 { > > > > > > This is ridiculous. You just added it! If we consider original code as > > > wrong, then you intentionally added wrong code just to fix it. > > > > > > No, that's not the way how it should be developed. > > > > Shawn asked me to ease the review process which is exactly what I did. > > Any reason why b4 diff cannot be used? If your patchset fails b4 > auto-detection of version, this should be fixed instead of fake split. Sorry, I did not know anything about this b4 diff stuff and will avoid such splitting in the future. Thanks! > Best regards, > Krzysztof
diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi index 70c00b92cb05..6217e0a48f96 100644 --- a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi @@ -133,17 +133,17 @@ reserved-memory { #size-cells = <2>; ranges; - decoder_boot: decoder_boot@84000000 { + decoder_boot: decoder-boot@84000000 { no-map; reg = <0 0x84000000 0 0x2000000>; }; - encoder1_boot: encoder1_boot@86000000 { + encoder1_boot: encoder1-boot@86000000 { no-map; reg = <0 0x86000000 0 0x200000>; }; - encoder2_boot: encoder2_boot@86200000 { + encoder2_boot: encoder2-boot@86200000 { no-map; reg = <0 0x86200000 0 0x200000>; }; @@ -170,7 +170,7 @@ vdevbuffer: vdevbuffer@90400000 { no-map; }; - decoder_rpc: decoder_rpc@92000000 { + decoder_rpc: decoder-rpc@92000000 { no-map; reg = <0 0x92000000 0 0x200000>; }; @@ -180,12 +180,12 @@ dsp_reserved: dsp@92400000 { reg = <0 0x92400000 0 0x2000000>; }; - encoder1_rpc: encoder1_rpc@94400000 { + encoder1_rpc: encoder1-rpc@94400000 { no-map; reg = <0 0x94400000 0 0x700000>; }; - encoder2_rpc: encoder2_rpc@94b00000 { + encoder2_rpc: encoder2-rpc@94b00000 { no-map; reg = <0 0x94b00000 0 0x700000>; };