mbox series

[v2,0/2] qcom: sa8775p: add the GCC clock driver for Qualcomm SA8775P platforms

Message ID 20230117180429.305266-1-brgl@bgdev.pl (mailing list archive)
Headers show
Series qcom: sa8775p: add the GCC clock driver for Qualcomm SA8775P platforms | expand

Message

Bartosz Golaszewski Jan. 17, 2023, 6:04 p.m. UTC
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Add the DT bindings and driver for the GCC clock on the sa8775p platform
from Qualcomm.

v1 -> v2:
- fix examples in DT bindings and make sure they pass tests
- use lowercase letters in hex numbers
- fix the name of DT compatible and headers (gcc-sa8775p -> sa8775p-gcc)
- fix licensing of DT bindings
- fix the regmap's max_register property
- use clk_regmap_phy_mux_ops where applicable
- other minor tweaks and improvements

Bartosz Golaszewski (1):
  dt-bindings: clock: qcom: document the GCC clock on Qualcomm sa8775p

Shazad Hussain (1):
  clk: qcom: add the GCC driver for sa8775p

 .../bindings/clock/qcom,sa8775p-gcc.yaml      |   79 +
 drivers/clk/qcom/Kconfig                      |    9 +
 drivers/clk/qcom/Makefile                     |    1 +
 drivers/clk/qcom/gcc-sa8775p.c                | 4805 +++++++++++++++++
 include/dt-bindings/clock/qcom,sa8775p-gcc.h  |  320 ++
 5 files changed, 5214 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,sa8775p-gcc.yaml
 create mode 100644 drivers/clk/qcom/gcc-sa8775p.c
 create mode 100644 include/dt-bindings/clock/qcom,sa8775p-gcc.h

Comments

Konrad Dybcio Jan. 18, 2023, 2:27 p.m. UTC | #1
On 17.01.2023 19:04, Bartosz Golaszewski wrote:
> From: Shazad Hussain <quic_shazhuss@quicinc.com>
> 
> Add support for the Global Clock Controller found in the QTI SA8775P
> platforms.
> 
> Signed-off-by: Shazad Hussain <quic_shazhuss@quicinc.com>
> [Bartosz: made the driver ready for upstream]
> Co-developed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---

[...]

> +
> +static int __init gcc_sa8775p_init(void)
> +{
> +	return platform_driver_register(&gcc_sa8775p_driver);
> +}
> +subsys_initcall(gcc_sa8775p_init);
core_initcall, otherwise you'll be waiting for years :P

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> +
> +static void __exit gcc_sa8775p_exit(void)
> +{
> +	platform_driver_unregister(&gcc_sa8775p_driver);
> +}
> +module_exit(gcc_sa8775p_exit);
> +
> +MODULE_DESCRIPTION("Qualcomm SA8775P GCC driver");
> +MODULE_LICENSE("GPL");
Bjorn Andersson Jan. 18, 2023, 10:50 p.m. UTC | #2
On Tue, 17 Jan 2023 19:04:27 +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> Add the DT bindings and driver for the GCC clock on the sa8775p platform
> from Qualcomm.
> 
> v1 -> v2:
> - fix examples in DT bindings and make sure they pass tests
> - use lowercase letters in hex numbers
> - fix the name of DT compatible and headers (gcc-sa8775p -> sa8775p-gcc)
> - fix licensing of DT bindings
> - fix the regmap's max_register property
> - use clk_regmap_phy_mux_ops where applicable
> - other minor tweaks and improvements
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: clock: qcom: document the GCC clock on Qualcomm sa8775p
      commit: 0fff9fa043f972b83935016b0e81d44d9a2229bd
[2/2] clk: qcom: add the GCC driver for sa8775p
      commit: 08c51ceb12f7ce2252513a38ad8a8ed26103a4e2

Best regards,