| Message ID | 20230118142252.337103-1-heiko@sntech.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 285b6a18daf1358e70a4c842884d9ff2d2fe53e2 |
| Delegated to: | Palmer Dabbelt |
| Headers | show |
| Series | RISC-V: Fix do_notify_resume / do_work_pending prototype | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/cover_letter | success | Single patches do not need cover letters |
| conchuod/tree_selection | success | Guessed tree name to be fixes |
| conchuod/fixes_present | success | Fixes tag present in non-next series |
| conchuod/maintainers_pattern | success | MAINTAINERS pattern errors before the patch: 13 and now 13 |
| conchuod/verify_signedoff | success | Signed-off-by tag matches author and committer |
| conchuod/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/module_param | success | Was 0 now: 0 |
| conchuod/build_rv64_gcc_allmodconfig | success | Errors and warnings before: 2025 this patch: 2024 |
| conchuod/alphanumeric_selects | success | Out of order selects before the patch: 57 and now 57 |
| conchuod/build_rv32_defconfig | success | Build OK |
| conchuod/dtb_warn_rv64 | success | Errors and warnings before: 2 this patch: 2 |
| conchuod/header_inline | success | No static functions without inline keyword in header files |
| conchuod/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| conchuod/source_inline | success | Was 0 now: 0 |
| conchuod/build_rv64_nommu_k210_defconfig | success | Build OK |
| conchuod/verify_fixes | success | Fixes tag looks correct |
| conchuod/build_rv64_nommu_virt_defconfig | success | Build OK |
On Wed, Jan 18, 2023 at 03:22:52PM +0100, Heiko Stuebner wrote: > From: Heiko Stuebner <heiko.stuebner@vrull.eu> > > Commit b0f4c74eadbf ("RISC-V: Fix unannoted hardirqs-on in return to > userspace slow-path") renamed the do_notify_resume function to > do_work_pending but did not change the prototype in signal.h > Do that now, as the original function does not exist anymore. > > Fixes: b0f4c74eadbf ("RISC-V: Fix unannoted hardirqs-on in return to userspace slow-path") > Signed-off-by: Heiko Stuebner <heiko.stuebner@vrull.eu> > --- > arch/riscv/include/asm/signal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/include/asm/signal.h b/arch/riscv/include/asm/signal.h > index 532c29ef0376..956ae0a01bad 100644 > --- a/arch/riscv/include/asm/signal.h > +++ b/arch/riscv/include/asm/signal.h > @@ -7,6 +7,6 @@ > #include <uapi/asm/ptrace.h> > > asmlinkage __visible > -void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags); > +void do_work_pending(struct pt_regs *regs, unsigned long thread_info_flags); > > #endif > -- > 2.39.0 > Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
On Wed, Jan 18, 2023 at 03:22:52PM +0100, Heiko Stuebner wrote: > From: Heiko Stuebner <heiko.stuebner@vrull.eu> > > Commit b0f4c74eadbf ("RISC-V: Fix unannoted hardirqs-on in return to > userspace slow-path") renamed the do_notify_resume function to > do_work_pending but did not change the prototype in signal.h > Do that now, as the original function does not exist anymore. > > Fixes: b0f4c74eadbf ("RISC-V: Fix unannoted hardirqs-on in return to userspace slow-path") > Signed-off-by: Heiko Stuebner <heiko.stuebner@vrull.eu> > --- > arch/riscv/include/asm/signal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/include/asm/signal.h b/arch/riscv/include/asm/signal.h > index 532c29ef0376..956ae0a01bad 100644 > --- a/arch/riscv/include/asm/signal.h > +++ b/arch/riscv/include/asm/signal.h > @@ -7,6 +7,6 @@ > #include <uapi/asm/ptrace.h> > > asmlinkage __visible > -void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags); > +void do_work_pending(struct pt_regs *regs, unsigned long thread_info_flags); Is that an auto-builder blind spot as it gets jumped to from asm? Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
Am Mittwoch, 18. Januar 2023, 16:40:52 CET schrieb Conor Dooley: > On Wed, Jan 18, 2023 at 03:22:52PM +0100, Heiko Stuebner wrote: > > From: Heiko Stuebner <heiko.stuebner@vrull.eu> > > > > Commit b0f4c74eadbf ("RISC-V: Fix unannoted hardirqs-on in return to > > userspace slow-path") renamed the do_notify_resume function to > > do_work_pending but did not change the prototype in signal.h > > Do that now, as the original function does not exist anymore. > > > > Fixes: b0f4c74eadbf ("RISC-V: Fix unannoted hardirqs-on in return to userspace slow-path") > > Signed-off-by: Heiko Stuebner <heiko.stuebner@vrull.eu> > > --- > > arch/riscv/include/asm/signal.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/riscv/include/asm/signal.h b/arch/riscv/include/asm/signal.h > > index 532c29ef0376..956ae0a01bad 100644 > > --- a/arch/riscv/include/asm/signal.h > > +++ b/arch/riscv/include/asm/signal.h > > @@ -7,6 +7,6 @@ > > #include <uapi/asm/ptrace.h> > > > > asmlinkage __visible > > -void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags); > > +void do_work_pending(struct pt_regs *regs, unsigned long thread_info_flags); > > Is that an auto-builder blind spot as it gets jumped to from asm? Yeah, the prototype is seemingly more for show in that case, as I guess from asm we only look for the symbol itself but nothing will check the syntax of the parameters. @Palmer: any thoughts? Thanks Heiko
Hello: This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt <palmer@rivosinc.com>: On Wed, 18 Jan 2023 15:22:52 +0100 you wrote: > From: Heiko Stuebner <heiko.stuebner@vrull.eu> > > Commit b0f4c74eadbf ("RISC-V: Fix unannoted hardirqs-on in return to > userspace slow-path") renamed the do_notify_resume function to > do_work_pending but did not change the prototype in signal.h > Do that now, as the original function does not exist anymore. > > [...] Here is the summary with links: - RISC-V: Fix do_notify_resume / do_work_pending prototype https://git.kernel.org/riscv/c/285b6a18daf1 You are awesome, thank you!
diff --git a/arch/riscv/include/asm/signal.h b/arch/riscv/include/asm/signal.h index 532c29ef0376..956ae0a01bad 100644 --- a/arch/riscv/include/asm/signal.h +++ b/arch/riscv/include/asm/signal.h @@ -7,6 +7,6 @@ #include <uapi/asm/ptrace.h> asmlinkage __visible -void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags); +void do_work_pending(struct pt_regs *regs, unsigned long thread_info_flags); #endif