diff mbox series

rpmsg: glink: Include types in qcom_glink_native.h

Message ID 20230109223745.1706152-1-quic_bjorande@quicinc.com (mailing list archive)
State Accepted
Headers show
Series rpmsg: glink: Include types in qcom_glink_native.h | expand

Commit Message

Bjorn Andersson Jan. 9, 2023, 10:37 p.m. UTC 
Ensure that the used data types are available in qcom_glink_native.h, to
silence LSP warnings.

Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
---
 drivers/rpmsg/qcom_glink_native.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Chris Lew Jan. 18, 2023, 12:41 a.m. UTC | #1 
On 1/9/2023 2:37 PM, Bjorn Andersson wrote:
> Ensure that the used data types are available in qcom_glink_native.h, to
> silence LSP warnings.
> 
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>

Reviewed-by: Chris Lew <quic_clew@quicinc.com>

> ---
>   drivers/rpmsg/qcom_glink_native.h | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/rpmsg/qcom_glink_native.h b/drivers/rpmsg/qcom_glink_native.h
> index 624184fc458e..e9a8671616c7 100644
> --- a/drivers/rpmsg/qcom_glink_native.h
> +++ b/drivers/rpmsg/qcom_glink_native.h
> @@ -6,6 +6,8 @@
>   #ifndef __QCOM_GLINK_NATIVE_H__
>   #define __QCOM_GLINK_NATIVE_H__
>   
> +#include <linux/types.h>
> +
>   #define GLINK_FEATURE_INTENT_REUSE	BIT(0)
>   #define GLINK_FEATURE_MIGRATION		BIT(1)
>   #define GLINK_FEATURE_TRACER_PKT	BIT(2)
> @@ -24,6 +26,7 @@ struct qcom_glink_pipe {
>   		      const void *data, size_t dlen);
>   };
>   
> +struct device;
>   struct qcom_glink;
>   
>   struct qcom_glink *qcom_glink_native_probe(struct device *dev,
>
Bjorn Andersson Jan. 18, 2023, 10:06 p.m. UTC | #2 
On Mon, 9 Jan 2023 14:37:45 -0800, Bjorn Andersson wrote:
> Ensure that the used data types are available in qcom_glink_native.h, to
> silence LSP warnings.
> 
> 

Applied, thanks!

[1/1] rpmsg: glink: Include types in qcom_glink_native.h
      commit: f014eda5d5923a1d85f29dc7467cd90e9775cbfd

Best regards,
diff mbox series

Patch

diff --git a/drivers/rpmsg/qcom_glink_native.h b/drivers/rpmsg/qcom_glink_native.h
index 624184fc458e..e9a8671616c7 100644
--- a/drivers/rpmsg/qcom_glink_native.h
+++ b/drivers/rpmsg/qcom_glink_native.h
@@ -6,6 +6,8 @@ 
 #ifndef __QCOM_GLINK_NATIVE_H__
 #define __QCOM_GLINK_NATIVE_H__
 
+#include <linux/types.h>
+
 #define GLINK_FEATURE_INTENT_REUSE	BIT(0)
 #define GLINK_FEATURE_MIGRATION		BIT(1)
 #define GLINK_FEATURE_TRACER_PKT	BIT(2)
@@ -24,6 +26,7 @@  struct qcom_glink_pipe {
 		      const void *data, size_t dlen);
 };
 
+struct device;
 struct qcom_glink;
 
 struct qcom_glink *qcom_glink_native_probe(struct device *dev,