| Message ID | 20230108130440.670181-1-robimarko@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] clk: qcom: ipq8074: populate fw_name for usb3phy-s | expand |
On Sun, 8 Jan 2023 at 15:04, Robert Marko <robimarko@gmail.com> wrote: > > Having only .name populated in parent_data for clocks which are only > globally searchable currently will not work as the clk core won't copy > that name if there is no .fw_name present as well. > > So, populate .fw_name for usb3phy clocks in parent_data as they were > missed by me in ("clk: qcom: ipq8074: populate fw_name for all parents"). > > Fixes: ae55ad32e273 ("clk: qcom: ipq8074: convert to parent data") > Signed-off-by: Robert Marko <robimarko@gmail.com> Ah, excuse me, this is what I asked for in the other patch. We can only hope to see these clocks added to the gcc DT node. Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Sun, 8 Jan 2023 at 18:34, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > On Sun, 8 Jan 2023 at 15:04, Robert Marko <robimarko@gmail.com> wrote: > > > > Having only .name populated in parent_data for clocks which are only > > globally searchable currently will not work as the clk core won't copy > > that name if there is no .fw_name present as well. > > > > So, populate .fw_name for usb3phy clocks in parent_data as they were > > missed by me in ("clk: qcom: ipq8074: populate fw_name for all parents"). > > > > Fixes: ae55ad32e273 ("clk: qcom: ipq8074: convert to parent data") > > Signed-off-by: Robert Marko <robimarko@gmail.com> > > Ah, excuse me, this is what I asked for in the other patch. We can > only hope to see these clocks added to the gcc DT node. Yes, there are PCI pipe parenting fixes waiting for review, so I plan to add both to GCC node after that. It would be great if you can take a look at the IPQ8074 PCI support series. Regards, Robert > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > -- > With best wishes > Dmitry
On Sun, 8 Jan 2023 14:04:39 +0100, Robert Marko wrote: > Having only .name populated in parent_data for clocks which are only > globally searchable currently will not work as the clk core won't copy > that name if there is no .fw_name present as well. > > So, populate .fw_name for usb3phy clocks in parent_data as they were > missed by me in ("clk: qcom: ipq8074: populate fw_name for all parents"). > > [...] Applied, thanks! [2/2] arm64: dts: qcom: ipq8074: correct USB3 QMP PHY-s clock output names commit: 877cff3568c0f54511d77918ae16b2d6e9a0dfce Best regards,
diff --git a/drivers/clk/qcom/gcc-ipq8074.c b/drivers/clk/qcom/gcc-ipq8074.c index 8374cc40915a..888e8df7bc92 100644 --- a/drivers/clk/qcom/gcc-ipq8074.c +++ b/drivers/clk/qcom/gcc-ipq8074.c @@ -934,7 +934,7 @@ static struct clk_rcg2 usb0_mock_utmi_clk_src = { }; static const struct clk_parent_data gcc_usb3phy_0_cc_pipe_clk_xo[] = { - { .name = "usb3phy_0_cc_pipe_clk" }, + { .fw_name = "usb3phy_0_cc_pipe_clk", .name = "usb3phy_0_cc_pipe_clk" }, { .fw_name = "xo", .name = "xo" }, }; @@ -1002,7 +1002,7 @@ static struct clk_rcg2 usb1_mock_utmi_clk_src = { }; static const struct clk_parent_data gcc_usb3phy_1_cc_pipe_clk_xo[] = { - { .name = "usb3phy_1_cc_pipe_clk" }, + { .fw_name = "usb3phy_1_cc_pipe_clk", .name = "usb3phy_1_cc_pipe_clk" }, { .fw_name = "xo", .name = "xo" }, };
Having only .name populated in parent_data for clocks which are only globally searchable currently will not work as the clk core won't copy that name if there is no .fw_name present as well. So, populate .fw_name for usb3phy clocks in parent_data as they were missed by me in ("clk: qcom: ipq8074: populate fw_name for all parents"). Fixes: ae55ad32e273 ("clk: qcom: ipq8074: convert to parent data") Signed-off-by: Robert Marko <robimarko@gmail.com> --- drivers/clk/qcom/gcc-ipq8074.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)