| Message ID | 20230119111920.635260-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm/hugetlb: fix get_hwpoison_hugetlb_folio() stub | expand |
On 1/19/23 3:19 AM, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The folio conversion patch only changed one of the two implementations, > the empty stub one still needs the corresponding change: > > mm/memory-failure.c: In function '__get_hwpoison_page': > mm/memory-failure.c:1335:15: error: implicit declaration of function 'get_hwpoison_hugetlb_folio'; did you mean 'get_hwpoison_huge_page'? [-Werror=implicit-function-declaration] > 1335 | ret = get_hwpoison_hugetlb_folio(folio, &hugetlb, false); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~ > | get_hwpoison_huge_page > > Fixes: 92e109a2c5a7 ("mm/hugetlb: convert get_hwpoison_huge_page() to folios") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- Hello, I also posted a v3 of this patch with the build fix here: https://lore.kernel.org/linux-mm/20230119011057.91349-1-sidhartha.kumar@oracle.com/T/#u I'm fine with either picking up this patch as a fix or picking up v3. Thanks, Sidhartha Kumar > include/linux/hugetlb.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index f14a6bd2a6ed..06eb59711e4a 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -417,7 +417,7 @@ static inline int isolate_hugetlb(struct folio *folio, struct list_head *list) > return -EBUSY; > } > > -static inline int get_hwpoison_huge_page(struct page *page, bool *hugetlb, bool unpoison) > +static inline int get_hwpoison_hugetlb_folio(struct folio *folio, bool *hugetlb, bool unpoison) > { > return 0; > }
diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index f14a6bd2a6ed..06eb59711e4a 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -417,7 +417,7 @@ static inline int isolate_hugetlb(struct folio *folio, struct list_head *list) return -EBUSY; } -static inline int get_hwpoison_huge_page(struct page *page, bool *hugetlb, bool unpoison) +static inline int get_hwpoison_hugetlb_folio(struct folio *folio, bool *hugetlb, bool unpoison) { return 0; }