| Message ID | 20230116100845.6153-2-ilpo.jarvinen@linux.intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | intel-m10-bmc: Split BMC to core and SPI parts & add PMCI+N6000 support | expand |
On 1/16/23 02:08, Ilpo Järvinen wrote: > linux/mfd/intel-m10-bmc.h is using: > - pr_err(), thus include also linux/dev_printk.h > - FIELD_GET(), this include also linux/bitfield.h > - GENMASK(), thus include also linux/bits.h Reviewed-by: Russ Weight <russell.h.weight@intel.com> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > --- > include/linux/mfd/intel-m10-bmc.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/linux/mfd/intel-m10-bmc.h b/include/linux/mfd/intel-m10-bmc.h > index f0044b14136e..0d4db5d9d5af 100644 > --- a/include/linux/mfd/intel-m10-bmc.h > +++ b/include/linux/mfd/intel-m10-bmc.h > @@ -7,6 +7,9 @@ > #ifndef __MFD_INTEL_M10_BMC_H > #define __MFD_INTEL_M10_BMC_H > > +#include <linux/bitfield.h> > +#include <linux/bits.h> > +#include <linux/dev_printk.h> > #include <linux/regmap.h> > > #define M10BMC_LEGACY_BUILD_VER 0x300468
On 2023-01-17 at 08:43:03 -0800, Russ Weight wrote: > > > On 1/16/23 02:08, Ilpo Järvinen wrote: > > linux/mfd/intel-m10-bmc.h is using: > > - pr_err(), thus include also linux/dev_printk.h > > - FIELD_GET(), this include also linux/bitfield.h > > - GENMASK(), thus include also linux/bits.h > > Reviewed-by: Russ Weight <russell.h.weight@intel.com> Reviewed-by: Xu Yilun <yilun.xu@intel.com> > > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > > --- > > include/linux/mfd/intel-m10-bmc.h | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/include/linux/mfd/intel-m10-bmc.h b/include/linux/mfd/intel-m10-bmc.h > > index f0044b14136e..0d4db5d9d5af 100644 > > --- a/include/linux/mfd/intel-m10-bmc.h > > +++ b/include/linux/mfd/intel-m10-bmc.h > > @@ -7,6 +7,9 @@ > > #ifndef __MFD_INTEL_M10_BMC_H > > #define __MFD_INTEL_M10_BMC_H > > > > +#include <linux/bitfield.h> > > +#include <linux/bits.h> > > +#include <linux/dev_printk.h> > > #include <linux/regmap.h> > > > > #define M10BMC_LEGACY_BUILD_VER 0x300468 >
On Mon, 16 Jan 2023, Ilpo Järvinen wrote: > linux/mfd/intel-m10-bmc.h is using: > - pr_err(), thus include also linux/dev_printk.h > - FIELD_GET(), this include also linux/bitfield.h > - GENMASK(), thus include also linux/bits.h > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > --- > include/linux/mfd/intel-m10-bmc.h | 3 +++ > 1 file changed, 3 insertions(+) Applied, thanks
diff --git a/include/linux/mfd/intel-m10-bmc.h b/include/linux/mfd/intel-m10-bmc.h index f0044b14136e..0d4db5d9d5af 100644 --- a/include/linux/mfd/intel-m10-bmc.h +++ b/include/linux/mfd/intel-m10-bmc.h @@ -7,6 +7,9 @@ #ifndef __MFD_INTEL_M10_BMC_H #define __MFD_INTEL_M10_BMC_H +#include <linux/bitfield.h> +#include <linux/bits.h> +#include <linux/dev_printk.h> #include <linux/regmap.h> #define M10BMC_LEGACY_BUILD_VER 0x300468
linux/mfd/intel-m10-bmc.h is using: - pr_err(), thus include also linux/dev_printk.h - FIELD_GET(), this include also linux/bitfield.h - GENMASK(), thus include also linux/bits.h Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> --- include/linux/mfd/intel-m10-bmc.h | 3 +++ 1 file changed, 3 insertions(+)