diff mbox series

docs: cgroup-v1: wrap charge moving deprecation in warning block

Message ID 20230106034836.23708-1-bagasdotme@gmail.com (mailing list archive)
State New
Headers show
Series docs: cgroup-v1: wrap charge moving deprecation in warning block | expand

Commit Message

Bagas Sanjaya Jan. 6, 2023, 3:48 a.m. UTC
Commit 4ddb1a2aa1a3c4 ("docs: cgroup-v1: wrap remaining admonitions in
admonition blocks") in cgroups tree states that it also wraps charge
moving deprecation notice in admonition block (specifically warning).
However, the notice isn't in cgroups tree when the v2 of formatting
improv series [1] is submitted (and then applied), but rather in mm tree
instead.

Wrap the notice to fulfill the intention of referred commit.

Link: https://lore.kernel.org/linux-doc/20230105131633.553574-1-bagasdotme@gmail.com/ # [1]
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
 Documentation/admin-guide/cgroup-v1/memory.rst | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)


base-commit: dd5c3ba990ae67409bc058051efcd40c3689d01d

Comments

Bagas Sanjaya Jan. 20, 2023, 8:20 a.m. UTC | #1
On 1/6/23 10:48, Bagas Sanjaya wrote:
> Commit 4ddb1a2aa1a3c4 ("docs: cgroup-v1: wrap remaining admonitions in
> admonition blocks") in cgroups tree states that it also wraps charge
> moving deprecation notice in admonition block (specifically warning).
> However, the notice isn't in cgroups tree when the v2 of formatting
> improv series [1] is submitted (and then applied), but rather in mm tree
> instead.
> 
> Wrap the notice to fulfill the intention of referred commit.
> 

Ping?
diff mbox series

Patch

diff --git a/Documentation/admin-guide/cgroup-v1/memory.rst b/Documentation/admin-guide/cgroup-v1/memory.rst
index 258e45cc3b2db1..b73eb174735556 100644
--- a/Documentation/admin-guide/cgroup-v1/memory.rst
+++ b/Documentation/admin-guide/cgroup-v1/memory.rst
@@ -722,12 +722,14 @@  NOTE2:
 8. Move charges at task migration (DEPRECATED!)
 ===============================================
 
-THIS IS DEPRECATED!
+.. warning::
 
-It's expensive and unreliable! It's better practice to launch workload
-tasks directly from inside their target cgroup. Use dedicated workload
-cgroups to allow fine-grained policy adjustments without having to
-move physical pages between control domains.
+   THIS IS DEPRECATED!
+
+   It's expensive and unreliable! It's better practice to launch workload
+   tasks directly from inside their target cgroup. Use dedicated workload
+   cgroups to allow fine-grained policy adjustments without having to
+   move physical pages between control domains.
 
 Users can move charges associated with a task along with task migration, that
 is, uncharge task's pages from the old cgroup and charge them to the new cgroup.