| Message ID | 20230120085722.171965-2-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] dt-bindings: mmc: drop unneeded quotes | expand |
Am Freitag, 20. Januar 2023, 09:57:22 CET schrieb Krzysztof Kozlowski: > Node names should be generic and should not contain underscores. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml | 2 +- > Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml | 2 +- > Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml > index 911a5996e099..588be73168fa 100644 > --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml > +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml > @@ -41,7 +41,7 @@ additionalProperties: false > examples: > - | > #include <dt-bindings/gpio/gpio.h> > - sdhci0_pwrseq { > + pwrseq { [applicable for all 3 examples] hmm, power-sequences are not necessarily tied to an address and I guess it will be very much a common case to have multiple ones on a system. So might it be better to follow other patterns (like leds) to number them or suggest a "foo-pwrseq" / "pwrseq-foo"? Heiko > compatible = "mmc-pwrseq-emmc"; > reset-gpios = <&gpio1 12 GPIO_ACTIVE_LOW>; > }; > diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml > index 3397dbff88c2..b35e00e8c65e 100644 > --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml > +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml > @@ -35,7 +35,7 @@ additionalProperties: false > examples: > - | > #include <dt-bindings/gpio/gpio.h> > - wifi_pwrseq: wifi_pwrseq { > + pwrseq { > compatible = "mmc-pwrseq-sd8787"; > powerdown-gpios = <&twl_gpio 0 GPIO_ACTIVE_LOW>; > reset-gpios = <&twl_gpio 1 GPIO_ACTIVE_LOW>; > diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml > index 64e3644eefeb..00feaafc1063 100644 > --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml > +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml > @@ -55,7 +55,7 @@ additionalProperties: false > examples: > - | > #include <dt-bindings/gpio/gpio.h> > - sdhci0_pwrseq { > + pwrseq { > compatible = "mmc-pwrseq-simple"; > reset-gpios = <&gpio1 12 GPIO_ACTIVE_LOW>; > clocks = <&clk_32768_ck>; >
On Fri, 20 Jan 2023 09:57:22 +0100, Krzysztof Kozlowski wrote: > Node names should be generic and should not contain underscores. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml | 2 +- > Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml | 2 +- > Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On 20/01/2023 10:38, Heiko Stübner wrote: > Am Freitag, 20. Januar 2023, 09:57:22 CET schrieb Krzysztof Kozlowski: >> Node names should be generic and should not contain underscores. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml | 2 +- >> Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml | 2 +- >> Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml >> index 911a5996e099..588be73168fa 100644 >> --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml >> +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml >> @@ -41,7 +41,7 @@ additionalProperties: false >> examples: >> - | >> #include <dt-bindings/gpio/gpio.h> >> - sdhci0_pwrseq { >> + pwrseq { > > [applicable for all 3 examples] > > hmm, power-sequences are not necessarily tied to an address and I guess > it will be very much a common case to have multiple ones on a system. > > So might it be better to follow other patterns (like leds) to number them > or suggest a "foo-pwrseq" / "pwrseq-foo"? In such cases one can add number or descriptive suffix (pwrseq-0, pwrseq-foo), just like we do for regulators. However the examples have here only one node and in such case "pwrseq" is enough. Best regards, Krzysztof
Am Dienstag, 24. Januar 2023, 09:17:12 CET schrieb Krzysztof Kozlowski: > On 20/01/2023 10:38, Heiko Stübner wrote: > > Am Freitag, 20. Januar 2023, 09:57:22 CET schrieb Krzysztof Kozlowski: > >> Node names should be generic and should not contain underscores. > >> > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> --- > >> Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml | 2 +- > >> Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml | 2 +- > >> Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml | 2 +- > >> 3 files changed, 3 insertions(+), 3 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml > >> index 911a5996e099..588be73168fa 100644 > >> --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml > >> +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml > >> @@ -41,7 +41,7 @@ additionalProperties: false > >> examples: > >> - | > >> #include <dt-bindings/gpio/gpio.h> > >> - sdhci0_pwrseq { > >> + pwrseq { > > > > [applicable for all 3 examples] > > > > hmm, power-sequences are not necessarily tied to an address and I guess > > it will be very much a common case to have multiple ones on a system. > > > > So might it be better to follow other patterns (like leds) to number them > > or suggest a "foo-pwrseq" / "pwrseq-foo"? > > In such cases one can add number or descriptive suffix (pwrseq-0, > pwrseq-foo), just like we do for regulators. However the examples have > here only one node and in such case "pwrseq" is enough. ok, when that is already part of the schema then all is fine :-) Reviewed-by: Heiko Stuebner <heiko@sntech.de>
On Fri, 20 Jan 2023 at 09:57, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > Node names should be generic and should not contain underscores. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Applied for next, thanks! Kind regards Uffe > --- > Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml | 2 +- > Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml | 2 +- > Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml > index 911a5996e099..588be73168fa 100644 > --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml > +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml > @@ -41,7 +41,7 @@ additionalProperties: false > examples: > - | > #include <dt-bindings/gpio/gpio.h> > - sdhci0_pwrseq { > + pwrseq { > compatible = "mmc-pwrseq-emmc"; > reset-gpios = <&gpio1 12 GPIO_ACTIVE_LOW>; > }; > diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml > index 3397dbff88c2..b35e00e8c65e 100644 > --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml > +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml > @@ -35,7 +35,7 @@ additionalProperties: false > examples: > - | > #include <dt-bindings/gpio/gpio.h> > - wifi_pwrseq: wifi_pwrseq { > + pwrseq { > compatible = "mmc-pwrseq-sd8787"; > powerdown-gpios = <&twl_gpio 0 GPIO_ACTIVE_LOW>; > reset-gpios = <&twl_gpio 1 GPIO_ACTIVE_LOW>; > diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml > index 64e3644eefeb..00feaafc1063 100644 > --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml > +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml > @@ -55,7 +55,7 @@ additionalProperties: false > examples: > - | > #include <dt-bindings/gpio/gpio.h> > - sdhci0_pwrseq { > + pwrseq { > compatible = "mmc-pwrseq-simple"; > reset-gpios = <&gpio1 12 GPIO_ACTIVE_LOW>; > clocks = <&clk_32768_ck>; > -- > 2.34.1 >
diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml index 911a5996e099..588be73168fa 100644 --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml @@ -41,7 +41,7 @@ additionalProperties: false examples: - | #include <dt-bindings/gpio/gpio.h> - sdhci0_pwrseq { + pwrseq { compatible = "mmc-pwrseq-emmc"; reset-gpios = <&gpio1 12 GPIO_ACTIVE_LOW>; }; diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml index 3397dbff88c2..b35e00e8c65e 100644 --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml @@ -35,7 +35,7 @@ additionalProperties: false examples: - | #include <dt-bindings/gpio/gpio.h> - wifi_pwrseq: wifi_pwrseq { + pwrseq { compatible = "mmc-pwrseq-sd8787"; powerdown-gpios = <&twl_gpio 0 GPIO_ACTIVE_LOW>; reset-gpios = <&twl_gpio 1 GPIO_ACTIVE_LOW>; diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml index 64e3644eefeb..00feaafc1063 100644 --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml @@ -55,7 +55,7 @@ additionalProperties: false examples: - | #include <dt-bindings/gpio/gpio.h> - sdhci0_pwrseq { + pwrseq { compatible = "mmc-pwrseq-simple"; reset-gpios = <&gpio1 12 GPIO_ACTIVE_LOW>; clocks = <&clk_32768_ck>;
Node names should be generic and should not contain underscores. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml | 2 +- Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml | 2 +- Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)