| Message ID | 20230124120628.24449-10-jack@suse.cz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | udf: Unify aops | expand |
On Tue, Jan 24, 2023 at 01:06:21PM +0100, Jan Kara wrote: > Instead of using kmap_atomic() use kmap_local_page() in > udf_adinicb_readpage(). Looks good. Given how often this pattern is repeated I wonder if we want a memcpy_to_page_and_pad helper, though. Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/fs/udf/inode.c b/fs/udf/inode.c index dcd3f1dac227..5ae29f89869b 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c @@ -222,12 +222,12 @@ static void udf_adinicb_readpage(struct page *page) struct udf_inode_info *iinfo = UDF_I(inode); loff_t isize = i_size_read(inode); - kaddr = kmap_atomic(page); + kaddr = kmap_local_page(page); memcpy(kaddr, iinfo->i_data + iinfo->i_lenEAttr, isize); memset(kaddr + isize, 0, PAGE_SIZE - isize); flush_dcache_page(page); SetPageUptodate(page); - kunmap_atomic(kaddr); + kunmap_local(kaddr); } static int udf_read_folio(struct file *file, struct folio *folio)
Instead of using kmap_atomic() use kmap_local_page() in udf_adinicb_readpage(). Signed-off-by: Jan Kara <jack@suse.cz> --- fs/udf/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)