| Message ID | 20230123182021.31239-1-gustavo.sousa@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Use unversioned blob path for ADLP DMC | expand |
On Mon, Jan 23, 2023 at 08:19:59PM +0000, Patchwork wrote: > == Series Details == > > Series: Use unversioned blob path for ADLP DMC > URL : https://patchwork.freedesktop.org/series/113238/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_12624 -> Patchwork_113238v1 > ==================================================== > > Summary > ------- > > **SUCCESS** > > No regressions found. > > External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/index.html CI is clean, however, looking at the logs for igt@i915_module_load@load on ADLP (e.g. [1]), it looks like the adlp_dmc.bin firmware blob is missing, so the tests ended up using ADLP DMC v2.16 instead of v2.18. (On the bright side, at least that confirmst that the fallback mechanism works :-)) I thought this PR[2], sent to this list, would make the blobs available to CI. Did I do something wrong there? [1]: "Results for igt@i915_module_load@load on bat-adlp-6" (https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/bat-adlp-6/igt@i915_module_load@load.html) [2]: "[Intel-gfx] [CI] PR for ADLP DMC 2.18 and MTL DMC 2.11" (https://lists.freedesktop.org/archives/intel-gfx/2023-January/316102.html) -- Gustavo Sousa > > Participating hosts (38 -> 38) > ------------------------------ > > Additional (2): fi-kbl-soraka fi-pnv-d510 > Missing (2): fi-rkl-11600 fi-snb-2520m > > Known issues > ------------ > > Here are the changes found in Patchwork_113238v1 that come from known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@gem_huc_copy@huc-copy: > - fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190]) > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html > > * igt@gem_lmem_swapping@basic: > - fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 similar issues > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html > > * igt@i915_selftest@live@gt_pm: > - fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][3] ([i915#1886]) > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html > > * igt@i915_selftest@live@guc_multi_lrc: > - fi-kbl-soraka: NOTRUN -> [INCOMPLETE][4] ([i915#7640]) > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@i915_selftest@live@guc_multi_lrc.html > > * igt@i915_selftest@live@hangcheck: > - fi-rkl-guc: [PASS][5] -> [INCOMPLETE][6] ([i915#4983]) > [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/fi-rkl-guc/igt@i915_selftest@live@hangcheck.html > [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-rkl-guc/igt@i915_selftest@live@hangcheck.html > > * igt@kms_chamelium_frames@hdmi-crc-fast: > - fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271]) +15 similar issues > [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html > > * igt@kms_psr@primary_page_flip: > - fi-pnv-d510: NOTRUN -> [SKIP][8] ([fdo#109271]) +44 similar issues > [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-pnv-d510/igt@kms_psr@primary_page_flip.html > > > #### Possible fixes #### > > * igt@i915_selftest@live@gt_mocs: > - {bat-rpls-1}: [DMESG-FAIL][9] ([i915#7059]) -> [PASS][10] > [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/bat-rpls-1/igt@i915_selftest@live@gt_mocs.html > [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/bat-rpls-1/igt@i915_selftest@live@gt_mocs.html > > * igt@i915_selftest@live@requests: > - {bat-rpls-2}: [INCOMPLETE][11] ([i915#6257]) -> [PASS][12] > [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/bat-rpls-2/igt@i915_selftest@live@requests.html > [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/bat-rpls-2/igt@i915_selftest@live@requests.html > - {bat-rpls-1}: [INCOMPLETE][13] ([i915#4983]) -> [PASS][14] > [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/bat-rpls-1/igt@i915_selftest@live@requests.html > [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/bat-rpls-1/igt@i915_selftest@live@requests.html > > * igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions: > - fi-bsw-kefka: [FAIL][15] ([i915#6298]) -> [PASS][16] > [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html > [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html > > > {name}: This element is suppressed. This means it is ignored when computing > the status of the difference (SUCCESS, WARNING, or FAILURE). > > [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 > [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 > [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886 > [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 > [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 > [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 > [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 > [i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257 > [i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298 > [i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997 > [i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059 > [i915#7640]: https://gitlab.freedesktop.org/drm/intel/issues/7640 > [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 > > > Build changes > ------------- > > * Linux: CI_DRM_12624 -> Patchwork_113238v1 > > CI-20190529: 20190529 > CI_DRM_12624: 18fa3d2237f6df82980349f6bef5281096dfc91d @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_7134: 61b8c0a0c8a9611c47749c0b1a262843892cccd7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git > Patchwork_113238v1: 18fa3d2237f6df82980349f6bef5281096dfc91d @ git://anongit.freedesktop.org/gfx-ci/linux > > > ### Linux commits > > 2b1f15adacc1 drm/i915/dmc: Use unversioned path for ADLP > e1384510d25a drm/i915/dmc: Prepare to use unversioned paths > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/index.html
On Tue, Jan 24, 2023 at 01:39:59PM -0300, Gustavo Sousa wrote: > On Mon, Jan 23, 2023 at 08:19:59PM +0000, Patchwork wrote: > > == Series Details == > > > > Series: Use unversioned blob path for ADLP DMC > > URL : https://patchwork.freedesktop.org/series/113238/ > > State : success > > > > == Summary == > > > > CI Bug Log - changes from CI_DRM_12624 -> Patchwork_113238v1 > > ==================================================== > > > > Summary > > ------- > > > > **SUCCESS** > > > > No regressions found. > > > > External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/index.html > > CI is clean, however, looking at the logs for igt@i915_module_load@load > on ADLP (e.g. [1]), it looks like the adlp_dmc.bin firmware blob is > missing, so the tests ended up using ADLP DMC v2.16 instead of v2.18. > > (On the bright side, at least that confirmst that the fallback mechanism > works :-)) That's nice! This gave me more confidence to push the series! :) > > I thought this PR[2], sent to this list, would make the blobs available > to CI. Did I do something wrong there? my understanding is that the CI would pick the PR for run a local test. But also that was prepared for the PR with kernel changes simultaneously, not sure right now. Someone on CI would have to check and fix for the new flow. But anyway that was a temporary get, to the final one. After that gets integrated to linux-firmware.git someone in CI was doing a manual sync/update iirc. > > > [1]: "Results for igt@i915_module_load@load on bat-adlp-6" > (https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/bat-adlp-6/igt@i915_module_load@load.html) > [2]: "[Intel-gfx] [CI] PR for ADLP DMC 2.18 and MTL DMC 2.11" > (https://lists.freedesktop.org/archives/intel-gfx/2023-January/316102.html) > > -- > Gustavo Sousa > > > > > Participating hosts (38 -> 38) > > ------------------------------ > > > > Additional (2): fi-kbl-soraka fi-pnv-d510 > > Missing (2): fi-rkl-11600 fi-snb-2520m > > > > Known issues > > ------------ > > > > Here are the changes found in Patchwork_113238v1 that come from known issues: > > > > ### IGT changes ### > > > > #### Issues hit #### > > > > * igt@gem_huc_copy@huc-copy: > > - fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190]) > > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html > > > > * igt@gem_lmem_swapping@basic: > > - fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 similar issues > > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html > > > > * igt@i915_selftest@live@gt_pm: > > - fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][3] ([i915#1886]) > > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html > > > > * igt@i915_selftest@live@guc_multi_lrc: > > - fi-kbl-soraka: NOTRUN -> [INCOMPLETE][4] ([i915#7640]) > > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@i915_selftest@live@guc_multi_lrc.html > > > > * igt@i915_selftest@live@hangcheck: > > - fi-rkl-guc: [PASS][5] -> [INCOMPLETE][6] ([i915#4983]) > > [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/fi-rkl-guc/igt@i915_selftest@live@hangcheck.html > > [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-rkl-guc/igt@i915_selftest@live@hangcheck.html > > > > * igt@kms_chamelium_frames@hdmi-crc-fast: > > - fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271]) +15 similar issues > > [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html > > > > * igt@kms_psr@primary_page_flip: > > - fi-pnv-d510: NOTRUN -> [SKIP][8] ([fdo#109271]) +44 similar issues > > [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-pnv-d510/igt@kms_psr@primary_page_flip.html > > > > > > #### Possible fixes #### > > > > * igt@i915_selftest@live@gt_mocs: > > - {bat-rpls-1}: [DMESG-FAIL][9] ([i915#7059]) -> [PASS][10] > > [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/bat-rpls-1/igt@i915_selftest@live@gt_mocs.html > > [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/bat-rpls-1/igt@i915_selftest@live@gt_mocs.html > > > > * igt@i915_selftest@live@requests: > > - {bat-rpls-2}: [INCOMPLETE][11] ([i915#6257]) -> [PASS][12] > > [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/bat-rpls-2/igt@i915_selftest@live@requests.html > > [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/bat-rpls-2/igt@i915_selftest@live@requests.html > > - {bat-rpls-1}: [INCOMPLETE][13] ([i915#4983]) -> [PASS][14] > > [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/bat-rpls-1/igt@i915_selftest@live@requests.html > > [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/bat-rpls-1/igt@i915_selftest@live@requests.html > > > > * igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions: > > - fi-bsw-kefka: [FAIL][15] ([i915#6298]) -> [PASS][16] > > [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html > > [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html > > > > > > {name}: This element is suppressed. This means it is ignored when computing > > the status of the difference (SUCCESS, WARNING, or FAILURE). > > > > [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 > > [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 > > [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886 > > [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 > > [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 > > [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 > > [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 > > [i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257 > > [i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298 > > [i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997 > > [i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059 > > [i915#7640]: https://gitlab.freedesktop.org/drm/intel/issues/7640 > > [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 > > > > > > Build changes > > ------------- > > > > * Linux: CI_DRM_12624 -> Patchwork_113238v1 > > > > CI-20190529: 20190529 > > CI_DRM_12624: 18fa3d2237f6df82980349f6bef5281096dfc91d @ git://anongit.freedesktop.org/gfx-ci/linux > > IGT_7134: 61b8c0a0c8a9611c47749c0b1a262843892cccd7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git > > Patchwork_113238v1: 18fa3d2237f6df82980349f6bef5281096dfc91d @ git://anongit.freedesktop.org/gfx-ci/linux > > > > > > ### Linux commits > > > > 2b1f15adacc1 drm/i915/dmc: Use unversioned path for ADLP > > e1384510d25a drm/i915/dmc: Prepare to use unversioned paths > > > > == Logs == > > > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/index.html
This series introduces the use of unversioned blob path for ADLP DMC, which begins using the new convention as of v2.18. In order not to cause regressions with systems not having linux-firmware up to date, we recall a patch from [1] that adds a fallback mechanism to load from the latest versioned path in case the unversioned one is not found. IMPORTANT: Prior to applying this, we need to wait for a PR to linux-firmware with the proper update to be applied. I will create such PR after this series is accepted and CI results are good. [1]: "drm/i915/dmc: Make firmware loading backwards-compatible" https://patchwork.freedesktop.org/series/112116/ Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com> Gustavo Sousa (2): drm/i915/dmc: Prepare to use unversioned paths drm/i915/dmc: Use unversioned path for ADLP drivers/gpu/drm/i915/display/intel_dmc.c | 66 ++++++++++++++++++------ 1 file changed, 50 insertions(+), 16 deletions(-)