| Message ID | 20230124192351.695838-1-ahalaney@redhat.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] arm64: dts: qcom: sa8540p-ride: Fix some i2c pinctrl settings | expand |
On Tue, Jan 24, 2023 at 01:23:50PM -0600, Andrew Halaney wrote: > Some of the pinctrl groups were invalid for the selected pins. Select > the proper qup group to fix these warnings: > > [ 6.523566] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio135" for function "qup15" > [ 6.535042] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio136" for function "qup15" > [ 6.597536] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio158" for function "qup15" > [ 6.597544] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio159" for function "qup15" > [ 6.597991] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio0" for function "qup15" > [ 6.597996] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio1" for function "qup15" > > Fixes: e073899ec3e1 ("arm64: dts: qcom: sa8540p-ride: add i2c nodes") > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> Reviewed-by: Brian Masney <bmasney@redhat.com>
On 24.01.2023 20:23, Andrew Halaney wrote: > Some of the pinctrl groups were invalid for the selected pins. Select > the proper qup group to fix these warnings: > > [ 6.523566] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio135" for function "qup15" > [ 6.535042] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio136" for function "qup15" > [ 6.597536] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio158" for function "qup15" > [ 6.597544] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio159" for function "qup15" > [ 6.597991] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio0" for function "qup15" > [ 6.597996] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio1" for function "qup15" > > Fixes: e073899ec3e1 ("arm64: dts: qcom: sa8540p-ride: add i2c nodes") > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> > --- This matches the pinctrl .c driver. Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts > index eacc1764255b..cb9fbdeb5a9e 100644 > --- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts > +++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts > @@ -318,21 +318,21 @@ &xo_board_clk { > &tlmm { > i2c0_default: i2c0-default-state { > pins = "gpio135", "gpio136"; > - function = "qup15"; > + function = "qup0"; > drive-strength = <2>; > bias-pull-up; > }; > > i2c1_default: i2c1-default-state { > pins = "gpio158", "gpio159"; > - function = "qup15"; > + function = "qup1"; > drive-strength = <2>; > bias-pull-up; > }; > > i2c12_default: i2c12-default-state { > pins = "gpio0", "gpio1"; > - function = "qup15"; > + function = "qup12"; > drive-strength = <2>; > bias-pull-up; > };
On 1/25/2023 12:53 AM, Andrew Halaney wrote: > Some of the pinctrl groups were invalid for the selected pins. Select > the proper qup group to fix these warnings: > > [ 6.523566] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio135" for function "qup15" > [ 6.535042] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio136" for function "qup15" > [ 6.597536] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio158" for function "qup15" > [ 6.597544] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio159" for function "qup15" > [ 6.597991] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio0" for function "qup15" > [ 6.597996] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio1" for function "qup15" > > Fixes: e073899ec3e1 ("arm64: dts: qcom: sa8540p-ride: add i2c nodes") > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> > --- Reviewed-by: Shazad Hussain <quic_shazhuss@quicinc.com> > arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts > index eacc1764255b..cb9fbdeb5a9e 100644 > --- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts > +++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts > @@ -318,21 +318,21 @@ &xo_board_clk { > &tlmm { > i2c0_default: i2c0-default-state { > pins = "gpio135", "gpio136"; > - function = "qup15"; > + function = "qup0"; > drive-strength = <2>; > bias-pull-up; > }; > > i2c1_default: i2c1-default-state { > pins = "gpio158", "gpio159"; > - function = "qup15"; > + function = "qup1"; > drive-strength = <2>; > bias-pull-up; > }; > > i2c12_default: i2c12-default-state { > pins = "gpio0", "gpio1"; > - function = "qup15"; > + function = "qup12"; > drive-strength = <2>; > bias-pull-up; > };
diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts index eacc1764255b..cb9fbdeb5a9e 100644 --- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts +++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts @@ -318,21 +318,21 @@ &xo_board_clk { &tlmm { i2c0_default: i2c0-default-state { pins = "gpio135", "gpio136"; - function = "qup15"; + function = "qup0"; drive-strength = <2>; bias-pull-up; }; i2c1_default: i2c1-default-state { pins = "gpio158", "gpio159"; - function = "qup15"; + function = "qup1"; drive-strength = <2>; bias-pull-up; }; i2c12_default: i2c12-default-state { pins = "gpio0", "gpio1"; - function = "qup15"; + function = "qup12"; drive-strength = <2>; bias-pull-up; };
Some of the pinctrl groups were invalid for the selected pins. Select the proper qup group to fix these warnings: [ 6.523566] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio135" for function "qup15" [ 6.535042] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio136" for function "qup15" [ 6.597536] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio158" for function "qup15" [ 6.597544] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio159" for function "qup15" [ 6.597991] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio0" for function "qup15" [ 6.597996] sc8280xp-tlmm f100000.pinctrl: invalid group "gpio1" for function "qup15" Fixes: e073899ec3e1 ("arm64: dts: qcom: sa8540p-ride: add i2c nodes") Signed-off-by: Andrew Halaney <ahalaney@redhat.com> --- arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)