diff mbox series

[7/8] dt-bindings: interrupt-controller: Add Amlogic Meson GPIO interrupt controller binding

Message ID 06289641-18b1-320d-6162-7ae176452f31@gmail.com (mailing list archive)
State Superseded
Headers show
Series soc: amlogic: switch bindings to yaml and adjust some dtbs's | expand

Commit Message

Heiner Kallweit Jan. 23, 2023, 9:30 p.m. UTC 
Add Amlogic Meson GPIO interrupt controller binding.
Tested with make targets dt_binding_check and dtbs_check.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 .../amlogic,meson-gpio-intc.txt               | 38 ----------
 .../amlogic,meson-gpio-intc.yaml              | 72 +++++++++++++++++++
 2 files changed, 72 insertions(+), 38 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml

Comments

Rob Herring Jan. 24, 2023, 1:22 a.m. UTC | #1 
On Mon, 23 Jan 2023 22:30:08 +0100, Heiner Kallweit wrote:
> Add Amlogic Meson GPIO interrupt controller binding.
> Tested with make targets dt_binding_check and dtbs_check.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>  .../amlogic,meson-gpio-intc.txt               | 38 ----------
>  .../amlogic,meson-gpio-intc.yaml              | 72 +++++++++++++++++++
>  2 files changed, 72 insertions(+), 38 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
> 

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/06289641-18b1-320d-6162-7ae176452f31@gmail.com


interrupt-controller@4080: compatible: ['amlogic,meson-s4-gpio-intc', 'amlogic,meson-gpio-intc'] is too long
	arch/arm64/boot/dts/amlogic/meson-s4-s805x2-aq222.dtb

interrupt-controller@9880: compatible:0: 'amlogic,meson-gpio-intc' is not one of ['amlogic,meson8-gpio-intc', 'amlogic,meson8b-gpio-intc', 'amlogic,meson-gxbb-gpio-intc', 'amlogic,meson-gxl-gpio-intc', 'amlogic,meson-axg-gpio-intc', 'amlogic,meson-g12a-gpio-intc', 'amlogic,meson-sm1-gpio-intc', 'amlogic,meson-a1-gpio-intc', 'amlogic,meson-s4-gpio-intc', 'amlogic,meson-sc2-gpio-intc']
	arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dtb
	arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dtb
	arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dtb
	arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dtb
	arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dtb
	arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dtb
	arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-meta.dtb
	arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-pro.dtb
	arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-telos.dtb
	arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dtb
	arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s805x-libretech-ac.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s805x-p241.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-libretech-pc.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-mecool-kii-pro.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p231.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-sml5442tw.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-vero4k-plus.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905w-p281.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905w-tx3-mini.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-hwacom-amazetv.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc-v2.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-nexbox-a95x.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-p212.dtb
	arch/arm64/boot/dts/amlogic/meson-gxm-gt1-ultimate.dtb
	arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dtb
	arch/arm64/boot/dts/amlogic/meson-gxm-mecool-kiii-pro.dtb
	arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dtb
	arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dtb
	arch/arm64/boot/dts/amlogic/meson-gxm-q200.dtb
	arch/arm64/boot/dts/amlogic/meson-gxm-q201.dtb
	arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dtb
	arch/arm64/boot/dts/amlogic/meson-gxm-s912-libretech-pc.dtb
	arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dtb
	arch/arm64/boot/dts/amlogic/meson-gxm-wetek-core2.dtb
	arch/arm/boot/dts/meson8b-ec100.dtb
	arch/arm/boot/dts/meson8b-mxq.dtb
	arch/arm/boot/dts/meson8b-odroidc1.dtb

interrupt-controller@9880: compatible: ['amlogic,meson8-gpio-intc', 'amlogic,meson-gpio-intc'] is too long
	arch/arm/boot/dts/meson8m2-mxiii-plus.dtb
	arch/arm/boot/dts/meson8-minix-neo-x8.dtb

interrupt-controller@9880: compatible: ['amlogic,meson-gpio-intc', 'amlogic,meson8b-gpio-intc'] is too long
	arch/arm/boot/dts/meson8b-ec100.dtb
	arch/arm/boot/dts/meson8b-mxq.dtb
	arch/arm/boot/dts/meson8b-odroidc1.dtb

interrupt-controller@9880: compatible: ['amlogic,meson-gpio-intc', 'amlogic,meson-gxbb-gpio-intc'] is too long
	arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dtb
	arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dtb
	arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dtb
	arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dtb
	arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dtb
	arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dtb
	arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-meta.dtb
	arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-pro.dtb
	arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-telos.dtb
	arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dtb
	arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dtb

interrupt-controller@9880: compatible: ['amlogic,meson-gpio-intc', 'amlogic,meson-gxl-gpio-intc'] is too long
	arch/arm64/boot/dts/amlogic/meson-gxl-s805x-libretech-ac.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s805x-p241.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-libretech-pc.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-mecool-kii-pro.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p231.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-sml5442tw.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-vero4k-plus.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905w-p281.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905w-tx3-mini.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-hwacom-amazetv.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc-v2.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-nexbox-a95x.dtb
	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-p212.dtb
	arch/arm64/boot/dts/amlogic/meson-gxm-gt1-ultimate.dtb
	arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dtb
	arch/arm64/boot/dts/amlogic/meson-gxm-mecool-kiii-pro.dtb
	arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dtb
	arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dtb
	arch/arm64/boot/dts/amlogic/meson-gxm-q200.dtb
	arch/arm64/boot/dts/amlogic/meson-gxm-q201.dtb
	arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dtb
	arch/arm64/boot/dts/amlogic/meson-gxm-s912-libretech-pc.dtb
	arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dtb
	arch/arm64/boot/dts/amlogic/meson-gxm-wetek-core2.dtb

interrupt-controller@f080: compatible: ['amlogic,meson-axg-gpio-intc', 'amlogic,meson-gpio-intc'] is too long
	arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dtb
	arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j110-rev-2.dtb
	arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j110-rev-3.dtb
	arch/arm64/boot/dts/amlogic/meson-axg-s400.dtb

interrupt-controller@f080: compatible: ['amlogic,meson-g12a-gpio-intc', 'amlogic,meson-gpio-intc'] is too long
	arch/arm64/boot/dts/amlogic/meson-g12a-radxa-zero.dtb
	arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dtb
	arch/arm64/boot/dts/amlogic/meson-g12a-u200.dtb
	arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dtb
	arch/arm64/boot/dts/amlogic/meson-g12b-a311d-khadas-vim3.dtb
	arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dtb
	arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dtb
	arch/arm64/boot/dts/amlogic/meson-g12b-gtking-pro.dtb
	arch/arm64/boot/dts/amlogic/meson-g12b-odroid-go-ultra.dtb
	arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtb
	arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dtb
	arch/arm64/boot/dts/amlogic/meson-g12b-s922x-khadas-vim3.dtb
	arch/arm64/boot/dts/amlogic/meson-g12b-ugoos-am6.dtb

interrupt-controller@f080: compatible: ['amlogic,meson-sm1-gpio-intc', 'amlogic,meson-gpio-intc'] is too long
	arch/arm64/boot/dts/amlogic/meson-sm1-a95xf3-air.dtb
	arch/arm64/boot/dts/amlogic/meson-sm1-a95xf3-air-gbit.dtb
	arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dtb
	arch/arm64/boot/dts/amlogic/meson-sm1-h96-max.dtb
	arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dtb
	arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dtb
	arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dtb
	arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dtb
	arch/arm64/boot/dts/amlogic/meson-sm1-x96-air.dtb
	arch/arm64/boot/dts/amlogic/meson-sm1-x96-air-gbit.dtb
Heiner Kallweit Jan. 24, 2023, 7:03 a.m. UTC | #2 
On 24.01.2023 02:22, Rob Herring wrote:
> 
> On Mon, 23 Jan 2023 22:30:08 +0100, Heiner Kallweit wrote:
>> Add Amlogic Meson GPIO interrupt controller binding.
>> Tested with make targets dt_binding_check and dtbs_check.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>>  .../amlogic,meson-gpio-intc.txt               | 38 ----------
>>  .../amlogic,meson-gpio-intc.yaml              | 72 +++++++++++++++++++
>>  2 files changed, 72 insertions(+), 38 deletions(-)
>>  delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
>>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
>>
> 
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
> 

Patch 4 of the series fixes these warnings.
Did you apply the full series?


> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
> 
> Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/06289641-18b1-320d-6162-7ae176452f31@gmail.com
> 
> 
> interrupt-controller@4080: compatible: ['amlogic,meson-s4-gpio-intc', 'amlogic,meson-gpio-intc'] is too long
> 	arch/arm64/boot/dts/amlogic/meson-s4-s805x2-aq222.dtb
> 
> interrupt-controller@9880: compatible:0: 'amlogic,meson-gpio-intc' is not one of ['amlogic,meson8-gpio-intc', 'amlogic,meson8b-gpio-intc', 'amlogic,meson-gxbb-gpio-intc', 'amlogic,meson-gxl-gpio-intc', 'amlogic,meson-axg-gpio-intc', 'amlogic,meson-g12a-gpio-intc', 'amlogic,meson-sm1-gpio-intc', 'amlogic,meson-a1-gpio-intc', 'amlogic,meson-s4-gpio-intc', 'amlogic,meson-sc2-gpio-intc']
> 	arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-meta.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-pro.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-telos.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s805x-libretech-ac.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s805x-p241.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-libretech-pc.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-mecool-kii-pro.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p231.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-sml5442tw.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-vero4k-plus.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905w-p281.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905w-tx3-mini.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-hwacom-amazetv.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc-v2.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-nexbox-a95x.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-p212.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxm-gt1-ultimate.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxm-mecool-kiii-pro.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxm-q200.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxm-q201.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxm-s912-libretech-pc.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxm-wetek-core2.dtb
> 	arch/arm/boot/dts/meson8b-ec100.dtb
> 	arch/arm/boot/dts/meson8b-mxq.dtb
> 	arch/arm/boot/dts/meson8b-odroidc1.dtb
> 
> interrupt-controller@9880: compatible: ['amlogic,meson8-gpio-intc', 'amlogic,meson-gpio-intc'] is too long
> 	arch/arm/boot/dts/meson8m2-mxiii-plus.dtb
> 	arch/arm/boot/dts/meson8-minix-neo-x8.dtb
> 
> interrupt-controller@9880: compatible: ['amlogic,meson-gpio-intc', 'amlogic,meson8b-gpio-intc'] is too long
> 	arch/arm/boot/dts/meson8b-ec100.dtb
> 	arch/arm/boot/dts/meson8b-mxq.dtb
> 	arch/arm/boot/dts/meson8b-odroidc1.dtb
> 
> interrupt-controller@9880: compatible: ['amlogic,meson-gpio-intc', 'amlogic,meson-gxbb-gpio-intc'] is too long
> 	arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-meta.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-pro.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-telos.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dtb
> 
> interrupt-controller@9880: compatible: ['amlogic,meson-gpio-intc', 'amlogic,meson-gxl-gpio-intc'] is too long
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s805x-libretech-ac.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s805x-p241.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-libretech-pc.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-mecool-kii-pro.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p231.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-sml5442tw.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905d-vero4k-plus.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905w-p281.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905w-tx3-mini.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-hwacom-amazetv.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc-v2.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-nexbox-a95x.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxl-s905x-p212.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxm-gt1-ultimate.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxm-mecool-kiii-pro.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxm-q200.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxm-q201.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxm-s912-libretech-pc.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dtb
> 	arch/arm64/boot/dts/amlogic/meson-gxm-wetek-core2.dtb
> 
> interrupt-controller@f080: compatible: ['amlogic,meson-axg-gpio-intc', 'amlogic,meson-gpio-intc'] is too long
> 	arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dtb
> 	arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j110-rev-2.dtb
> 	arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j110-rev-3.dtb
> 	arch/arm64/boot/dts/amlogic/meson-axg-s400.dtb
> 
> interrupt-controller@f080: compatible: ['amlogic,meson-g12a-gpio-intc', 'amlogic,meson-gpio-intc'] is too long
> 	arch/arm64/boot/dts/amlogic/meson-g12a-radxa-zero.dtb
> 	arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dtb
> 	arch/arm64/boot/dts/amlogic/meson-g12a-u200.dtb
> 	arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dtb
> 	arch/arm64/boot/dts/amlogic/meson-g12b-a311d-khadas-vim3.dtb
> 	arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dtb
> 	arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dtb
> 	arch/arm64/boot/dts/amlogic/meson-g12b-gtking-pro.dtb
> 	arch/arm64/boot/dts/amlogic/meson-g12b-odroid-go-ultra.dtb
> 	arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtb
> 	arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dtb
> 	arch/arm64/boot/dts/amlogic/meson-g12b-s922x-khadas-vim3.dtb
> 	arch/arm64/boot/dts/amlogic/meson-g12b-ugoos-am6.dtb
> 
> interrupt-controller@f080: compatible: ['amlogic,meson-sm1-gpio-intc', 'amlogic,meson-gpio-intc'] is too long
> 	arch/arm64/boot/dts/amlogic/meson-sm1-a95xf3-air.dtb
> 	arch/arm64/boot/dts/amlogic/meson-sm1-a95xf3-air-gbit.dtb
> 	arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dtb
> 	arch/arm64/boot/dts/amlogic/meson-sm1-h96-max.dtb
> 	arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dtb
> 	arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dtb
> 	arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dtb
> 	arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dtb
> 	arch/arm64/boot/dts/amlogic/meson-sm1-x96-air.dtb
> 	arch/arm64/boot/dts/amlogic/meson-sm1-x96-air-gbit.dtb
>
Rob Herring Jan. 25, 2023, 4:46 p.m. UTC | #3 
On Tue, Jan 24, 2023 at 1:04 AM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> On 24.01.2023 02:22, Rob Herring wrote:
> >
> > On Mon, 23 Jan 2023 22:30:08 +0100, Heiner Kallweit wrote:
> >> Add Amlogic Meson GPIO interrupt controller binding.
> >> Tested with make targets dt_binding_check and dtbs_check.
> >>
> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> >> ---
> >>  .../amlogic,meson-gpio-intc.txt               | 38 ----------
> >>  .../amlogic,meson-gpio-intc.yaml              | 72 +++++++++++++++++++
> >>  2 files changed, 72 insertions(+), 38 deletions(-)
> >>  delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
> >>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
> >>
> >
> > Running 'make dtbs_check' with the schema in this patch gives the
> > following warnings. Consider if they are expected or the schema is
> > incorrect. These may not be new warnings.
> >
>
> Patch 4 of the series fixes these warnings.

Then you can ignore them.

You did change the binding somewhat and that should be detailed in the
commit message. Granted, the original details on 'compatible' seem to
have a typo and are ambiguous on the order of entries.

> Did you apply the full series?

No, because patchwork doesn't get the full series nor do I see the
full thread when reviewing these bot emails before sending them. If I
see a conversion and warnings that look like the schema should be
fixed rather than the dts files, then you get this email. Though on
further review, dropping 'amlogic,meson-gpio-intc' seems fine given it
is often in the wrong spot (it should be last as it is least
specific).

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
deleted file mode 100644
index bde63f8f0..000000000
--- a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
+++ /dev/null
@@ -1,38 +0,0 @@ 
-Amlogic meson GPIO interrupt controller
-
-Meson SoCs contains an interrupt controller which is able to watch the SoC
-pads and generate an interrupt on edge or level. The controller is essentially
-a 256 pads to 8 GIC interrupt multiplexer, with a filter block to select edge
-or level and polarity. It does not expose all 256 mux inputs because the
-documentation shows that the upper part is not mapped to any pad. The actual
-number of interrupt exposed depends on the SoC.
-
-Required properties:
-
-- compatible : must have "amlogic,meson8-gpio-intc" and either
-    "amlogic,meson8-gpio-intc" for meson8 SoCs (S802) or
-    "amlogic,meson8b-gpio-intc" for meson8b SoCs (S805) or
-    "amlogic,meson-gxbb-gpio-intc" for GXBB SoCs (S905) or
-    "amlogic,meson-gxl-gpio-intc" for GXL SoCs (S905X, S912)
-    "amlogic,meson-axg-gpio-intc" for AXG SoCs (A113D, A113X)
-    "amlogic,meson-g12a-gpio-intc" for G12A SoCs (S905D2, S905X2, S905Y2)
-    "amlogic,meson-sm1-gpio-intc" for SM1 SoCs (S905D3, S905X3, S905Y3)
-    "amlogic,meson-a1-gpio-intc" for A1 SoCs (A113L)
-    "amlogic,meson-s4-gpio-intc" for S4 SoCs (S802X2, S905Y4, S805X2G, S905W2)
-- reg : Specifies base physical address and size of the registers.
-- interrupt-controller : Identifies the node as an interrupt controller.
-- #interrupt-cells : Specifies the number of cells needed to encode an
-   interrupt source. The value must be 2.
-- meson,channel-interrupts: Array with the 8 upstream hwirq numbers. These
-   are the hwirqs used on the parent interrupt controller.
-
-Example:
-
-gpio_interrupt: interrupt-controller@9880 {
-	compatible = "amlogic,meson-gxbb-gpio-intc",
-		     "amlogic,meson-gpio-intc";
-	reg = <0x0 0x9880 0x0 0x10>;
-	interrupt-controller;
-	#interrupt-cells = <2>;
-	meson,channel-interrupts = <64 65 66 67 68 69 70 71>;
-};
diff --git a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
new file mode 100644
index 000000000..2f6261b9e
--- /dev/null
+++ b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
@@ -0,0 +1,72 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/interrupt-controller/amlogic,meson-gpio-intc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Amlogic Meson GPIO interrupt controller
+
+maintainers:
+  - Heiner Kallweit <hkallweit1@gmail.com>
+
+description: |
+  Meson SoCs contains an interrupt controller which is able to watch the SoC
+  pads and generate an interrupt on edge or level. The controller is essentially
+  a 256 pads to 8 GIC interrupt multiplexer, with a filter block to select edge
+  or level and polarity. It does not expose all 256 mux inputs because the
+  documentation shows that the upper part is not mapped to any pad. The actual
+  number of interrupt exposed depends on the SoC.
+
+allOf:
+  - $ref: /schemas/interrupt-controller.yaml#
+
+properties:
+  compatible:
+    enum:
+      - amlogic,meson8-gpio-intc
+      - amlogic,meson8b-gpio-intc
+      - amlogic,meson-gxbb-gpio-intc
+      - amlogic,meson-gxl-gpio-intc
+      - amlogic,meson-axg-gpio-intc
+      - amlogic,meson-g12a-gpio-intc
+      - amlogic,meson-sm1-gpio-intc
+      - amlogic,meson-a1-gpio-intc
+      - amlogic,meson-s4-gpio-intc
+      - amlogic,meson-sc2-gpio-intc
+
+  reg:
+    maxItems: 1
+
+  interrupt-controller: true
+
+  "#interrupt-cells":
+    const: 2
+
+  amlogic,channel-interrupts:
+    description: Array with the upstream hwirq numbers
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+
+required:
+  - compatible
+  - reg
+  - interrupt-controller
+  - "#interrupt-cells"
+  - amlogic,channel-interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    bus@c1100000 {
+      reg = <0x0 0xc1100000 0x0 0x100000>;
+      #address-cells = <2>;
+      #size-cells = <2>;
+
+      interrupt-controller@9880 {
+        compatible = "amlogic,meson-gxbb-gpio-intc";
+        reg = <0x0 0x9880 0x0 0x10>;
+        interrupt-controller;
+        #interrupt-cells = <2>;
+        amlogic,channel-interrupts = <64 65 66 67 68 69 70 71>;
+      };
+    };