[v2] dt-bindings: leds: Document Bluetooth and WLAN triggers

Commit Message

Geert Uytterhoeven Jan. 22, 2023, 10:47 a.m. UTC

Add the missing trigger patterns for Bluetooth and WLAN activity, which
are already in active use.

While at it, move the mmc pattern comment where it belongs, and restore
alphabetical sort order.

Signed-off-by: Geert Uytterhoeven <[e-mail]>
Reviewed-by: Rob Herring <[e-mail]>
---
arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: bt_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
	'hci0-power' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
	'hci0-power' does not match '^mmc[0-9]+$'
	From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: wlan_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
	'phy0tx' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
	'phy0tx' does not match '^mmc[0-9]+$'
	From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml

v2:
  - Add Reviewed-by.
---
 Documentation/devicetree/bindings/leds/common.yaml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

[e-mail] Jan. 24, 2023, 11:40 p.m. UTC | #1

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Sun, 22 Jan 2023 11:47:27 +0100 you wrote:
> Add the missing trigger patterns for Bluetooth and WLAN activity, which
> are already in active use.
> 
> While at it, move the mmc pattern comment where it belongs, and restore
> alphabetical sort order.
> 
> Signed-off-by: Geert Uytterhoeven <[e-mail]>
> Reviewed-by: Rob Herring <[e-mail]>
> 
> [...]

Here is the summary with links:
  - [v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
    https://git.kernel.org/bluetooth/bluetooth-next/c/ef017002b93b

You are awesome, thank you!

Lee Jones Jan. 25, 2023, 3:12 p.m. UTC | #2

On Tue, 24 Jan 2023, [e-mail] wrote:

> Hello:
> 
> This patch was applied to bluetooth/bluetooth-next.git (master)
> by Luiz Augusto von Dentz <[e-mail]>:
> 
> On Sun, 22 Jan 2023 11:47:27 +0100 you wrote:
> > Add the missing trigger patterns for Bluetooth and WLAN activity, which
> > are already in active use.
> > 
> > While at it, move the mmc pattern comment where it belongs, and restore
> > alphabetical sort order.
> > 
> > Signed-off-by: Geert Uytterhoeven <[e-mail]>
> > Reviewed-by: Rob Herring <[e-mail]>
> > 
> > [...]
> 
> Here is the summary with links:
>   - [v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
>     https://git.kernel.org/bluetooth/bluetooth-next/c/ef017002b93b

Why are you taking LED patches through the Bluetooth tree?

Luiz Augusto von Dentz Jan. 25, 2023, 7:23 p.m. UTC | #3

Hi Lee,

On Wed, Jan 25, 2023 at 7:16 AM Lee Jones <[e-mail]> wrote:
>
> On Tue, 24 Jan 2023, [e-mail] wrote:
>
> > Hello:
> >
> > This patch was applied to bluetooth/bluetooth-next.git (master)
> > by Luiz Augusto von Dentz <[e-mail]>:
> >
> > On Sun, 22 Jan 2023 11:47:27 +0100 you wrote:
> > > Add the missing trigger patterns for Bluetooth and WLAN activity, which
> > > are already in active use.
> > >
> > > While at it, move the mmc pattern comment where it belongs, and restore
> > > alphabetical sort order.
> > >
> > > Signed-off-by: Geert Uytterhoeven <[e-mail]>
> > > Reviewed-by: Rob Herring <[e-mail]>
> > >
> > > [...]
> >
> > Here is the summary with links:
> >   - [v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
> >     https://git.kernel.org/bluetooth/bluetooth-next/c/ef017002b93b
>
> Why are you taking LED patches through the Bluetooth tree?

I assume there isn't a tree dedicated to dt-bindings/leds, not to
mention this was submitted to linux-bluetooth and nobody else other
than Rob reviewed it, anyway I'd be happy if the dt-bindings patches
would be handled elsewhere.

>
> --
> Lee Jones [李琼斯]

Lee Jones Jan. 26, 2023, 8 a.m. UTC | #4

On Wed, 25 Jan 2023, Luiz Augusto von Dentz wrote:

> Hi Lee,
> 
> On Wed, Jan 25, 2023 at 7:16 AM Lee Jones <[e-mail]> wrote:
> >
> > On Tue, 24 Jan 2023, [e-mail] wrote:
> >
> > > Hello:
> > >
> > > This patch was applied to bluetooth/bluetooth-next.git (master)
> > > by Luiz Augusto von Dentz <[e-mail]>:
> > >
> > > On Sun, 22 Jan 2023 11:47:27 +0100 you wrote:
> > > > Add the missing trigger patterns for Bluetooth and WLAN activity, which
> > > > are already in active use.
> > > >
> > > > While at it, move the mmc pattern comment where it belongs, and restore
> > > > alphabetical sort order.
> > > >
> > > > Signed-off-by: Geert Uytterhoeven <[e-mail]>
> > > > Reviewed-by: Rob Herring <[e-mail]>
> > > >
> > > > [...]
> > >
> > > Here is the summary with links:
> > >   - [v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
> > >     https://git.kernel.org/bluetooth/bluetooth-next/c/ef017002b93b
> >
> > Why are you taking LED patches through the Bluetooth tree?
> 
> I assume there isn't a tree dedicated to dt-bindings/leds

% ./scripts/get_maintainer.pl -f Documentation/devicetree/bindings/leds/common.yaml
 Pavel Machek <[e-mail]> (maintainer:LED SUBSYSTEM,in file)
 Lee Jones <[e-mail]> (maintainer:LED SUBSYSTEM)
 Rob Herring <[e-mail]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
 Krzysztof Kozlowski <[e-mail]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
 Jacek Anaszewski <[e-mail]> (in file)
 [e-mail] (open list:LED SUBSYSTEM)
 [e-mail] (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
 [e-mail] (open list)

> not to mention this was submitted to linux-bluetooth and nobody else
> other than Rob reviewed it,

To: Pavel Machek <[e-mail]>, Lee Jones <[e-mail]>,
    Rob Herring <[e-mail]>,
    Krzysztof Kozlowski <[e-mail]>,
    Jacek Anaszewski <[e-mail]>                                      
Cc: [e-mail], [e-mail],
    [e-mail], [e-mail],
    [e-mail],
    Geert Uytterhoeven <[e-mail]>,
    Rob Herring <[e-mail]>

> anyway I'd be happy if the dt-bindings patches
> would be handled elsewhere.

Yep, we got this. :)

Lee Jones Jan. 26, 2023, 8:01 a.m. UTC | #5

On Sun, 22 Jan 2023, Geert Uytterhoeven wrote:

> Add the missing trigger patterns for Bluetooth and WLAN activity, which
> are already in active use.
> 
> While at it, move the mmc pattern comment where it belongs, and restore
> alphabetical sort order.
> 
> Signed-off-by: Geert Uytterhoeven <[e-mail]>
> Reviewed-by: Rob Herring <[e-mail]>
> ---
> arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: bt_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> 	'hci0-power' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> 	'hci0-power' does not match '^mmc[0-9]+$'
> 	From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
> arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: wlan_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> 	'phy0tx' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> 	'phy0tx' does not match '^mmc[0-9]+$'
> 	From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
> 
> v2:
>   - Add Reviewed-by.
> ---
>  Documentation/devicetree/bindings/leds/common.yaml | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Applied, thanks

Krzysztof Kozlowski Jan. 26, 2023, 10:01 a.m. UTC | #6

On 25/01/2023 20:23, Luiz Augusto von Dentz wrote:
>>>> While at it, move the mmc pattern comment where it belongs, and restore
>>>> alphabetical sort order.
>>>>
>>>> Signed-off-by: Geert Uytterhoeven <[e-mail]>
>>>> Reviewed-by: Rob Herring <[e-mail]>
>>>>
>>>> [...]
>>>
>>> Here is the summary with links:
>>>   - [v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
>>>     https://git.kernel.org/bluetooth/bluetooth-next/c/ef017002b93b
>>
>> Why are you taking LED patches through the Bluetooth tree?
> 
> I assume there isn't a tree dedicated to dt-bindings/leds, not to

dt-bindings patches are supposed to go via subsystem (with drivers) or
as fallback via Rob's DT tree. The subsystem here is LED, so the patches
should be picked by Pavel and Lee, as maintainers of LED subsystem.

If the subsystem was Bluetooth, then the patch would be for you. I hope
that clarifies.

Best regards,
Krzysztof

Luiz Augusto von Dentz Jan. 26, 2023, 8:46 p.m. UTC | #7

Hi Lee,

On Thu, Jan 26, 2023 at 12:00 AM Lee Jones <[e-mail]> wrote:
>
> On Wed, 25 Jan 2023, Luiz Augusto von Dentz wrote:
>
> > Hi Lee,
> >
> > On Wed, Jan 25, 2023 at 7:16 AM Lee Jones <[e-mail]> wrote:
> > >
> > > On Tue, 24 Jan 2023, [e-mail] wrote:
> > >
> > > > Hello:
> > > >
> > > > This patch was applied to bluetooth/bluetooth-next.git (master)
> > > > by Luiz Augusto von Dentz <[e-mail]>:
> > > >
> > > > On Sun, 22 Jan 2023 11:47:27 +0100 you wrote:
> > > > > Add the missing trigger patterns for Bluetooth and WLAN activity, which
> > > > > are already in active use.
> > > > >
> > > > > While at it, move the mmc pattern comment where it belongs, and restore
> > > > > alphabetical sort order.
> > > > >
> > > > > Signed-off-by: Geert Uytterhoeven <[e-mail]>
> > > > > Reviewed-by: Rob Herring <[e-mail]>
> > > > >
> > > > > [...]
> > > >
> > > > Here is the summary with links:
> > > >   - [v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
> > > >     https://git.kernel.org/bluetooth/bluetooth-next/c/ef017002b93b
> > >
> > > Why are you taking LED patches through the Bluetooth tree?
> >
> > I assume there isn't a tree dedicated to dt-bindings/leds
>
> % ./scripts/get_maintainer.pl -f Documentation/devicetree/bindings/leds/common.yaml
>  Pavel Machek <[e-mail]> (maintainer:LED SUBSYSTEM,in file)
>  Lee Jones <[e-mail]> (maintainer:LED SUBSYSTEM)
>  Rob Herring <[e-mail]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>  Krzysztof Kozlowski <[e-mail]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>  Jacek Anaszewski <[e-mail]> (in file)
>  [e-mail] (open list:LED SUBSYSTEM)
>  [e-mail] (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>  [e-mail] (open list)

Well this doesn't tell us what parts of the dt_bindings have a
dedicated tree and which doesn't, anyway this doesn't show
linux-bluetooth so I wonder why people are CCing it.

> > not to mention this was submitted to linux-bluetooth and nobody else
> > other than Rob reviewed it,
>
> To: Pavel Machek <[e-mail]>, Lee Jones <[e-mail]>,
>     Rob Herring <[e-mail]>,
>     Krzysztof Kozlowski <[e-mail]>,
>     Jacek Anaszewski <[e-mail]>
> Cc: [e-mail], [e-mail],
>     [e-mail], [e-mail],
>     [e-mail],
>     Geert Uytterhoeven <[e-mail]>,
>     Rob Herring <[e-mail]>
>
> > anyway I'd be happy if the dt-bindings patches
> > would be handled elsewhere.
>
> Yep, we got this. :)

So if it starts with dt-binding: prefix shall we ignore? Or is just
for dt-bindings: leds? Or perhaps we can just ignore patches received
as CC: rather than directly To: field.

>
> --
> Lee Jones [李琼斯]

Krzysztof Kozlowski Jan. 27, 2023, 8:47 a.m. UTC | #8

On 26/01/2023 21:46, Luiz Augusto von Dentz wrote:
> Hi Lee,
> 
> On Thu, Jan 26, 2023 at 12:00 AM Lee Jones <[e-mail]> wrote:
>>
>> On Wed, 25 Jan 2023, Luiz Augusto von Dentz wrote:
>>
>>> Hi Lee,
>>>
>>> On Wed, Jan 25, 2023 at 7:16 AM Lee Jones <[e-mail]> wrote:
>>>>
>>>> On Tue, 24 Jan 2023, [e-mail] wrote:
>>>>
>>>>> Hello:
>>>>>
>>>>> This patch was applied to bluetooth/bluetooth-next.git (master)
>>>>> by Luiz Augusto von Dentz <[e-mail]>:
>>>>>
>>>>> On Sun, 22 Jan 2023 11:47:27 +0100 you wrote:
>>>>>> Add the missing trigger patterns for Bluetooth and WLAN activity, which
>>>>>> are already in active use.
>>>>>>
>>>>>> While at it, move the mmc pattern comment where it belongs, and restore
>>>>>> alphabetical sort order.
>>>>>>
>>>>>> Signed-off-by: Geert Uytterhoeven <[e-mail]>
>>>>>> Reviewed-by: Rob Herring <[e-mail]>
>>>>>>
>>>>>> [...]
>>>>>
>>>>> Here is the summary with links:
>>>>>   - [v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
>>>>>     https://git.kernel.org/bluetooth/bluetooth-next/c/ef017002b93b
>>>>
>>>> Why are you taking LED patches through the Bluetooth tree?
>>>
>>> I assume there isn't a tree dedicated to dt-bindings/leds
>>
>> % ./scripts/get_maintainer.pl -f Documentation/devicetree/bindings/leds/common.yaml
>>  Pavel Machek <[e-mail]> (maintainer:LED SUBSYSTEM,in file)
>>  Lee Jones <[e-mail]> (maintainer:LED SUBSYSTEM)
>>  Rob Herring <[e-mail]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>>  Krzysztof Kozlowski <[e-mail]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>>  Jacek Anaszewski <[e-mail]> (in file)
>>  [e-mail] (open list:LED SUBSYSTEM)
>>  [e-mail] (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>>  [e-mail] (open list)
> 
> Well this doesn't tell us what parts of the dt_bindings have a
> dedicated tree and which doesn't, 

There is no such "parts" anywhere. I don't understand that remark and
how is related here. This is a list of maintainers for this file. Why
information are you missing in MAINTAINERS? And why bindings would be
special (e.g. you don't miss this information for other parts of kernel)?

>>
>>> anyway I'd be happy if the dt-bindings patches
>>> would be handled elsewhere.
>>
>> Yep, we got this. :)
> 
> So if it starts with dt-binding: prefix shall we ignore? Or is just
> for dt-bindings: leds? Or perhaps we can just ignore patches received
> as CC: rather than directly To: field.

What was exactly unclear in my response? The bindings for your subsystem
are for you. Bindings for other subsystems are not for you. dt-bindings:
leds: are for leds suubsystem. dt-bindings: mfd: are for mfd subsystem.
If the prefix is incorrect because people make mistakes, the paths point
to it - Documentation/devicetree/bindings/SUBSYSTEM_OR_HARDWARE_CLASS/....


Best regards,
Krzysztof

Lee Jones Jan. 27, 2023, 9:27 a.m. UTC | #9

On Thu, 26 Jan 2023, Luiz Augusto von Dentz wrote:

> Hi Lee,
> 
> On Thu, Jan 26, 2023 at 12:00 AM Lee Jones <[e-mail]> wrote:
> >
> > On Wed, 25 Jan 2023, Luiz Augusto von Dentz wrote:
> >
> > > Hi Lee,
> > >
> > > On Wed, Jan 25, 2023 at 7:16 AM Lee Jones <[e-mail]> wrote:
> > > >
> > > > On Tue, 24 Jan 2023, [e-mail] wrote:
> > > >
> > > > > Hello:
> > > > >
> > > > > This patch was applied to bluetooth/bluetooth-next.git (master)
> > > > > by Luiz Augusto von Dentz <[e-mail]>:
> > > > >
> > > > > On Sun, 22 Jan 2023 11:47:27 +0100 you wrote:
> > > > > > Add the missing trigger patterns for Bluetooth and WLAN activity, which
> > > > > > are already in active use.
> > > > > >
> > > > > > While at it, move the mmc pattern comment where it belongs, and restore
> > > > > > alphabetical sort order.
> > > > > >
> > > > > > Signed-off-by: Geert Uytterhoeven <[e-mail]>
> > > > > > Reviewed-by: Rob Herring <[e-mail]>
> > > > > >
> > > > > > [...]
> > > > >
> > > > > Here is the summary with links:
> > > > >   - [v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
> > > > >     https://git.kernel.org/bluetooth/bluetooth-next/c/ef017002b93b
> > > >
> > > > Why are you taking LED patches through the Bluetooth tree?
> > >
> > > I assume there isn't a tree dedicated to dt-bindings/leds
> >
> > % ./scripts/get_maintainer.pl -f Documentation/devicetree/bindings/leds/common.yaml
> >  Pavel Machek <[e-mail]> (maintainer:LED SUBSYSTEM,in file)
> >  Lee Jones <[e-mail]> (maintainer:LED SUBSYSTEM)
> >  Rob Herring <[e-mail]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> >  Krzysztof Kozlowski <[e-mail]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> >  Jacek Anaszewski <[e-mail]> (in file)
> >  [e-mail] (open list:LED SUBSYSTEM)
> >  [e-mail] (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> >  [e-mail] (open list)
> 
> Well this doesn't tell us what parts of the dt_bindings have a
> dedicated tree and which doesn't, anyway this doesn't show
> linux-bluetooth so I wonder why people are CCing it.

It is not possible to infer responsibilities from how contributors craft
their submissions.  The only reliable way to do that is to check the
MAINTAINERS file.

According to the MAINTAINERS excerpt below [0] if a commit only touches
files contained in; drivers/bluetooth/, include/net/bluetooth/ and/or
net/bluetooth/ AND there are no build-time dependencies or dependents,
they are yours to process how you see fit.  However, if commits ALSO touch
files outside of those directories OR do have dependencies or
dependents, you will need to consult with the other affected maintainers
to agree on a strategy for merging them.  If the aforementioned
directories are not touched (as in this case), you can safely ignore
them - regardless of which mailing list(s) or individual's inboxes they
end up in.

Does that help at all?

[0]

BLUETOOTH DRIVERS
M:      Marcel Holtmann <[e-mail]>
M:      Johan Hedberg <[e-mail]>
M:      Luiz Augusto von Dentz <[e-mail]>
L:      [e-mail]
S:      Supported
W:      http://www.bluez.org/
T:      git git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git
T:      git git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.g
F:      drivers/bluetooth/

BLUETOOTH SUBSYSTEM
M:      Marcel Holtmann <[e-mail]>
M:      Johan Hedberg <[e-mail]>
M:      Luiz Augusto von Dentz <[e-mail]>
L:      [e-mail]
S:      Supported
W:      http://www.bluez.org/
T:      git git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git
T:      git git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.g
F:      include/net/bluetooth/
F:      net/bluetooth/

Patch

diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index f5c57a580078ea23..d34bb58c00371402 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -98,9 +98,13 @@  properties:
             # LED alters the brightness for the specified duration with one software
             # timer (requires "led-pattern" property)
           - pattern
-        # LED is triggered by SD/MMC activity
-      - pattern: "^mmc[0-9]+$"
       - pattern: "^cpu[0-9]*$"
+      - pattern: "^hci[0-9]+-power$"
+        # LED is triggered by Bluetooth activity
+      - pattern: "^mmc[0-9]+$"
+        # LED is triggered by SD/MMC activity
+      - pattern: "^phy[0-9]+tx$"
+        # LED is triggered by WLAN activity
 
   led-pattern:
     description: |