| Message ID | 20230126103828.481441-1-henrik@grimler.se (mailing list archive) |
|---|---|
| Headers | show |
| Series | ARM: dts: add mmc aliases for Exynos devices | expand |
On 26/01/2023 11:38, Henrik Grimler wrote: > It is convenient to have fixed mmcblk numbering of the eMMC and > sdcard, and with these aliases all Exynos 4 and 5 devices (and > probably Exynos 3, but I do not have one of those boards so cannot > verify) will have the eMMC as mmc0 and sdcard as mmc2. > > I also removed sdhc aliases, as they should not be needed after [1] as > I understand it. > > [1] https://lkml.kernel.org/lkml/20211124184603.3897245-1-john@metanate.com/ Marek sent the same in the past: https://lore.kernel.org/all/?q=%22exynos%3A+Use+fixed+index+for+the+MMC+devices%22 The patches are fine for me except, that these actually do not belong to DTSI. Aliases for board or user-exposable interfaces are actually board specific and each board should customize the ones it uses. Best regards, Krzysztof
Hi Krzysztof, On Thu, Jan 26, 2023 at 01:22:54PM +0100, Krzysztof Kozlowski wrote: > On 26/01/2023 11:38, Henrik Grimler wrote: > > It is convenient to have fixed mmcblk numbering of the eMMC and > > sdcard, and with these aliases all Exynos 4 and 5 devices (and > > probably Exynos 3, but I do not have one of those boards so cannot > > verify) will have the eMMC as mmc0 and sdcard as mmc2. > > > > I also removed sdhc aliases, as they should not be needed after [1] as > > I understand it. > > > > [1] https://lkml.kernel.org/lkml/20211124184603.3897245-1-john@metanate.com/ > > Marek sent the same in the past: > https://lore.kernel.org/all/?q=%22exynos%3A+Use+fixed+index+for+the+MMC+devices%22 > > The patches are fine for me except, that these actually do not belong to > DTSI. Aliases for board or user-exposable interfaces are actually board > specific and each board should customize the ones it uses. Thanks for reviewing! I will change the series to only add aliases to the boards I am familiar with. > Best regards, > Krzysztof Best regards, Henrik Grimler
On 26/01/2023 14:19, Henrik Grimler wrote: > Hi Krzysztof, > > On Thu, Jan 26, 2023 at 01:22:54PM +0100, Krzysztof Kozlowski wrote: >> On 26/01/2023 11:38, Henrik Grimler wrote: >>> It is convenient to have fixed mmcblk numbering of the eMMC and >>> sdcard, and with these aliases all Exynos 4 and 5 devices (and >>> probably Exynos 3, but I do not have one of those boards so cannot >>> verify) will have the eMMC as mmc0 and sdcard as mmc2. >>> >>> I also removed sdhc aliases, as they should not be needed after [1] as >>> I understand it. >>> >>> [1] https://lkml.kernel.org/lkml/20211124184603.3897245-1-john@metanate.com/ >> >> Marek sent the same in the past: >> https://lore.kernel.org/all/?q=%22exynos%3A+Use+fixed+index+for+the+MMC+devices%22 >> >> The patches are fine for me except, that these actually do not belong to >> DTSI. Aliases for board or user-exposable interfaces are actually board >> specific and each board should customize the ones it uses. > > Thanks for reviewing! I will change the series to only add aliases to > the boards I am familiar with. I think you can move all of them to all of the boards. Add aliases for interfaces which are enabled in the board. Best regards, Krzysztof