| Message ID | 20230126085155.26395-1-jack@suse.cz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fs: gracefully handle ->get_block not mapping bh in __mpage_writepage | expand |
On Thu, Jan 26, 2023 at 09:51:55AM +0100, Jan Kara wrote: > When filesystem's ->get_block function does not map the buffer head when > called from __mpage_writepage(), the function will happily go and pass > bogus bdev and block number to bio allocation routines which leads to > crashes sooner or later. E.g. UDF can do this because it doesn't want to > allocate blocks from ->writepages callbacks. It allocates blocks on > write or page fault but writeback can still spot dirty buffers without > underlying blocks allocated e.g. if blocksize < pagesize, the tail page > is dirtied (which means all its buffers are dirtied), and truncate > extends the file so that some buffer starts to be within i_size. Yes, this matches what the buffer.c helpers do, so: Reviewed-by: Christoph Hellwig <hch@lst.de>
On Thu, 26 Jan 2023 09:51:55 +0100 Jan Kara <jack@suse.cz> wrote: > When filesystem's ->get_block function does not map the buffer head when > called from __mpage_writepage(), the function will happily go and pass "the function" being __mpage_writepage(), not ->get_block()... > bogus bdev and block number to bio allocation routines which leads to > crashes sooner or later. Crashes are unwelcome. How is this bug triggered? Should we backport the fix? I assume this is a longstanding thing and that any Fixes: target would be ancient? If ancient, why did it take so long to discover? > E.g. UDF can do this because it doesn't want to > allocate blocks from ->writepages callbacks. It allocates blocks on > write or page fault but writeback can still spot dirty buffers without > underlying blocks allocated e.g. if blocksize < pagesize, the tail page > is dirtied (which means all its buffers are dirtied), and truncate > extends the file so that some buffer starts to be within i_size. > > ...
On Thu 26-01-23 11:54:55, Andrew Morton wrote: > On Thu, 26 Jan 2023 09:51:55 +0100 Jan Kara <jack@suse.cz> wrote: > > > When filesystem's ->get_block function does not map the buffer head when > > called from __mpage_writepage(), the function will happily go and pass > > "the function" being __mpage_writepage(), not ->get_block()... Ah, right :) > > bogus bdev and block number to bio allocation routines which leads to > > crashes sooner or later. > > Crashes are unwelcome. How is this bug triggered? Should we backport > the fix? I assume this is a longstanding thing and that any Fixes: > target would be ancient? If ancient, why did it take so long to > discover? fsstress was able to trigger the problem for UDF. The problem is there likely since the time __mpage_writepage() was created (definitely pre-git). But usually filesystems using mpage_writepages() just allocate blocks in their ->get_block() method so the problem was not visible until I've changed UDF to not allocate blocks from page writeback (to fix some other bug). For that reason, I'm actually carrying this change in my tree so that I don't get swamped with 0-day and syzbot reports on that offending UDF fix. Honza
diff --git a/fs/mpage.c b/fs/mpage.c index 9f040c1d5912..8bd77a8e2627 100644 --- a/fs/mpage.c +++ b/fs/mpage.c @@ -538,6 +538,8 @@ static int __mpage_writepage(struct page *page, struct writeback_control *wbc, map_bh.b_size = 1 << blkbits; if (mpd->get_block(inode, block_in_file, &map_bh, 1)) goto confused; + if (!buffer_mapped(&map_bh)) + goto confused; if (buffer_new(&map_bh)) clean_bdev_bh_alias(&map_bh); if (buffer_boundary(&map_bh)) {
When filesystem's ->get_block function does not map the buffer head when called from __mpage_writepage(), the function will happily go and pass bogus bdev and block number to bio allocation routines which leads to crashes sooner or later. E.g. UDF can do this because it doesn't want to allocate blocks from ->writepages callbacks. It allocates blocks on write or page fault but writeback can still spot dirty buffers without underlying blocks allocated e.g. if blocksize < pagesize, the tail page is dirtied (which means all its buffers are dirtied), and truncate extends the file so that some buffer starts to be within i_size. Signed-off-by: Jan Kara <jack@suse.cz> --- fs/mpage.c | 2 ++ 1 file changed, 2 insertions(+) I'd like to get this patch merged through my tree as other UDF fixes depend on it and without this change the kernel crashes in unfortunate ways.