[RESEND] dt-bindings: ufs: qcom: allow 'dma-coherent' property

Commit Message

Johan Hovold Jan. 16, 2023, 4:42 p.m. UTC

UFS controllers may be cache coherent and must be marked as such in the
devicetree to avoid data corruption.

This is specifically needed on recent Qualcomm platforms like SC8280XP.

Reviewed-by: Rob Herring <[e-mail]>
Reviewed-by: Bjorn Andersson <[e-mail]>
Signed-off-by: Johan Hovold <[e-mail]>
---

James and Martin,

I'm resending as reminder in case you missed the first submission which
included an arm64 dts update and also did not have you on CC as I was
following scripts/get_maintainer.pl too literally:

	https://lore.kernel.org/all/[e-mail]/

I've added Rob and Bjorn's Reviewed-by tags from the above thread.

Could you take this one through the scsi tree?

Johan


 Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Martin K. Petersen Jan. 18, 2023, 11:48 p.m. UTC | #1

Johan,

> UFS controllers may be cache coherent and must be marked as such in the
> devicetree to avoid data corruption.

Applied to 6.3/scsi-staging, thanks!

Martin K. Petersen Jan. 27, 2023, 3:22 a.m. UTC | #2

On Mon, 16 Jan 2023 17:42:36 +0100, Johan Hovold wrote:

> UFS controllers may be cache coherent and must be marked as such in the
> devicetree to avoid data corruption.
> 
> This is specifically needed on recent Qualcomm platforms like SC8280XP.
> 
> 

Applied to 6.3/scsi-queue, thanks!

[1/1] dt-bindings: ufs: qcom: allow 'dma-coherent' property
      https://git.kernel.org/mkp/scsi/c/85e182b48a33

Patch

diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
index f2d6298d926c..1f1d286749c0 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
@@ -44,6 +44,8 @@  properties:
     minItems: 8
     maxItems: 11
 
+  dma-coherent: true
+
   interconnects:
     minItems: 2
     maxItems: 2