| Message ID | 20230127093950.2368575-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | platform/x86/amd: pmc: add CONFIG_SERIO dependency | expand |
Hi, On 1/27/23 10:39, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Using the serio subsystem now requires the code to be reachable: > > x86_64-linux-ld: drivers/platform/x86/amd/pmc.o: in function `amd_pmc_suspend_handler': > pmc.c:(.text+0x86c): undefined reference to `serio_bus' > > Add the usual dependency: as other users of serio use 'select' > rather than 'depends on', use the same here. > > Fixes: 8e60615e8932 ("platform/x86/amd: pmc: Disable IRQ1 wakeup for RN/CZN") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thanks Arnd, I'll include this in my next fixes pull-req to Linus. Regards, Hans > --- > drivers/platform/x86/amd/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/amd/Kconfig b/drivers/platform/x86/amd/Kconfig > index a825af8126c8..2ce8cb2170df 100644 > --- a/drivers/platform/x86/amd/Kconfig > +++ b/drivers/platform/x86/amd/Kconfig > @@ -8,6 +8,7 @@ source "drivers/platform/x86/amd/pmf/Kconfig" > config AMD_PMC > tristate "AMD SoC PMC driver" > depends on ACPI && PCI && RTC_CLASS > + select SERIO > help > The driver provides support for AMD Power Management Controller > primarily responsible for S2Idle transactions that are driven from
Hi, On 1/27/23 10:39, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Using the serio subsystem now requires the code to be reachable: > > x86_64-linux-ld: drivers/platform/x86/amd/pmc.o: in function `amd_pmc_suspend_handler': > pmc.c:(.text+0x86c): undefined reference to `serio_bus' > > Add the usual dependency: as other users of serio use 'select' > rather than 'depends on', use the same here. > > Fixes: 8e60615e8932 ("platform/x86/amd: pmc: Disable IRQ1 wakeup for RN/CZN") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/amd/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/amd/Kconfig b/drivers/platform/x86/amd/Kconfig > index a825af8126c8..2ce8cb2170df 100644 > --- a/drivers/platform/x86/amd/Kconfig > +++ b/drivers/platform/x86/amd/Kconfig > @@ -8,6 +8,7 @@ source "drivers/platform/x86/amd/pmf/Kconfig" > config AMD_PMC > tristate "AMD SoC PMC driver" > depends on ACPI && PCI && RTC_CLASS > + select SERIO > help > The driver provides support for AMD Power Management Controller > primarily responsible for S2Idle transactions that are driven from
diff --git a/drivers/platform/x86/amd/Kconfig b/drivers/platform/x86/amd/Kconfig index a825af8126c8..2ce8cb2170df 100644 --- a/drivers/platform/x86/amd/Kconfig +++ b/drivers/platform/x86/amd/Kconfig @@ -8,6 +8,7 @@ source "drivers/platform/x86/amd/pmf/Kconfig" config AMD_PMC tristate "AMD SoC PMC driver" depends on ACPI && PCI && RTC_CLASS + select SERIO help The driver provides support for AMD Power Management Controller primarily responsible for S2Idle transactions that are driven from