| Message ID | 20230126165548.230453-1-andrei.gherzan@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a6efc42a86c0c87cfe2f1c3d1f09a4c9b13ba890 |
| Headers | show |
| Series | selftest: net: Improve IPV6_TCLASS/IPV6_HOPLIMIT tests apparmor compatibility | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Thu, 26 Jan 2023 16:55:48 +0000 you wrote: > "tcpdump" is used to capture traffic in these tests while using a random, > temporary and not suffixed file for it. This can interfere with apparmor > configuration where the tool is only allowed to read from files with > 'known' extensions. > > The MINE type application/vnd.tcpdump.pcap was registered with IANA for > pcap files and .pcap is the extension that is both most common but also > aligned with standard apparmor configurations. See TCPDUMP(8) for more > details. > > [...] Here is the summary with links: - selftest: net: Improve IPV6_TCLASS/IPV6_HOPLIMIT tests apparmor compatibility https://git.kernel.org/netdev/net/c/a6efc42a86c0 You are awesome, thank you!
diff --git a/tools/testing/selftests/net/cmsg_ipv6.sh b/tools/testing/selftests/net/cmsg_ipv6.sh index 2d89cb0ad288..330d0b1ceced 100755 --- a/tools/testing/selftests/net/cmsg_ipv6.sh +++ b/tools/testing/selftests/net/cmsg_ipv6.sh @@ -6,7 +6,7 @@ ksft_skip=4 NS=ns IP6=2001:db8:1::1/64 TGT6=2001:db8:1::2 -TMPF=`mktemp` +TMPF=$(mktemp --suffix ".pcap") cleanup() {
"tcpdump" is used to capture traffic in these tests while using a random, temporary and not suffixed file for it. This can interfere with apparmor configuration where the tool is only allowed to read from files with 'known' extensions. The MINE type application/vnd.tcpdump.pcap was registered with IANA for pcap files and .pcap is the extension that is both most common but also aligned with standard apparmor configurations. See TCPDUMP(8) for more details. This improves compatibility with standard apparmor configurations by using ".pcap" as the file extension for the tests' temporary files. Signed-off-by: Andrei Gherzan <andrei.gherzan@canonical.com> --- tools/testing/selftests/net/cmsg_ipv6.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)