| Message ID | 20230118091829.755-9-allen-kh.cheng@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add and update some driver nodes for MT8186 SoC | expand |
On 18/01/2023 10:18, Allen-KH Cheng wrote: > The mt8186-disp-ccorr is not fully compatible with the mt8183-disp-ccorr > implementation. It causes a crash when system resumes if it binds to the > device. > > We should use mt8192-disp-ccorr as fallback of mt8186-disp-ccorr. > > Fixes: 8a26ea19d4dc ("dt-bindings: display: mediatek: add MT8186 SoC binding") > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > Reviewed-by: Rob Herring <robh@kernel.org> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > .../devicetree/bindings/display/mediatek/mediatek,ccorr.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml > index 63fb02014a56..117e3db43f84 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml > @@ -32,7 +32,7 @@ properties: > - items: > - enum: > - mediatek,mt8186-disp-ccorr > - - const: mediatek,mt8183-disp-ccorr > + - const: mediatek,mt8192-disp-ccorr > > reg: > maxItems: 1
Hi, Allen: Allen-KH Cheng <allen-kh.cheng@mediatek.com> 於 2023年1月18日 週三 下午5:18寫道： > > The mt8186-disp-ccorr is not fully compatible with the mt8183-disp-ccorr > implementation. It causes a crash when system resumes if it binds to the > device. > > We should use mt8192-disp-ccorr as fallback of mt8186-disp-ccorr. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Fixes: 8a26ea19d4dc ("dt-bindings: display: mediatek: add MT8186 SoC binding") > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/display/mediatek/mediatek,ccorr.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml > index 63fb02014a56..117e3db43f84 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml > @@ -32,7 +32,7 @@ properties: > - items: > - enum: > - mediatek,mt8186-disp-ccorr > - - const: mediatek,mt8183-disp-ccorr > + - const: mediatek,mt8192-disp-ccorr > > reg: > maxItems: 1 > -- > 2.18.0 >
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml index 63fb02014a56..117e3db43f84 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml @@ -32,7 +32,7 @@ properties: - items: - enum: - mediatek,mt8186-disp-ccorr - - const: mediatek,mt8183-disp-ccorr + - const: mediatek,mt8192-disp-ccorr reg: maxItems: 1
The mt8186-disp-ccorr is not fully compatible with the mt8183-disp-ccorr implementation. It causes a crash when system resumes if it binds to the device. We should use mt8192-disp-ccorr as fallback of mt8186-disp-ccorr. Fixes: 8a26ea19d4dc ("dt-bindings: display: mediatek: add MT8186 SoC binding") Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> Reviewed-by: Rob Herring <robh@kernel.org> --- .../devicetree/bindings/display/mediatek/mediatek,ccorr.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)