| Message ID | ed819dc612fcadbd04b4b44b2c0560a77796793a.1674818705.git.oleksii.kurochko@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | RISCV basic exception handling implementation | expand |
Hi Oleksii, On 27/01/2023 14:59, Oleksii Kurochko wrote: > > > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> > --- > Changes in V2: > - Leave only the latest "grep ..." > --- > automation/scripts/qemu-smoke-riscv64.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/automation/scripts/qemu-smoke-riscv64.sh b/automation/scripts/qemu-smoke-riscv64.sh > index e0f06360bc..02fc66be03 100755 > --- a/automation/scripts/qemu-smoke-riscv64.sh > +++ b/automation/scripts/qemu-smoke-riscv64.sh > @@ -16,5 +16,5 @@ qemu-system-riscv64 \ > |& tee smoke.serial > > set -e > -(grep -q "Hello from C env" smoke.serial) || exit 1 > +(grep -q "WARN is most likely working" smoke.serial) || exit 1 I think the commit msg is a bit misleading and should be changed. FWICS, you are not *adding* any smoke test but instead modifying the grep pattern to reflect the usage of WARN. > exit 0 > -- > 2.39.0 > > ~Michal
On Fri, 2023-01-27 at 15:43 +0100, Michal Orzel wrote: > Hi Oleksii, > > On 27/01/2023 14:59, Oleksii Kurochko wrote: > > > > > > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> > > --- > > Changes in V2: > > - Leave only the latest "grep ..." > > --- > > automation/scripts/qemu-smoke-riscv64.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/automation/scripts/qemu-smoke-riscv64.sh > > b/automation/scripts/qemu-smoke-riscv64.sh > > index e0f06360bc..02fc66be03 100755 > > --- a/automation/scripts/qemu-smoke-riscv64.sh > > +++ b/automation/scripts/qemu-smoke-riscv64.sh > > @@ -16,5 +16,5 @@ qemu-system-riscv64 \ > > |& tee smoke.serial > > > > set -e > > -(grep -q "Hello from C env" smoke.serial) || exit 1 > > +(grep -q "WARN is most likely working" smoke.serial) || exit 1 > I think the commit msg is a bit misleading and should be changed. > FWICS, you are not *adding* any smoke test but instead modifying > the grep pattern to reflect the usage of WARN. > It's incorrect so it will be changed in the new version of the patch series. Thanks. > > exit 0 > > -- > > 2.39.0 > > > > > > ~Michal
diff --git a/automation/scripts/qemu-smoke-riscv64.sh b/automation/scripts/qemu-smoke-riscv64.sh index e0f06360bc..02fc66be03 100755 --- a/automation/scripts/qemu-smoke-riscv64.sh +++ b/automation/scripts/qemu-smoke-riscv64.sh @@ -16,5 +16,5 @@ qemu-system-riscv64 \ |& tee smoke.serial set -e -(grep -q "Hello from C env" smoke.serial) || exit 1 +(grep -q "WARN is most likely working" smoke.serial) || exit 1 exit 0
Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> --- Changes in V2: - Leave only the latest "grep ..." --- automation/scripts/qemu-smoke-riscv64.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)