| Message ID | 20230131130412.432549-2-andrei.gherzan@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | db9b47ee9f5f375ab0c5daeb20321c75b4fa657d |
| Headers | show |
| Series | [v2,1/4] selftests: net: udpgso_bench_rx: Fix 'used uninitialized' compiler warning | expand |
On Tue, Jan 31, 2023 at 8:08 AM Andrei Gherzan <andrei.gherzan@canonical.com> wrote: > > Leaving unrecognized arguments buried in the output, can easily hide a > CLI/script typo. Avoid this by exiting when wrong arguments are provided to > the udpgso_bench test programs. > > Signed-off-by: Andrei Gherzan <andrei.gherzan@canonical.com> I'm on the fence on this. Test binaries are not necessarily robust against bad input. If you insist. When sending patches to net, please always add a Fixes tag.
On 23/01/31 08:35AM, Willem de Bruijn wrote: > On Tue, Jan 31, 2023 at 8:08 AM Andrei Gherzan > <andrei.gherzan@canonical.com> wrote: > > > > Leaving unrecognized arguments buried in the output, can easily hide a > > CLI/script typo. Avoid this by exiting when wrong arguments are provided to > > the udpgso_bench test programs. > > > > Signed-off-by: Andrei Gherzan <andrei.gherzan@canonical.com> > > I'm on the fence on this. Test binaries are not necessarily robust > against bad input. If you insist. I'll keep it in the set (for next v), but I don't mind if it doesn't end up applied. It was just something I stumbled into. > When sending patches to net, please always add a Fixes tag. I'll keep that in mind.
diff --git a/tools/testing/selftests/net/udpgso_bench_rx.c b/tools/testing/selftests/net/udpgso_bench_rx.c index d0895bd1933f..4058c7451e70 100644 --- a/tools/testing/selftests/net/udpgso_bench_rx.c +++ b/tools/testing/selftests/net/udpgso_bench_rx.c @@ -336,6 +336,8 @@ static void parse_opts(int argc, char **argv) cfg_verify = true; cfg_read_all = true; break; + default: + exit(1); } } diff --git a/tools/testing/selftests/net/udpgso_bench_tx.c b/tools/testing/selftests/net/udpgso_bench_tx.c index f1fdaa270291..b47b5c32039f 100644 --- a/tools/testing/selftests/net/udpgso_bench_tx.c +++ b/tools/testing/selftests/net/udpgso_bench_tx.c @@ -490,6 +490,8 @@ static void parse_opts(int argc, char **argv) case 'z': cfg_zerocopy = true; break; + default: + exit(1); } }
Leaving unrecognized arguments buried in the output, can easily hide a CLI/script typo. Avoid this by exiting when wrong arguments are provided to the udpgso_bench test programs. Signed-off-by: Andrei Gherzan <andrei.gherzan@canonical.com> --- tools/testing/selftests/net/udpgso_bench_rx.c | 2 ++ tools/testing/selftests/net/udpgso_bench_tx.c | 2 ++ 2 files changed, 4 insertions(+)