mbox series

[V4,0/2] PCI: Resolve Loongson's LS7A PCI problems

Message ID 20230201043018.778499-1-chenhuacai@loongson.cn (mailing list archive)
Headers show
Series PCI: Resolve Loongson's LS7A PCI problems | expand

Message

Huacai Chen Feb. 1, 2023, 4:30 a.m. UTC 
This patchset attempt to resolves Loongson's LS7A PCI problems: the
first patch remove pci_disable_device() in pcie_portdrv_remove() to
avoid poweroff/reboot failure; the second patch improves the mrrs quirk
for LS7A chipset; 

V1 -> V2:
1, Update commit messages and comments.

V2 -> V3:
1, Simply remove pci_disable_device() in pcie_port_device_remove() to
   solve poweroff/reboot failure.
2, Update commit messages and comments.

V3 -> V4:
1, Just remove pci_disable_device() in pcie_portdrv_shutdown() and keep
   pcie_portdrv_remove() be the same logic as before.

Huacai Chen, Tiezhu Yang and Jianmin Lv(2):
 PCI: Omit pci_disable_device() in .shutdown().
 PCI: loongson: Improve the MRRS quirk for LS7A.

Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
Signed-off-by: Jianmin Lv <lvjianmin@loongson.cn> 
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 drivers/pci/controller/pci-loongson.c | 44 ++++++++++++-----------------------
 drivers/pci/pci.c                     |  6 +++++
 drivers/pci/pcie/portdrv.c            | 16 +++++++++++--
 include/linux/pci.h                   |  1 +
 4 files changed, 36 insertions(+), 31 deletions(-)
--
2.27.0

Comments

Bjorn Helgaas Feb. 1, 2023, 6:57 p.m. UTC | #1 
On Wed, Feb 01, 2023 at 12:30:16PM +0800, Huacai Chen wrote:
> This patchset attempt to resolves Loongson's LS7A PCI problems: the
> first patch remove pci_disable_device() in pcie_portdrv_remove() to
> avoid poweroff/reboot failure; the second patch improves the mrrs quirk
> for LS7A chipset; 
> 
> V1 -> V2:
> 1, Update commit messages and comments.
> 
> V2 -> V3:
> 1, Simply remove pci_disable_device() in pcie_port_device_remove() to
>    solve poweroff/reboot failure.
> 2, Update commit messages and comments.
> 
> V3 -> V4:
> 1, Just remove pci_disable_device() in pcie_portdrv_shutdown() and keep
>    pcie_portdrv_remove() be the same logic as before.
> 
> Huacai Chen, Tiezhu Yang and Jianmin Lv(2):
>  PCI: Omit pci_disable_device() in .shutdown().
>  PCI: loongson: Improve the MRRS quirk for LS7A.
> 
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> Signed-off-by: Jianmin Lv <lvjianmin@loongson.cn> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>

I applied both to pci/enumeration for v6.3, thanks!

I added a diagnostic message in pcie_set_readq() and reworked the
commit logs, so take a look and make sure I didn't mess it up:

https://git.kernel.org/cgit/linux/kernel/git/pci/pci.git/log/?h=pci/enumeration&id=8b3517f88ff2
Huacai Chen Feb. 2, 2023, 1:28 p.m. UTC | #2 
On Thu, Feb 2, 2023 at 2:58 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> On Wed, Feb 01, 2023 at 12:30:16PM +0800, Huacai Chen wrote:
> > This patchset attempt to resolves Loongson's LS7A PCI problems: the
> > first patch remove pci_disable_device() in pcie_portdrv_remove() to
> > avoid poweroff/reboot failure; the second patch improves the mrrs quirk
> > for LS7A chipset;
> >
> > V1 -> V2:
> > 1, Update commit messages and comments.
> >
> > V2 -> V3:
> > 1, Simply remove pci_disable_device() in pcie_port_device_remove() to
> >    solve poweroff/reboot failure.
> > 2, Update commit messages and comments.
> >
> > V3 -> V4:
> > 1, Just remove pci_disable_device() in pcie_portdrv_shutdown() and keep
> >    pcie_portdrv_remove() be the same logic as before.
> >
> > Huacai Chen, Tiezhu Yang and Jianmin Lv(2):
> >  PCI: Omit pci_disable_device() in .shutdown().
> >  PCI: loongson: Improve the MRRS quirk for LS7A.
> >
> > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> > Signed-off-by: Jianmin Lv <lvjianmin@loongson.cn>
> > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>
> I applied both to pci/enumeration for v6.3, thanks!
>
> I added a diagnostic message in pcie_set_readq() and reworked the
> commit logs, so take a look and make sure I didn't mess it up:
>
> https://git.kernel.org/cgit/linux/kernel/git/pci/pci.git/log/?h=pci/enumeration&id=8b3517f88ff2
OK, thanks.

Huacai