| Message ID | pull.1445.v4.git.git.1675290034144.gitgitgadget@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 592bcab61b86dbbac6fd2366039b4837b306ed66 |
| Headers | show |
| Series | [v4] compat/winansi: check for errors of CreateThread() correctly | expand |
"Rose via GitGitGadget" <gitgitgadget@gmail.com> writes: > From: Seija Kijin <doremylover123@gmail.com> > > The return value for failed thread creation is NULL, > not INVALID_HANDLE_VALUE, unlike other Windows API functions. > > Signed-off-by: Seija Kijin <doremylover123@gmail.com> > --- Thanks. Will queue with the Ack by j6t given earlier.
Am 01.02.23 um 23:20 schrieb Rose via GitGitGadget: > From: Seija Kijin <doremylover123@gmail.com> > > The return value for failed thread creation is NULL, > not INVALID_HANDLE_VALUE, unlike other Windows API functions. > > Signed-off-by: Seija Kijin <doremylover123@gmail.com> > --- > win32: check for NULL after creating thread > > Check for NULL handles, not "INVALID_HANDLE," as CreateThread guarantees > a valid handle in most cases. > > The return value for failed thread creation is NULL, not > INVALID_HANDLE_VALUE, unlike other Windows API functions. > > Signed-off-by: Seija Kijin doremylover123@gmail.com > > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1445%2FAtariDreams%2FhThread-v4 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1445/AtariDreams/hThread-v4 > Pull-Request: https://github.com/git/git/pull/1445 > > Range-diff vs v3: > > 1: 1cbc43e0d82 ! 1: 6c4188977e8 win32: check for NULL after creating thread > @@ Metadata > Author: Seija Kijin <doremylover123@gmail.com> > > ## Commit message ## > - win32: check for NULL after creating thread > - > - Check for NULL handles, not "INVALID_HANDLE," > - as CreateThread guarantees a valid handle in most cases. > + compat/winansi: check for errors of CreateThread() correctly > > The return value for failed thread creation is NULL, > not INVALID_HANDLE_VALUE, unlike other Windows API functions. > > > compat/winansi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/compat/winansi.c b/compat/winansi.c > index 3abe8dd5a27..f83610f684d 100644 > --- a/compat/winansi.c > +++ b/compat/winansi.c > @@ -644,7 +644,7 @@ void winansi_init(void) > > /* start console spool thread on the pipe's read end */ > hthread = CreateThread(NULL, 0, console_thread, NULL, 0, NULL); > - if (hthread == INVALID_HANDLE_VALUE) > + if (!hthread) > die_lasterr("CreateThread(console_thread) failed"); > > /* schedule cleanup routine */ > > base-commit: 2fc9e9ca3c7505bc60069f11e7ef09b1aeeee473 This iteration looks good, thank you! Acked-by: Johannes Sixt <j6t@kdbg.org> -- Hannes
diff --git a/compat/winansi.c b/compat/winansi.c index 3abe8dd5a27..f83610f684d 100644 --- a/compat/winansi.c +++ b/compat/winansi.c @@ -644,7 +644,7 @@ void winansi_init(void) /* start console spool thread on the pipe's read end */ hthread = CreateThread(NULL, 0, console_thread, NULL, 0, NULL); - if (hthread == INVALID_HANDLE_VALUE) + if (!hthread) die_lasterr("CreateThread(console_thread) failed"); /* schedule cleanup routine */