| Message ID | 20230202141520.40003-1-avromanov@sberdevices.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1,1/2] arm64: dts: meson-a1: add gpio_intc node | expand |
Sorry, this patch has the wrong subject (I am tolking about1/2), there is no second patch. On Thu, Feb 02, 2023 at 05:15:20PM +0300, Alexey Romanov wrote: > Add gpio interrupt controller node. > > Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru> > --- > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > index 6268c323a810..a04ddf0f4cd3 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > @@ -158,6 +158,16 @@ clkc_pll: pll-clock-controller@7c80 { > <&clkc_periphs CLKID_XTAL_HIFIPLL>; > clock-names = "xtal_fixpll", "xtal_hifipll"; > }; > + > + gpio_intc: interrupt-controller@0440 { > + compatible = "amlogic,meson-a1-gpio-intc", > + "amlogic,meson-gpio-intc"; > + reg = <0x0 0x0440 0x0 0x14>; > + interrupt-controller; > + #interrupt-cells = <2>; > + amlogic,channel-interrupts = > + <49 50 51 52 53 54 55 56>; > + }; > }; > > gic: interrupt-controller@ff901000 { > -- > 2.38.1 >
Hi Alexey, On Thu, Feb 2, 2023 at 3:15 PM Alexey Romanov <avromanov@sberdevices.ru> wrote: > > Add gpio interrupt controller node. > > Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru> I have no way to verify the register offset or interrupt numbers. Overall it looks good though, so: Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Best regards, Martin
Hello Martin, On Sun, Feb 05, 2023 at 12:05:46AM +0100, Martin Blumenstingl wrote: > Hi Alexey, > > On Thu, Feb 2, 2023 at 3:15 PM Alexey Romanov <avromanov@sberdevices.ru> wrote: > > > > Add gpio interrupt controller node. > > > > Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru> > I have no way to verify the register offset or interrupt numbers. > Overall it looks good though, so: > Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> We've verified interrupt numbers and register offsets on the our device board based on A1 (A113L) + A113L datasheet.
Le 02/02/2023 à 15:15, Alexey Romanov a écrit : > Add gpio interrupt controller node. > > Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru> > --- > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > index 6268c323a810..a04ddf0f4cd3 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > @@ -158,6 +158,16 @@ clkc_pll: pll-clock-controller@7c80 { > <&clkc_periphs CLKID_XTAL_HIFIPLL>; > clock-names = "xtal_fixpll", "xtal_hifipll"; > }; > + > + gpio_intc: interrupt-controller@0440 { > + compatible = "amlogic,meson-a1-gpio-intc", > + "amlogic,meson-gpio-intc"; > + reg = <0x0 0x0440 0x0 0x14>; > + interrupt-controller; > + #interrupt-cells = <2>; > + amlogic,channel-interrupts = > + <49 50 51 52 53 54 55 56>; > + }; > }; > > gic: interrupt-controller@ff901000 { Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> I'll take it once v6.3-rc1 is tagged. Thanks, Neil
Hello, Neil! On Wed, Feb 08, 2023 at 01:34:04PM +0100, Neil Armstrong wrote: > Le 02/02/2023 à 15:15, Alexey Romanov a écrit : > > Add gpio interrupt controller node. > > > > Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru> > > --- > > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > > index 6268c323a810..a04ddf0f4cd3 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > > @@ -158,6 +158,16 @@ clkc_pll: pll-clock-controller@7c80 { > > <&clkc_periphs CLKID_XTAL_HIFIPLL>; > > clock-names = "xtal_fixpll", "xtal_hifipll"; > > }; > > + > > + gpio_intc: interrupt-controller@0440 { > > + compatible = "amlogic,meson-a1-gpio-intc", > > + "amlogic,meson-gpio-intc"; > > + reg = <0x0 0x0440 0x0 0x14>; > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + amlogic,channel-interrupts = > > + <49 50 51 52 53 54 55 56>; > > + }; > > }; > > gic: interrupt-controller@ff901000 { > > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> > > > I'll take it once v6.3-rc1 is tagged. > > > Thanks, > > Neil v6.3 is tagged, but we didn't find my patch in Amlogic branch. Did you happen to forget about him?
On 02/02/2023 15:15, Alexey Romanov wrote: > Add gpio interrupt controller node. > > Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru> > --- > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > index 6268c323a810..a04ddf0f4cd3 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > @@ -158,6 +158,16 @@ clkc_pll: pll-clock-controller@7c80 { > <&clkc_periphs CLKID_XTAL_HIFIPLL>; > clock-names = "xtal_fixpll", "xtal_hifipll"; > }; > + > + gpio_intc: interrupt-controller@0440 { > + compatible = "amlogic,meson-a1-gpio-intc", > + "amlogic,meson-gpio-intc"; > + reg = <0x0 0x0440 0x0 0x14>; > + interrupt-controller; > + #interrupt-cells = <2>; > + amlogic,channel-interrupts = > + <49 50 51 52 53 54 55 56>; > + }; > }; > > gic: interrupt-controller@ff901000 { The [PATCH 1/2] highly confused b4, anyway it's applied on v6.4/arm64-dt. Thanks, Neil
> The [PATCH 1/2] highly confused b4, anyway it's applied on v6.4/arm64-dt. > > Thanks, > Neil Oh, sorry for the noise. Thank you, Neil!
diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi index 6268c323a810..a04ddf0f4cd3 100644 --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi @@ -158,6 +158,16 @@ clkc_pll: pll-clock-controller@7c80 { <&clkc_periphs CLKID_XTAL_HIFIPLL>; clock-names = "xtal_fixpll", "xtal_hifipll"; }; + + gpio_intc: interrupt-controller@0440 { + compatible = "amlogic,meson-a1-gpio-intc", + "amlogic,meson-gpio-intc"; + reg = <0x0 0x0440 0x0 0x14>; + interrupt-controller; + #interrupt-cells = <2>; + amlogic,channel-interrupts = + <49 50 51 52 53 54 55 56>; + }; }; gic: interrupt-controller@ff901000 {
Add gpio interrupt controller node. Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru> --- arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)