| Message ID | 20230203125012.3804008-19-s.hauer@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add perf support to the rockchip-dfi driver | expand |
On 03/02/2023 13:50, Sascha Hauer wrote: > Convert the Rockchip DFI binding to yaml. While at it add the newly > supported rk3568-dfi to the binding. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. > --- > .../bindings/devfreq/event/rockchip-dfi.txt | 18 --------- > .../bindings/devfreq/event/rockchip-dfi.yaml | 38 +++++++++++++++++++ > 2 files changed, 38 insertions(+), 18 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml > > diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > deleted file mode 100644 > index 148191b0fc158..0000000000000 > --- a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > +++ /dev/null > @@ -1,18 +0,0 @@ > - > -* Rockchip rk3399 DFI device > - > -Required properties: > -- compatible: Must be "rockchip,rk3399-dfi". > -- reg: physical base address of each DFI and length of memory mapped region > -- rockchip,pmu: phandle to the syscon managing the "pmu general register files" > -- clocks: phandles for clock specified in "clock-names" property > -- clock-names : the name of clock used by the DFI, must be "pclk_ddr_mon"; > - > -Example: > - dfi: dfi@ff630000 { > - compatible = "rockchip,rk3399-dfi"; > - reg = <0x00 0xff630000 0x00 0x4000>; > - rockchip,pmu = <&pmugrf>; > - clocks = <&cru PCLK_DDR_MON>; > - clock-names = "pclk_ddr_mon"; > - }; > diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml > new file mode 100644 > index 0000000000000..e082a0df7895a > --- /dev/null > +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml rockchip,dfi.yaml > @@ -0,0 +1,38 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/devfreq/event/rockchip-dfi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip DFI > + > +maintainers: > + - Sascha Hauer <s.hauer@pengutronix.de> > + > +properties: > + compatible: > + enum: > + - rk3399-dfi > + - rk3568-dfi These are not correct compatibles. > + > + clocks: > + maxItems: 1 > + > + rockchip,pmu: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the syscon managing the "PMU general register files". > + > +required: > + - compatible > + - reg clocks were required > + > +additionalProperties: false Best regards, Krzysztof
On 03/02/2023 16:14, Krzysztof Kozlowski wrote: > On 03/02/2023 13:50, Sascha Hauer wrote: >> Convert the Rockchip DFI binding to yaml. While at it add the newly >> supported rk3568-dfi to the binding. >> >> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. BTW, for sure you already got this feedback because many patchsets from you and from other @pengutronix were sent not using get_maintainers.pl correctly. Best regards, Krzysztof
On Fri, Feb 03, 2023 at 04:14:56PM +0100, Krzysztof Kozlowski wrote: > On 03/02/2023 13:50, Sascha Hauer wrote: > > Convert the Rockchip DFI binding to yaml. While at it add the newly > > supported rk3568-dfi to the binding. > > > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. That's what I did. I skipped you and Rob because I know you're wathcing the list anyway. > > diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml > > new file mode 100644 > > index 0000000000000..e082a0df7895a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml > > rockchip,dfi.yaml ok. > > > @@ -0,0 +1,38 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/devfreq/event/rockchip-dfi.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Rockchip DFI > > + > > +maintainers: > > + - Sascha Hauer <s.hauer@pengutronix.de> > > + > > +properties: > > + compatible: > > + enum: > > + - rk3399-dfi > > + - rk3568-dfi > > These are not correct compatibles. What's wrong with them? > > > + > > + clocks: > > + maxItems: 1 > > + > > + rockchip,pmu: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + Phandle to the syscon managing the "PMU general register files". > > + > > +required: > > + - compatible > > + - reg > > clocks were required They are no longer, the RK3568 doesn't have a clock. Do I have to add something to make the clock optional on RK3568 only? Sascha
On 03/02/2023 17:02, Sascha Hauer wrote: > On Fri, Feb 03, 2023 at 04:14:56PM +0100, Krzysztof Kozlowski wrote: >> On 03/02/2023 13:50, Sascha Hauer wrote: >>> Convert the Rockchip DFI binding to yaml. While at it add the newly >>> supported rk3568-dfi to the binding. >>> >>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> >> >> Please use scripts/get_maintainers.pl to get a list of necessary people >> and lists to CC. It might happen, that command when run on an older >> kernel, gives you outdated entries. Therefore please be sure you base >> your patches on recent Linux kernel. > > That's what I did. I skipped you and Rob because I know you're wathcing > the list anyway. Rob is apparently ok with that but I prefer not to be skipped, because: 1. such emails end up in entirely different mailbox, 2. I never know whether the submitter skipped other maintainers/mailing lists or based the patches on some old tree. Both are happening. There is easy way to solve it - just pipe entire patchset via get_maintainers (--no-git) and do not de/select manually people, unless CC list grows too much. > >>> diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml >>> new file mode 100644 >>> index 0000000000000..e082a0df7895a >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml >> >> rockchip,dfi.yaml > > ok. > >> >>> @@ -0,0 +1,38 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/devfreq/event/rockchip-dfi.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Rockchip DFI >>> + >>> +maintainers: >>> + - Sascha Hauer <s.hauer@pengutronix.de> >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - rk3399-dfi >>> + - rk3568-dfi >> >> These are not correct compatibles. > > What's wrong with them? They are different than old ones, because they miss vendor prefix. > >> >>> + >>> + clocks: >>> + maxItems: 1 >>> + >>> + rockchip,pmu: >>> + $ref: /schemas/types.yaml#/definitions/phandle >>> + description: >>> + Phandle to the syscon managing the "PMU general register files". >>> + >>> +required: >>> + - compatible >>> + - reg >> >> clocks were required > > They are no longer, the RK3568 doesn't have a clock. Do I have to add > something to make the clock optional on RK3568 only? Then it's a change during conversion and not necessarily justified. The conversion should not add new compatibles. Some changes are okay if they are needed for conversion, but adding new stuff is better to keep in separate patch. You need allOf:if:then: requiring the clocks for older variant. Best regards, Krzysztof
On Fri, 03 Feb 2023 13:50:12 +0100, Sascha Hauer wrote: > Convert the Rockchip DFI binding to yaml. While at it add the newly > supported rk3568-dfi to the binding. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > --- > .../bindings/devfreq/event/rockchip-dfi.txt | 18 --------- > .../bindings/devfreq/event/rockchip-dfi.yaml | 38 +++++++++++++++++++ > 2 files changed, 38 insertions(+), 18 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.example.dtb: /example-0/dfi@fe230000: failed to match any schema with compatible: ['rockchip,rk3568-dfi'] doc reference errors (make refcheckdocs): Documentation/devicetree/bindings/memory-controllers/rockchip,rk3399-dmc.yaml: Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230203125012.3804008-19-s.hauer@pengutronix.de The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Hi Sascha,
I love your patch! Perhaps something to improve:
[auto build test WARNING on rockchip/for-next]
[also build test WARNING on arm/for-next arm/fixes arm64/for-next/core clk/clk-next kvmarm/next shawnguo/for-next soc/for-next xilinx-xlnx/master linus/master v6.2-rc6 next-20230203]
[cannot apply to chanwoo/devfreq-testing]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sascha-Hauer/PM-devfreq-rockchip-dfi-Embed-desc-into-private-data-struct/20230203-205252
base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next
patch link: https://lore.kernel.org/r/20230203125012.3804008-19-s.hauer%40pengutronix.de
patch subject: [PATCH 18/18] dt-bindings: devfreq: event: convert Rockchip DFI binding to yaml
reproduce:
# https://github.com/intel-lab-lkp/linux/commit/b6385ff60bdb4b1b2895d87a7f294fde81f10ee9
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Sascha-Hauer/PM-devfreq-rockchip-dfi-Embed-desc-into-private-data-struct/20230203-205252
git checkout b6385ff60bdb4b1b2895d87a7f294fde81f10ee9
make menuconfig
# enable CONFIG_COMPILE_TEST, CONFIG_WARN_MISSING_DOCUMENTS, CONFIG_WARN_ABI_ERRORS
make htmldocs
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> Warning: Documentation/devicetree/bindings/memory-controllers/rockchip,rk3399-dmc.yaml references a file that doesn't exist: Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt deleted file mode 100644 index 148191b0fc158..0000000000000 --- a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt +++ /dev/null @@ -1,18 +0,0 @@ - -* Rockchip rk3399 DFI device - -Required properties: -- compatible: Must be "rockchip,rk3399-dfi". -- reg: physical base address of each DFI and length of memory mapped region -- rockchip,pmu: phandle to the syscon managing the "pmu general register files" -- clocks: phandles for clock specified in "clock-names" property -- clock-names : the name of clock used by the DFI, must be "pclk_ddr_mon"; - -Example: - dfi: dfi@ff630000 { - compatible = "rockchip,rk3399-dfi"; - reg = <0x00 0xff630000 0x00 0x4000>; - rockchip,pmu = <&pmugrf>; - clocks = <&cru PCLK_DDR_MON>; - clock-names = "pclk_ddr_mon"; - }; diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml new file mode 100644 index 0000000000000..e082a0df7895a --- /dev/null +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml @@ -0,0 +1,38 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/devfreq/event/rockchip-dfi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Rockchip DFI + +maintainers: + - Sascha Hauer <s.hauer@pengutronix.de> + +properties: + compatible: + enum: + - rk3399-dfi + - rk3568-dfi + + clocks: + maxItems: 1 + + rockchip,pmu: + $ref: /schemas/types.yaml#/definitions/phandle + description: + Phandle to the syscon managing the "PMU general register files". + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + dfi: dfi@fe230000 { + compatible = "rockchip,rk3568-dfi"; + reg = <0x00 0xfe230000 0x00 0x400>; + rockchip,pmu = <&pmugrf>; + };
Convert the Rockchip DFI binding to yaml. While at it add the newly supported rk3568-dfi to the binding. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- .../bindings/devfreq/event/rockchip-dfi.txt | 18 --------- .../bindings/devfreq/event/rockchip-dfi.yaml | 38 +++++++++++++++++++ 2 files changed, 38 insertions(+), 18 deletions(-) delete mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml