| Message ID | 20230203100952.13857-1-pvorel@suse.cz (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2866527093ddbc6356bb31f560f0b4b4decf3e2e |
| Headers | show |
| Series | [1/1] arm64: dts: qcom: msm8992-lg-bullhead: Enable regulators | expand |
> > Enable pm8994_s1, pm8994_l{26,29,30,32} regulators. > Use values from downstream kernel on bullhead rev 1.01. > > NOTE: downstream kernel on angler rev 1.01 differences: > * pm8994_l29: regulator-min-microvolt = <2700000> > * pm8994_l{20,28,31}: use regulator-boot-on > > Verification: > [ 1.832460] s1: Bringing 0uV into 1025000-1025000uV > ... > [ 2.057667] l26: Bringing 0uV into 987500-987500uV > ... > [ 2.075722] l29: Bringing 0uV into 2800000-2800000uV > [ 2.076604] l30: Bringing 0uV into 1800000-1800000uV > [ 2.082431] l31: Bringing 0uV into 1262500-1262500uV > [ 2.095767] l32: Bringing 0uV into 1800000-1800000uV > > Fixes: f3b2c99e73be ("arm64: dts: Enable onboard SDHCI on msm8992") > Signed-off-by: Petr Vorel <pvorel@suse.cz> Tested-by: Jamie Douglass <jamiemdouglass@gmail.com> > --- > .../boot/dts/qcom/msm8992-lg-bullhead.dtsi | 32 ++++++------------- > 1 file changed, 10 insertions(+), 22 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi > index a100b05abf56..b8f2a01bcb96 100644 > --- a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi > @@ -89,8 +89,8 @@ pm8994_regulators: regulators-0 { > /* S1, S2, S6 and S12 are managed by RPMPD */ > > pm8994_s1: s1 { > - regulator-min-microvolt = <800000>; > - regulator-max-microvolt = <800000>; > + regulator-min-microvolt = <1025000>; > + regulator-max-microvolt = <1025000>; > }; > > pm8994_s2: s2 { > @@ -246,11 +246,8 @@ pm8994_l25: l25 { > }; > > pm8994_l26: l26 { > - /* > - * TODO: value from downstream > - * regulator-min-microvolt = <987500>; > - * fails to apply > - */ > + regulator-min-microvolt = <987500>; > + regulator-max-microvolt = <987500>; > }; > > pm8994_l27: l27 { > @@ -264,19 +261,13 @@ pm8994_l28: l28 { > }; > > pm8994_l29: l29 { > - /* > - * TODO: Unsupported voltage range. > - * regulator-min-microvolt = <2800000>; > - * regulator-max-microvolt = <2800000>; > - */ > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2800000>; > }; > > pm8994_l30: l30 { > - /* > - * TODO: get this verified > - * regulator-min-microvolt = <1800000>; > - * regulator-max-microvolt = <1800000>; > - */ > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > }; > > pm8994_l31: l31 { > @@ -285,11 +276,8 @@ pm8994_l31: l31 { > }; > > pm8994_l32: l32 { > - /* > - * TODO: get this verified > - * regulator-min-microvolt = <1800000>; > - * regulator-max-microvolt = <1800000>; > - */ > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > }; > }; > > -- > 2.39.1 >
On Fri, 3 Feb 2023 11:09:52 +0100, Petr Vorel wrote: > Enable pm8994_s1, pm8994_l{26,29,30,32} regulators. > Use values from downstream kernel on bullhead rev 1.01. > > NOTE: downstream kernel on angler rev 1.01 differences: > * pm8994_l29: regulator-min-microvolt = <2700000> > * pm8994_l{20,28,31}: use regulator-boot-on > > [...] Applied, thanks! [1/1] arm64: dts: qcom: msm8992-lg-bullhead: Enable regulators commit: 2866527093ddbc6356bb31f560f0b4b4decf3e2e Best regards,
diff --git a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi index a100b05abf56..b8f2a01bcb96 100644 --- a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi @@ -89,8 +89,8 @@ pm8994_regulators: regulators-0 { /* S1, S2, S6 and S12 are managed by RPMPD */ pm8994_s1: s1 { - regulator-min-microvolt = <800000>; - regulator-max-microvolt = <800000>; + regulator-min-microvolt = <1025000>; + regulator-max-microvolt = <1025000>; }; pm8994_s2: s2 { @@ -246,11 +246,8 @@ pm8994_l25: l25 { }; pm8994_l26: l26 { - /* - * TODO: value from downstream - * regulator-min-microvolt = <987500>; - * fails to apply - */ + regulator-min-microvolt = <987500>; + regulator-max-microvolt = <987500>; }; pm8994_l27: l27 { @@ -264,19 +261,13 @@ pm8994_l28: l28 { }; pm8994_l29: l29 { - /* - * TODO: Unsupported voltage range. - * regulator-min-microvolt = <2800000>; - * regulator-max-microvolt = <2800000>; - */ + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; }; pm8994_l30: l30 { - /* - * TODO: get this verified - * regulator-min-microvolt = <1800000>; - * regulator-max-microvolt = <1800000>; - */ + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; }; pm8994_l31: l31 { @@ -285,11 +276,8 @@ pm8994_l31: l31 { }; pm8994_l32: l32 { - /* - * TODO: get this verified - * regulator-min-microvolt = <1800000>; - * regulator-max-microvolt = <1800000>; - */ + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; }; };
Enable pm8994_s1, pm8994_l{26,29,30,32} regulators. Use values from downstream kernel on bullhead rev 1.01. NOTE: downstream kernel on angler rev 1.01 differences: * pm8994_l29: regulator-min-microvolt = <2700000> * pm8994_l{20,28,31}: use regulator-boot-on Verification: [ 1.832460] s1: Bringing 0uV into 1025000-1025000uV ... [ 2.057667] l26: Bringing 0uV into 987500-987500uV ... [ 2.075722] l29: Bringing 0uV into 2800000-2800000uV [ 2.076604] l30: Bringing 0uV into 1800000-1800000uV [ 2.082431] l31: Bringing 0uV into 1262500-1262500uV [ 2.095767] l32: Bringing 0uV into 1800000-1800000uV Fixes: f3b2c99e73be ("arm64: dts: Enable onboard SDHCI on msm8992") Signed-off-by: Petr Vorel <pvorel@suse.cz> --- .../boot/dts/qcom/msm8992-lg-bullhead.dtsi | 32 ++++++------------- 1 file changed, 10 insertions(+), 22 deletions(-)