| Message ID | 20230206-topic-sm8450-upstream-dp-controller-v1-1-f1345872ed19@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: qcom: add DP Controller to SM8350 & SM8450 DTS | expand |
On 06/02/2023 11:17, Neil Armstrong wrote: > The SM8450 & SM350 shares the same DT TX IP version, use the > SM8350 compatible as fallback for SM8450. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > index 0e8d8df686dc..98bae326e655 100644 > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > @@ -25,6 +25,10 @@ properties: > - qcom,sc8280xp-edp > - qcom,sdm845-dp > - qcom,sm8350-dp > + - items: > + - enum: > + - qcom,sm8450-dp Indentation looks wrong here. Testing should fail, did you test it? Best regards, Krzysztof
On 06/02/2023 12:33, Krzysztof Kozlowski wrote: > On 06/02/2023 11:17, Neil Armstrong wrote: >> The SM8450 & SM350 shares the same DT TX IP version, use the >> SM8350 compatible as fallback for SM8450. >> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> index 0e8d8df686dc..98bae326e655 100644 >> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> @@ -25,6 +25,10 @@ properties: >> - qcom,sc8280xp-edp >> - qcom,sdm845-dp >> - qcom,sm8350-dp >> + - items: >> + - enum: >> + - qcom,sm8450-dp > > Indentation looks wrong here. Testing should fail, did you test it? Moreover it also breaks dt-schema, see https://github.com/devicetree-org/dt-schema/issues/98 > > Best regards, > Krzysztof >
On 06/02/2023 12:20, Dmitry Baryshkov wrote: > On 06/02/2023 12:33, Krzysztof Kozlowski wrote: >> On 06/02/2023 11:17, Neil Armstrong wrote: >>> The SM8450 & SM350 shares the same DT TX IP version, use the >>> SM8350 compatible as fallback for SM8450. >>> >>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >>> --- >>> Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>> index 0e8d8df686dc..98bae326e655 100644 >>> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>> @@ -25,6 +25,10 @@ properties: >>> - qcom,sc8280xp-edp >>> - qcom,sdm845-dp >>> - qcom,sm8350-dp >>> + - items: >>> + - enum: >>> + - qcom,sm8450-dp >> >> Indentation looks wrong here. Testing should fail, did you test it? > > Moreover it also breaks dt-schema, see https://github.com/devicetree-org/dt-schema/issues/98 Yep the change totally broke on rebase, will fix it Sorry for the noise. Neil > >> >> Best regards, >> Krzysztof >> >
On 06/02/2023 14:36, Neil Armstrong wrote: > On 06/02/2023 12:20, Dmitry Baryshkov wrote: >> On 06/02/2023 12:33, Krzysztof Kozlowski wrote: >>> On 06/02/2023 11:17, Neil Armstrong wrote: >>>> The SM8450 & SM350 shares the same DT TX IP version, use the >>>> SM8350 compatible as fallback for SM8450. >>>> >>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >>>> --- >>>> Documentation/devicetree/bindings/display/msm/dp-controller.yaml | >>>> 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git >>>> a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>>> b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>>> index 0e8d8df686dc..98bae326e655 100644 >>>> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>>> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>>> @@ -25,6 +25,10 @@ properties: >>>> - qcom,sc8280xp-edp >>>> - qcom,sdm845-dp >>>> - qcom,sm8350-dp >>>> + - items: >>>> + - enum: >>>> + - qcom,sm8450-dp >>> >>> Indentation looks wrong here. Testing should fail, did you test it? >> >> Moreover it also breaks dt-schema, see >> https://github.com/devicetree-org/dt-schema/issues/98 > > Yep the change totally broke on rebase, will fix it > > Sorry for the noise. N/p. You might want to check the sm8350 GPU patchset. I had to reorder DT nodes.
diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml index 0e8d8df686dc..98bae326e655 100644 --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml @@ -25,6 +25,10 @@ properties: - qcom,sc8280xp-edp - qcom,sdm845-dp - qcom,sm8350-dp + - items: + - enum: + - qcom,sm8450-dp + - const: qcom,sm8350-dp reg: minItems: 4
The SM8450 & SM350 shares the same DT TX IP version, use the SM8350 compatible as fallback for SM8450. Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 4 ++++ 1 file changed, 4 insertions(+)