diff mbox series

[3/8] arm64: dts: amlogic: meson-axg-jethome-jethub-j1xx: remove invalid #gpio-cells in onewire node

Message ID 20230207-b4-amlogic-bindings-fixups-v2-v1-3-93b7e50286e7@linaro.org (mailing list archive)
State New, archived
Headers show
Series arm64: meson: bunch of DT fixes, take 2 | expand

Commit Message

Neil Armstrong Feb. 7, 2023, 3:07 p.m. UTC 
Fixes the following bindings check errors:
 - #gpio-cells: [[1]] is not of type 'object'
 - 'gpio-controller' is a dependency of '#gpio-cells'

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j1xx.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Viacheslav Feb. 8, 2023, 6:22 a.m. UTC | #1 
Thanks.

On 07/02/2023 18.07, Neil Armstrong wrote:
> Fixes the following bindings check errors:
>   - #gpio-cells: [[1]] is not of type 'object'
>   - 'gpio-controller' is a dependency of '#gpio-cells'
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
>   arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j1xx.dtsi | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j1xx.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j1xx.dtsi
> index e1605a9b0a13..db605f3a22b4 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j1xx.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j1xx.dtsi
> @@ -159,7 +159,6 @@ map1 {
>   	onewire {
>   		compatible = "w1-gpio";
>   		gpios = <&gpio GPIOA_14 GPIO_ACTIVE_HIGH>;
> -		#gpio-cells = <1>;
>   	};
>   };
>   
> 

Acked-by: Vyacheslav Bocharov <adeep@lexina.in>
Martin Blumenstingl Feb. 11, 2023, 8:06 p.m. UTC | #2 
On Tue, Feb 7, 2023 at 4:08 PM Neil Armstrong <neil.armstrong@linaro.org> wrote:
>
> Fixes the following bindings check errors:
>  - #gpio-cells: [[1]] is not of type 'object'
>  - 'gpio-controller' is a dependency of '#gpio-cells'
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j1xx.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j1xx.dtsi
index e1605a9b0a13..db605f3a22b4 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j1xx.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j1xx.dtsi
@@ -159,7 +159,6 @@  map1 {
 	onewire {
 		compatible = "w1-gpio";
 		gpios = <&gpio GPIOA_14 GPIO_ACTIVE_HIGH>;
-		#gpio-cells = <1>;
 	};
 };