| Message ID | 20230106083826.5384-3-lei4.wang@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Support for new CPU model SapphireRapids | expand |
On Fri, 6 Jan 2023 00:38:22 -0800 Lei Wang <lei4.wang@intel.com> wrote: > Parameter "uint32_t bit" is not used in function feature_word_description(), > so remove it. > > Signed-off-by: Lei Wang <lei4.wang@intel.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> > --- > target/i386/cpu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index b6d1247e5e..883098bc5a 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -4290,7 +4290,7 @@ static const TypeInfo max_x86_cpu_type_info = { > .class_init = max_x86_cpu_class_init, > }; > > -static char *feature_word_description(FeatureWordInfo *f, uint32_t bit) > +static char *feature_word_description(FeatureWordInfo *f) > { > assert(f->type == CPUID_FEATURE_WORD || f->type == MSR_FEATURE_WORD); > > @@ -4329,6 +4329,7 @@ static void mark_unavailable_features(X86CPU *cpu, FeatureWord w, uint64_t mask, > CPUX86State *env = &cpu->env; > FeatureWordInfo *f = &feature_word_info[w]; > int i; > + g_autofree char *feat_word_str = feature_word_description(f); > > if (!cpu->force_features) { > env->features[w] &= ~mask; > @@ -4341,7 +4342,6 @@ static void mark_unavailable_features(X86CPU *cpu, FeatureWord w, uint64_t mask, > > for (i = 0; i < 64; ++i) { > if ((1ULL << i) & mask) { > - g_autofree char *feat_word_str = feature_word_description(f, i); > warn_report("%s: %s%s%s [bit %d]", > verbose_prefix, > feat_word_str,
On 1/6/2023 4:38 PM, Lei Wang wrote: > Parameter "uint32_t bit" is not used in function feature_word_description(), > so remove it. > > Signed-off-by: Lei Wang <lei4.wang@intel.com> Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com> > --- > target/i386/cpu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index b6d1247e5e..883098bc5a 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -4290,7 +4290,7 @@ static const TypeInfo max_x86_cpu_type_info = { > .class_init = max_x86_cpu_class_init, > }; > > -static char *feature_word_description(FeatureWordInfo *f, uint32_t bit) > +static char *feature_word_description(FeatureWordInfo *f) > { > assert(f->type == CPUID_FEATURE_WORD || f->type == MSR_FEATURE_WORD); > > @@ -4329,6 +4329,7 @@ static void mark_unavailable_features(X86CPU *cpu, FeatureWord w, uint64_t mask, > CPUX86State *env = &cpu->env; > FeatureWordInfo *f = &feature_word_info[w]; > int i; > + g_autofree char *feat_word_str = feature_word_description(f); > > if (!cpu->force_features) { > env->features[w] &= ~mask; > @@ -4341,7 +4342,6 @@ static void mark_unavailable_features(X86CPU *cpu, FeatureWord w, uint64_t mask, > > for (i = 0; i < 64; ++i) { > if ((1ULL << i) & mask) { > - g_autofree char *feat_word_str = feature_word_description(f, i); > warn_report("%s: %s%s%s [bit %d]", > verbose_prefix, > feat_word_str,
diff --git a/target/i386/cpu.c b/target/i386/cpu.c index b6d1247e5e..883098bc5a 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -4290,7 +4290,7 @@ static const TypeInfo max_x86_cpu_type_info = { .class_init = max_x86_cpu_class_init, }; -static char *feature_word_description(FeatureWordInfo *f, uint32_t bit) +static char *feature_word_description(FeatureWordInfo *f) { assert(f->type == CPUID_FEATURE_WORD || f->type == MSR_FEATURE_WORD); @@ -4329,6 +4329,7 @@ static void mark_unavailable_features(X86CPU *cpu, FeatureWord w, uint64_t mask, CPUX86State *env = &cpu->env; FeatureWordInfo *f = &feature_word_info[w]; int i; + g_autofree char *feat_word_str = feature_word_description(f); if (!cpu->force_features) { env->features[w] &= ~mask; @@ -4341,7 +4342,6 @@ static void mark_unavailable_features(X86CPU *cpu, FeatureWord w, uint64_t mask, for (i = 0; i < 64; ++i) { if ((1ULL << i) & mask) { - g_autofree char *feat_word_str = feature_word_description(f, i); warn_report("%s: %s%s%s [bit %d]", verbose_prefix, feat_word_str,
Parameter "uint32_t bit" is not used in function feature_word_description(), so remove it. Signed-off-by: Lei Wang <lei4.wang@intel.com> --- target/i386/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)