| Message ID | 20230127192139.299228-1-brgl@bgdev.pl (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | dt-bindings: firmware: qcom,scm: add qcom,scm-sa8775p compatible | expand |
On 27/01/2023 20:21, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Add a compatible for the sa8775p platform's Secure Channel Manager > firmware interface. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 + > 1 file changed, 1 insertion(+) If you send bindings separately from DTS (which is fine), please provide the link to the user - either DTS or driver for this compatible. Driver does not use it, thus to the DTS. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, 27 Jan 2023 at 20:56, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 27/01/2023 20:21, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > Add a compatible for the sa8775p platform's Secure Channel Manager > > firmware interface. > > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > --- > > Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 + > > 1 file changed, 1 insertion(+) > > If you send bindings separately from DTS (which is fine), please provide > the link to the user - either DTS or driver for this compatible. Driver > does not use it, thus to the DTS. > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Can you specify what kind of link you're expecting? I'm looking at previous commits for this file and not seeing anything. There's no upstream user of this compatible in any DTS yet. Bart
On 27/01/2023 22:22, Bartosz Golaszewski wrote: > On Fri, 27 Jan 2023 at 20:56, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 27/01/2023 20:21, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >>> >>> Add a compatible for the sa8775p platform's Secure Channel Manager >>> firmware interface. >>> >>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >>> --- >>> Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 + >>> 1 file changed, 1 insertion(+) >> >> If you send bindings separately from DTS (which is fine), please provide >> the link to the user - either DTS or driver for this compatible. Driver >> does not use it, thus to the DTS. >> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> > > Can you specify what kind of link you're expecting? I'm looking at > previous commits for this file and not seeing anything. There's no > upstream user of this compatible in any DTS yet. I expect lore link to the patchset you sent using this binding, so we can verify whether you used it correctly or not. If people were testing their DTS against bindings they write, this would not be needed. Unfortunately people do not do that... Best regards, Krzysztof
On Sat, Jan 28, 2023 at 11:13 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 27/01/2023 22:22, Bartosz Golaszewski wrote: > > On Fri, 27 Jan 2023 at 20:56, Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> > >> On 27/01/2023 20:21, Bartosz Golaszewski wrote: > >>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > >>> > >>> Add a compatible for the sa8775p platform's Secure Channel Manager > >>> firmware interface. > >>> > >>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > >>> --- > >>> Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 + > >>> 1 file changed, 1 insertion(+) > >> > >> If you send bindings separately from DTS (which is fine), please provide > >> the link to the user - either DTS or driver for this compatible. Driver > >> does not use it, thus to the DTS. > >> > >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> > > > > Can you specify what kind of link you're expecting? I'm looking at > > previous commits for this file and not seeing anything. There's no > > upstream user of this compatible in any DTS yet. > > > I expect lore link to the patchset you sent using this binding, so we > can verify whether you used it correctly or not. If people were testing > their DTS against bindings they write, this would not be needed. > Unfortunately people do not do that... > Touché. I am making sure v2 passes dtbs_check though. :) v1 didn't have this compatible and used the fallback directly, hence this patch being sent before v2. There's no link yet, as I'm still polishing the dts for sa8775p-ride. Will remember to add one in the future. Bart
On Fri, 27 Jan 2023 20:21:39 +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Add a compatible for the sa8775p platform's Secure Channel Manager > firmware interface. > > Applied, thanks! [1/1] dt-bindings: firmware: qcom,scm: add qcom,scm-sa8775p compatible commit: 27d71e8063d99b4429832bc52de171ace6b1e562 Best regards,
On Thu, 9 Feb 2023 at 05:21, Bjorn Andersson <andersson@kernel.org> wrote: > > On Fri, 27 Jan 2023 20:21:39 +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > Add a compatible for the sa8775p platform's Secure Channel Manager > > firmware interface. > > > > > > Applied, thanks! > > [1/1] dt-bindings: firmware: qcom,scm: add qcom,scm-sa8775p compatible > commit: 27d71e8063d99b4429832bc52de171ace6b1e562 > > Best regards, > -- > Bjorn Andersson <andersson@kernel.org> Bjorn, FYI I resent this patch as part of an integration series later[1] as per Krzysztof's suggestion. Could you pick the entire thing up too? Thanks! Bart [1] https://lore.kernel.org/linux-arm-msm/20230201152038.203387-1-brgl@bgdev.pl/
diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml index 4193492ba73e..fd3c787e44a8 100644 --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml @@ -39,6 +39,7 @@ properties: - qcom,scm-msm8996 - qcom,scm-msm8998 - qcom,scm-qdu1000 + - qcom,scm-sa8775p - qcom,scm-sc7180 - qcom,scm-sc7280 - qcom,scm-sc8280xp