| Message ID | 20230208103709.116896-3-angelogioacchino.delregno@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Panfrost: Improve and add MediaTek SoCs support | expand |
On Wed, Feb 8, 2023 at 6:37 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > MediaTek MT8192 (and similar) needs five power domains for the > Mali GPU and no sram-supply: change the binding to allow so. > mt8192 compatible was already added, so this should have: Fixes: 5d82e74a97c2 ("dt-bindings: Add compatible for Mali Valhall (JM)") > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../bindings/gpu/arm,mali-bifrost.yaml | 34 +++++++++++++++++-- > 1 file changed, 31 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > index 69212f3b1328..e7aba66ddb8f 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > @@ -61,7 +61,7 @@ properties: > > power-domains: > minItems: 1 > - maxItems: 3 > + maxItems: 5 > > resets: > minItems: 1 > @@ -141,6 +141,18 @@ allOf: > - power-domains > - resets > - reset-names > + - if: > + not: > + properties: > + compatible: > + contains: > + enum: > + - mediatek,mt8183-mali > + - mediatek,mt8192-mali > + then: > + properties: > + power-domains: > + maxItems: 1 > - if: > properties: > compatible: > @@ -161,10 +173,26 @@ allOf: > - sram-supply > - power-domains > - power-domain-names > - else: > + - if: > + properties: > + compatible: > + contains: > + const: mediatek,mt8192-mali > + then: > properties: > power-domains: > - maxItems: 1 > + minItems: 5 > + power-domain-names: > + items: > + - const: core0 > + - const: core1 > + - const: core2 > + - const: core3 > + - const: core4 > + > + required: > + - power-domains > + - power-domain-names > - if: > properties: > compatible: > -- > 2.39.1 >
Il 09/02/23 09:33, Chen-Yu Tsai ha scritto: > On Wed, Feb 8, 2023 at 6:37 PM AngeloGioacchino Del Regno > <angelogioacchino.delregno@collabora.com> wrote: >> >> MediaTek MT8192 (and similar) needs five power domains for the >> Mali GPU and no sram-supply: change the binding to allow so. >> > > mt8192 compatible was already added, so this should have: > > Fixes: 5d82e74a97c2 ("dt-bindings: Add compatible for Mali Valhall (JM)") > Yeah, agreed.
On Wed, 08 Feb 2023 11:37:02 +0100, AngeloGioacchino Del Regno wrote: > MediaTek MT8192 (and similar) needs five power domains for the > Mali GPU and no sram-supply: change the binding to allow so. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../bindings/gpu/arm,mali-bifrost.yaml | 34 +++++++++++++++++-- > 1 file changed, 31 insertions(+), 3 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml index 69212f3b1328..e7aba66ddb8f 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml @@ -61,7 +61,7 @@ properties: power-domains: minItems: 1 - maxItems: 3 + maxItems: 5 resets: minItems: 1 @@ -141,6 +141,18 @@ allOf: - power-domains - resets - reset-names + - if: + not: + properties: + compatible: + contains: + enum: + - mediatek,mt8183-mali + - mediatek,mt8192-mali + then: + properties: + power-domains: + maxItems: 1 - if: properties: compatible: @@ -161,10 +173,26 @@ allOf: - sram-supply - power-domains - power-domain-names - else: + - if: + properties: + compatible: + contains: + const: mediatek,mt8192-mali + then: properties: power-domains: - maxItems: 1 + minItems: 5 + power-domain-names: + items: + - const: core0 + - const: core1 + - const: core2 + - const: core3 + - const: core4 + + required: + - power-domains + - power-domain-names - if: properties: compatible:
MediaTek MT8192 (and similar) needs five power domains for the Mali GPU and no sram-supply: change the binding to allow so. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- .../bindings/gpu/arm,mali-bifrost.yaml | 34 +++++++++++++++++-- 1 file changed, 31 insertions(+), 3 deletions(-)