Do not add all User ports to the CPU by default. This will break Multi CPU when added a seperate patch. It will be overwritten by .port_enable and since we are forcing output to a port via the Special Tag this is not needed.

Commit Message

Richard van Schagen Feb. 12, 2023, 9:51 p.m. UTC

---
 drivers/net/dsa/mt7530.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Vladimir Oltean Feb. 13, 2023, 1:41 p.m. UTC | #1

Hi Richard,

If Documentation/process/submitting-patches.rst does not completely
clarify, I also recommend running the "git log" command and studying
some of the formatting differences between this patch and any of the
patches that have been accepted.

Patch

diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index f456541a68bc..f59f706d176e 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -1019,12 +1019,6 @@  mt753x_cpu_port_enable(struct dsa_switch *ds, int port)
 	if (priv->id == ID_MT7621)
 		mt7530_rmw(priv, MT7530_MFC, CPU_MASK, CPU_EN | CPU_PORT(port));
 
-	/* CPU port gets connected to all user ports of
-	 * the switch.
-	 */
-	mt7530_write(priv, MT7530_PCR_P(port),
-		     PCR_MATRIX(dsa_user_ports(priv->ds)));
-
 	/* Set to fallback mode for independent VLAN learning */
 	mt7530_rmw(priv, MT7530_PCR_P(port), PCR_PORT_VLAN_MASK,
 		   MT7530_PORT_FALLBACK_MODE);