| Message ID | 20230212082758.1166262-2-felix.moessbauer@siemens.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Rework image classes | expand |
On 12.02.23 09:27, Felix Moessbauer wrote: > This patch registers the provided image classes via the bblayer.conf > file. By that, no manual additions of these classes via kas is required > and erronous implementations are detected early (e.g. mandatory inputs > without defaults). > Then why is this commit not removing those obsolete IMAGE_CLASSES additions? Jan > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com> > --- > conf/layer.conf | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/conf/layer.conf b/conf/layer.conf > index 0c5fd39..2c888b2 100644 > --- a/conf/layer.conf > +++ b/conf/layer.conf > @@ -22,3 +22,5 @@ LAYERSERIES_COMPAT_cip-core = "next" > > LAYERDIR_cip-core = "${LAYERDIR}" > LAYERDIR_cip-core[vardepvalue] = "isar-cip-core" > + > +IMAGE_CLASSES += "squashfs verity swupdate"
On Mon, 2023-02-13 at 15:51 +0100, Jan Kiszka wrote: > On 12.02.23 09:27, Felix Moessbauer wrote: > > This patch registers the provided image classes via the > > bblayer.conf > > file. By that, no manual additions of these classes via kas is > > required > > and erronous implementations are detected early (e.g. mandatory > > inputs > > without defaults). > > > > Then why is this commit not removing those obsolete IMAGE_CLASSES > additions? Good catch. The kas-file changes reg. IMAGE_CLASSES from the following commits should be moved into this commit. Will send a v5 tomorrow. Felix > > Jan > > > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com> > > --- > > conf/layer.conf | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/conf/layer.conf b/conf/layer.conf > > index 0c5fd39..2c888b2 100644 > > --- a/conf/layer.conf > > +++ b/conf/layer.conf > > @@ -22,3 +22,5 @@ LAYERSERIES_COMPAT_cip-core = "next" > > > > LAYERDIR_cip-core = "${LAYERDIR}" > > LAYERDIR_cip-core[vardepvalue] = "isar-cip-core" > > + > > +IMAGE_CLASSES += "squashfs verity swupdate" >
On 13.02.23 16:18, Moessbauer, Felix (T CED INW-CN) wrote: > On Mon, 2023-02-13 at 15:51 +0100, Jan Kiszka wrote: >> On 12.02.23 09:27, Felix Moessbauer wrote: >>> This patch registers the provided image classes via the >>> bblayer.conf >>> file. By that, no manual additions of these classes via kas is >>> required >>> and erronous implementations are detected early (e.g. mandatory >>> inputs >>> without defaults). >>> >> >> Then why is this commit not removing those obsolete IMAGE_CLASSES >> additions? > > Good catch. The kas-file changes reg. IMAGE_CLASSES from the following > commits should be moved into this commit. > > Will send a v5 tomorrow. > Thanks. Then please also check the documentations. There is at least doc/README.secureboot.md referencing this as well. Jan
diff --git a/conf/layer.conf b/conf/layer.conf index 0c5fd39..2c888b2 100644 --- a/conf/layer.conf +++ b/conf/layer.conf @@ -22,3 +22,5 @@ LAYERSERIES_COMPAT_cip-core = "next" LAYERDIR_cip-core = "${LAYERDIR}" LAYERDIR_cip-core[vardepvalue] = "isar-cip-core" + +IMAGE_CLASSES += "squashfs verity swupdate"
This patch registers the provided image classes via the bblayer.conf file. By that, no manual additions of these classes via kas is required and erronous implementations are detected early (e.g. mandatory inputs without defaults). Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com> --- conf/layer.conf | 2 ++ 1 file changed, 2 insertions(+)