diff mbox series

[2/3] fstests: btrfs/219, add _fixed_by_kernel_commit

Message ID 9c696ea007fbadac5aa4d18ecdd1702cbe6e7742.1676034764.git.anand.jain@oracle.com (mailing list archive)
State New, archived
Headers show
Series fstests: btrfs- add _fixed_by for new tests in the auto group | expand

Commit Message

Anand Jain Feb. 10, 2023, 1:41 p.m. UTC
btrfs/219 is in the auto group so add the _fixed_by_kernel_commit
tag for the benifit of the older kernels. The required commit is not yet
in the mainline so there is no commit id yet.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
 tests/btrfs/219 | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Zorro Lang Feb. 14, 2023, 6:07 a.m. UTC | #1
On Fri, Feb 10, 2023 at 09:41:20PM +0800, Anand Jain wrote:
> btrfs/219 is in the auto group so add the _fixed_by_kernel_commit
> tag for the benifit of the older kernels. The required commit is not yet
> in the mainline so there is no commit id yet.
> 
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
>  tests/btrfs/219 | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/btrfs/219 b/tests/btrfs/219
> index 528175b8a4b9..79ba31549268 100755
> --- a/tests/btrfs/219
> +++ b/tests/btrfs/219
> @@ -8,7 +8,7 @@
>  # to make sure we do not allow stale devices, which can end up with some wonky
>  # behavior for loop back devices.  This was changed with
>  #
> -#   btrfs: allow single disk devices to mount with older generations
> +#	btrfs: free device in btrfs_close_devices for a single device filesystem
>  #
>  # But I've added a few other test cases so it's clear what we expect to happen
>  # currently.
> @@ -42,6 +42,8 @@ _supported_fs btrfs
>  _require_test
>  _require_loop
>  _require_btrfs_forget_or_module_loadable
> +_fixed_by_kernel_commit xxxxxxxxxxxx \
> +	"btrfs: free device in btrfs_close_devices for a single device filesystem"

It was just merged ;)

commit 5f58d783fd7823b2c2d5954d1126e702f94bfc4c
Author: Anand Jain <anand.jain@oracle.com>
Date:   Fri Jan 20 21:47:16 2023 +0800

    btrfs: free device in btrfs_close_devices for a single device filesystem


>  
>  loop_mnt=$TEST_DIR/$seq.mnt
>  loop_mnt1=$TEST_DIR/$seq.mnt1
> -- 
> 2.31.1
>
Anand Jain Feb. 15, 2023, 5:33 a.m. UTC | #2
On 2/14/23 14:07, Zorro Lang wrote:
> On Fri, Feb 10, 2023 at 09:41:20PM +0800, Anand Jain wrote:
>> btrfs/219 is in the auto group so add the _fixed_by_kernel_commit
>> tag for the benifit of the older kernels. The required commit is not yet
>> in the mainline so there is no commit id yet.
>>
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>> ---
>>   tests/btrfs/219 | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/btrfs/219 b/tests/btrfs/219
>> index 528175b8a4b9..79ba31549268 100755
>> --- a/tests/btrfs/219
>> +++ b/tests/btrfs/219
>> @@ -8,7 +8,7 @@
>>   # to make sure we do not allow stale devices, which can end up with some wonky
>>   # behavior for loop back devices.  This was changed with
>>   #
>> -#   btrfs: allow single disk devices to mount with older generations
>> +#	btrfs: free device in btrfs_close_devices for a single device filesystem
>>   #
>>   # But I've added a few other test cases so it's clear what we expect to happen
>>   # currently.
>> @@ -42,6 +42,8 @@ _supported_fs btrfs
>>   _require_test
>>   _require_loop
>>   _require_btrfs_forget_or_module_loadable
>> +_fixed_by_kernel_commit xxxxxxxxxxxx \
>> +	"btrfs: free device in btrfs_close_devices for a single device filesystem"
> 
> It was just merged ;)
> 
> commit 5f58d783fd7823b2c2d5954d1126e702f94bfc4c
> Author: Anand Jain <anand.jain@oracle.com>
> Date:   Fri Jan 20 21:47:16 2023 +0800
> 
>      btrfs: free device in btrfs_close_devices for a single device filesystem
> 

Ok. I'm updating the commit id.

I am sending v2 just for this path.

Also, I can combine the series into a single patch if you prefer.

Thanks.


> 
>>   
>>   loop_mnt=$TEST_DIR/$seq.mnt
>>   loop_mnt1=$TEST_DIR/$seq.mnt1
>> -- 
>> 2.31.1
>>
>
diff mbox series

Patch

diff --git a/tests/btrfs/219 b/tests/btrfs/219
index 528175b8a4b9..79ba31549268 100755
--- a/tests/btrfs/219
+++ b/tests/btrfs/219
@@ -8,7 +8,7 @@ 
 # to make sure we do not allow stale devices, which can end up with some wonky
 # behavior for loop back devices.  This was changed with
 #
-#   btrfs: allow single disk devices to mount with older generations
+#	btrfs: free device in btrfs_close_devices for a single device filesystem
 #
 # But I've added a few other test cases so it's clear what we expect to happen
 # currently.
@@ -42,6 +42,8 @@  _supported_fs btrfs
 _require_test
 _require_loop
 _require_btrfs_forget_or_module_loadable
+_fixed_by_kernel_commit xxxxxxxxxxxx \
+	"btrfs: free device in btrfs_close_devices for a single device filesystem"
 
 loop_mnt=$TEST_DIR/$seq.mnt
 loop_mnt1=$TEST_DIR/$seq.mnt1