| Message ID | 1676294058-136786-3-git-send-email-moshe@nvidia.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | devlink: cleanups and move devlink health functionality to separate file | expand |
On Mon, 13 Feb 2023 15:14:10 +0200 Moshe Shemesh wrote: > devlink_nl_health_reporter_fill() error flow calls nla_nest_end(). Fix > it to call nla_nest_cancel() instead. If you do respin please add a sentence to say that this is harmless because we cancel the entire message, anyway.
On 14/02/2023 8:18, Jakub Kicinski wrote: > On Mon, 13 Feb 2023 15:14:10 +0200 Moshe Shemesh wrote: >> devlink_nl_health_reporter_fill() error flow calls nla_nest_end(). Fix >> it to call nla_nest_cancel() instead. > If you do respin please add a sentence to say that this is harmless > because we cancel the entire message, anyway. Ack. That's why no fixes tag
diff --git a/net/devlink/leftover.c b/net/devlink/leftover.c index cfd1b90a0fc1..90f95f06de28 100644 --- a/net/devlink/leftover.c +++ b/net/devlink/leftover.c @@ -6028,7 +6028,7 @@ devlink_nl_health_reporter_fill(struct sk_buff *msg, return 0; reporter_nest_cancel: - nla_nest_end(msg, reporter_attr); + nla_nest_cancel(msg, reporter_attr); genlmsg_cancel: genlmsg_cancel(msg, hdr); return -EMSGSIZE;
devlink_nl_health_reporter_fill() error flow calls nla_nest_end(). Fix it to call nla_nest_cancel() instead. Signed-off-by: Moshe Shemesh <moshe@nvidia.com> --- net/devlink/leftover.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)