| Message ID | 20230213180215.1524938-7-bmeng@tinylab.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | target/riscv: Various fixes to gdbstub and CSR access | expand |
On 2023/2/14 02:02, Bin Meng wrote: > The read_only variable is currently declared as an 'int', but it > should really be a 'bool'. > > Signed-off-by: Bin Meng <bmeng@tinylab.org> Reviewed-by: Weiwei Li <liweiwei@iscas.ac.cn> Regards, Weiwei Li > --- > > target/riscv/csr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/riscv/csr.c b/target/riscv/csr.c > index cc74819759..8bbc75cbfa 100644 > --- a/target/riscv/csr.c > +++ b/target/riscv/csr.c > @@ -3778,7 +3778,7 @@ static inline RISCVException riscv_csrrw_check(CPURISCVState *env, > RISCVCPU *cpu) > { > /* check privileges and return RISCV_EXCP_ILLEGAL_INST if check fails */ > - int read_only = get_field(csrno, 0xC00) == 3; > + bool read_only = get_field(csrno, 0xC00) == 3; > int csr_min_priv = csr_ops[csrno].min_priv_ver; > > /* ensure the CSR extension is enabled. */
On 2023/2/14 2:02, Bin Meng wrote: > The read_only variable is currently declared as an 'int', but it > should really be a 'bool'. > > Signed-off-by: Bin Meng <bmeng@tinylab.org> > --- > > target/riscv/csr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/riscv/csr.c b/target/riscv/csr.c > index cc74819759..8bbc75cbfa 100644 > --- a/target/riscv/csr.c > +++ b/target/riscv/csr.c > @@ -3778,7 +3778,7 @@ static inline RISCVException riscv_csrrw_check(CPURISCVState *env, > RISCVCPU *cpu) > { > /* check privileges and return RISCV_EXCP_ILLEGAL_INST if check fails */ > - int read_only = get_field(csrno, 0xC00) == 3; > + bool read_only = get_field(csrno, 0xC00) == 3; Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com> Zhiwei > int csr_min_priv = csr_ops[csrno].min_priv_ver; > > /* ensure the CSR extension is enabled. */
diff --git a/target/riscv/csr.c b/target/riscv/csr.c index cc74819759..8bbc75cbfa 100644 --- a/target/riscv/csr.c +++ b/target/riscv/csr.c @@ -3778,7 +3778,7 @@ static inline RISCVException riscv_csrrw_check(CPURISCVState *env, RISCVCPU *cpu) { /* check privileges and return RISCV_EXCP_ILLEGAL_INST if check fails */ - int read_only = get_field(csrno, 0xC00) == 3; + bool read_only = get_field(csrno, 0xC00) == 3; int csr_min_priv = csr_ops[csrno].min_priv_ver; /* ensure the CSR extension is enabled. */
The read_only variable is currently declared as an 'int', but it should really be a 'bool'. Signed-off-by: Bin Meng <bmeng@tinylab.org> --- target/riscv/csr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)