| Message ID | 20230128003751.141317-1-srivatsa@csail.mit.edu (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fcb3a81d221750d2a54b4e3a82b3efbbeab8780c |
| Headers | show |
| Series | x86/hotplug: Remove incorrect comment about mwait_play_dead() | expand |
Hi, On 1/27/23 4:37 PM, Srivatsa S. Bhat wrote: > From: "Srivatsa S. Bhat (VMware)" <srivatsa@csail.mit.edu> > > The comment that says mwait_play_dead() returns only on failure is a > bit misleading because mwait_play_dead() could actually return for > valid reasons (such as mwait not being supported by the platform) that > do not indicate a failure of the CPU offline operation. So, remove the > comment. > > Suggested-by: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: Srivatsa S. Bhat (VMware) <srivatsa@csail.mit.edu> Gentle ping for review. Thank you! Regards, Srivatsa > --- > arch/x86/kernel/smpboot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c > index 55cad72715d9..9013bb28255a 100644 > --- a/arch/x86/kernel/smpboot.c > +++ b/arch/x86/kernel/smpboot.c > @@ -1833,7 +1833,7 @@ void native_play_dead(void) > play_dead_common(); > tboot_shutdown(TB_SHUTDOWN_WFS); > > - mwait_play_dead(); /* Only returns on failure */ > + mwait_play_dead(); > if (cpuidle_play_dead()) > hlt_play_dead(); > } >
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index 55cad72715d9..9013bb28255a 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1833,7 +1833,7 @@ void native_play_dead(void) play_dead_common(); tboot_shutdown(TB_SHUTDOWN_WFS); - mwait_play_dead(); /* Only returns on failure */ + mwait_play_dead(); if (cpuidle_play_dead()) hlt_play_dead(); }