mbox series

[net-next,v2,00/10] devlink: cleanups and move devlink health functionality to separate file

Message ID 1676392686-405892-1-git-send-email-moshe@nvidia.com (mailing list archive)
Headers show
Series devlink: cleanups and move devlink health functionality to separate file | expand

Message

Moshe Shemesh Feb. 14, 2023, 4:37 p.m. UTC
This patchset moves devlink health callbacks, helpers and related code
from leftover.c to new file health.c. About 1.3K LoC are moved by this
patchset, covering all devlink health functionality.

In addition this patchset includes a couple of small cleanups in devlink
health code and documentation update.

---
v1->v2:
- Fix kdoc indentation and make reporter create/destroy kdoc more clear
- Add note on the two cleanup patches that the bug is harmless
- Drop patch 4 ("devlink: health: Don't try to add trace with NULL msg")
- Add patch "devlink: Fix TP_STRUCT_entry in trace of devlink health report"


Moshe Shemesh (10):
  devlink: Split out health reporter create code
  devlink: health: Fix nla_nest_end in error flow
  devlink: Move devlink health get and set code to health file
  devlink: Move devlink health report and recover to health file
  devlink: Move devlink fmsg and health diagnose to health file
  devlink: Move devlink health dump to health file
  devlink: Move devlink health test to health file
  devlink: Move health common function to health file
  devlink: Update devlink health documentation
  devlink: Fix TP_STRUCT_entry in trace of devlink health report

 .../networking/devlink/devlink-health.rst     |   23 +-
 include/trace/events/devlink.h                |    2 +-
 net/devlink/Makefile                          |    2 +-
 net/devlink/devl_internal.h                   |   16 +
 net/devlink/health.c                          | 1333 +++++++++++++++++
 net/devlink/leftover.c                        | 1330 +---------------
 6 files changed, 1374 insertions(+), 1332 deletions(-)
 create mode 100644 net/devlink/health.c

Comments

patchwork-bot+netdevbpf@kernel.org Feb. 16, 2023, 3:30 a.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 14 Feb 2023 18:37:56 +0200 you wrote:
> This patchset moves devlink health callbacks, helpers and related code
> from leftover.c to new file health.c. About 1.3K LoC are moved by this
> patchset, covering all devlink health functionality.
> 
> In addition this patchset includes a couple of small cleanups in devlink
> health code and documentation update.
> 
> [...]

Here is the summary with links:
  - [net-next,v2,01/10] devlink: Split out health reporter create code
    https://git.kernel.org/netdev/net-next/c/b4740e3a8137
  - [net-next,v2,02/10] devlink: health: Fix nla_nest_end in error flow
    https://git.kernel.org/netdev/net-next/c/bfd4e6a5dbbc
  - [net-next,v2,03/10] devlink: Move devlink health get and set code to health file
    https://git.kernel.org/netdev/net-next/c/db6b5f3ec400
  - [net-next,v2,04/10] devlink: Move devlink health report and recover to health file
    https://git.kernel.org/netdev/net-next/c/55b9b2496852
  - [net-next,v2,05/10] devlink: Move devlink fmsg and health diagnose to health file
    https://git.kernel.org/netdev/net-next/c/a929df7fd9c6
  - [net-next,v2,06/10] devlink: Move devlink health dump to health file
    https://git.kernel.org/netdev/net-next/c/7004c6c45761
  - [net-next,v2,07/10] devlink: Move devlink health test to health file
    https://git.kernel.org/netdev/net-next/c/c9311ee13f0e
  - [net-next,v2,08/10] devlink: Move health common function to health file
    https://git.kernel.org/netdev/net-next/c/12af29e7790a
  - [net-next,v2,09/10] devlink: Update devlink health documentation
    https://git.kernel.org/netdev/net-next/c/c745cfb27ae3
  - [net-next,v2,10/10] devlink: Fix TP_STRUCT_entry in trace of devlink health report
    https://git.kernel.org/netdev/net-next/c/d0ab772c1f15

You are awesome, thank you!