| Message ID | 20230214135035.1202471-1-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ieee802154: Scan/Beacon fixes | expand |
Hello Jakub, Stefan, Alexander, miquel.raynal@bootlin.com wrote on Tue, 14 Feb 2023 14:50:29 +0100: > Hello, > > Following Jakub's review on Stefan's MR, a number of changes were > requested for him in order to pull the patches in net. In the mean time, > a couple of discussions happened with Alexander (return codes for > monitor scans and transmit helper used for beacons). > > Hopefully this series addresses everything. I know it's only been 3 working days since I sent this series but as we are approaching the closing of net-next and Stefan's MR was paused until these fixes arrived, I wanted to check whether these changes might be satisfying enough, in particular Jakub, if you found the answers you asked for. I mainly want to avoid the "Stefan waits for Alexander who waits for Jakub who waits for Stefan" dependency chain :) Thanks a lot for all the feedback anyway! Miquèl > Changes in v2: > * Fixes lines with upsteam commit hashes rather than local > hashes. Everything else is exactly the same. > > Miquel Raynal (6): > ieee802154: Use netlink policies when relevant on scan parameters > ieee802154: Convert scan error messages to extack > ieee802154: Change error code on monitor scan netlink request > mac802154: Send beacons using the MLME Tx path > mac802154: Fix an always true condition > ieee802154: Drop device trackers > > net/ieee802154/nl802154.c | 125 ++++++++++++++------------------------ > net/mac802154/scan.c | 25 ++++++-- > 2 files changed, 65 insertions(+), 85 deletions(-) >
Hello Miquel. On 17.02.23 10:10, Miquel Raynal wrote: > Hello Jakub, Stefan, Alexander, > > miquel.raynal@bootlin.com wrote on Tue, 14 Feb 2023 14:50:29 +0100: > >> Hello, >> >> Following Jakub's review on Stefan's MR, a number of changes were >> requested for him in order to pull the patches in net. In the mean time, >> a couple of discussions happened with Alexander (return codes for >> monitor scans and transmit helper used for beacons). >> >> Hopefully this series addresses everything. > > I know it's only been 3 working days since I sent this series but as we > are approaching the closing of net-next and Stefan's MR was paused > until these fixes arrived, I wanted to check whether these changes > might be satisfying enough, in particular Jakub, if you found the > answers you asked for. > > I mainly want to avoid the "Stefan waits for Alexander who waits for > Jakub who waits for Stefan" dependency chain :) I just reviewed and tested them and have no problem to take them in. For patches 1 and 2 I would prefer an ack from Jakub to make sure we covered all of this review feedback before. Let's hope we can get these on Monday or Tuesday. Once we have them in I will re-spin a new pull request for all the changes. regards Stefan Schmidt
Hi Stefan, stefan@datenfreihafen.org wrote on Sat, 18 Feb 2023 18:20:22 +0100: > Hello Miquel. > > On 17.02.23 10:10, Miquel Raynal wrote: > > Hello Jakub, Stefan, Alexander, > > > > miquel.raynal@bootlin.com wrote on Tue, 14 Feb 2023 14:50:29 +0100: > > > >> Hello, > >> > >> Following Jakub's review on Stefan's MR, a number of changes were > >> requested for him in order to pull the patches in net. In the mean time, > >> a couple of discussions happened with Alexander (return codes for > >> monitor scans and transmit helper used for beacons). > >> > >> Hopefully this series addresses everything. > > > > I know it's only been 3 working days since I sent this series but as we > > are approaching the closing of net-next and Stefan's MR was paused > > until these fixes arrived, I wanted to check whether these changes > > might be satisfying enough, in particular Jakub, if you found the > > answers you asked for. > > > > I mainly want to avoid the "Stefan waits for Alexander who waits for > > Jakub who waits for Stefan" dependency chain :) > > I just reviewed and tested them and have no problem to take them in. For patches 1 and 2 I would prefer an ack from Jakub to make sure we covered all of this review feedback before. Let's hope we can get these on Monday or Tuesday. Once we have them in I will re-spin a new pull request for all the changes. Thanks a lot! Miquèl
On Sat, 18 Feb 2023 18:20:22 +0100 Stefan Schmidt wrote: > I just reviewed and tested them and have no problem to take them in. For > patches 1 and 2 I would prefer an ack from Jakub to make sure we covered > all of this review feedback before. Sorry I was away, yes, patches 1 and 2 LGTM!
Hello. On 14.02.23 14:50, Miquel Raynal wrote: > Hello, > > Following Jakub's review on Stefan's MR, a number of changes were > requested for him in order to pull the patches in net. In the mean time, > a couple of discussions happened with Alexander (return codes for > monitor scans and transmit helper used for beacons). > > Hopefully this series addresses everything. > > Thanks, > Miquèl > > Changes in v2: > * Fixes lines with upsteam commit hashes rather than local > hashes. Everything else is exactly the same. > > Miquel Raynal (6): > ieee802154: Use netlink policies when relevant on scan parameters > ieee802154: Convert scan error messages to extack > ieee802154: Change error code on monitor scan netlink request > mac802154: Send beacons using the MLME Tx path > mac802154: Fix an always true condition > ieee802154: Drop device trackers > > net/ieee802154/nl802154.c | 125 ++++++++++++++------------------------ > net/mac802154/scan.c | 25 ++++++-- > 2 files changed, 65 insertions(+), 85 deletions(-) These patches have been applied to the wpan-next tree and will be part of the next pull request to net-next. Thanks! regards Stefan Schmidt
Hello Jakub. On 20.02.23 18:59, Jakub Kicinski wrote: > On Sat, 18 Feb 2023 18:20:22 +0100 Stefan Schmidt wrote: >> I just reviewed and tested them and have no problem to take them in. For >> patches 1 and 2 I would prefer an ack from Jakub to make sure we covered >> all of this review feedback before. > > Sorry I was away, yes, patches 1 and 2 LGTM! Thanks. Patches are applied now and will come in an updated pull request later today or tomorrow. regards Stefan Schmidt