diff mbox series

[22/24] kbuild, dmaengine: s3c24xx: remove MODULE_LICENSE in non-modules

Message ID 20230217141059.392471-23-nick.alcock@oracle.com (mailing list archive)
State New, archived
Headers show
Series MODULE_LICENSE removals, second tranche | expand

Commit Message

Nick Alcock Feb. 17, 2023, 2:10 p.m. UTC 
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: dmaengine@vger.kernel.org
---
 drivers/dma/s3c24xx-dma.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Krzysztof Kozlowski Feb. 17, 2023, 2:20 p.m. UTC | #1 
On 17/02/2023 15:10, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
> 
> So remove it in the files in this commit, none of which can be built as
> modules.

I think you need to base your tree-wide patches on next. The driver was
removed. Please drop the patch.


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/drivers/dma/s3c24xx-dma.c b/drivers/dma/s3c24xx-dma.c
index a09eeb545f7d..48965baa2fa1 100644
--- a/drivers/dma/s3c24xx-dma.c
+++ b/drivers/dma/s3c24xx-dma.c
@@ -1425,4 +1425,3 @@  EXPORT_SYMBOL(s3c24xx_dma_filter);
 
 MODULE_DESCRIPTION("S3C24XX DMA Driver");
 MODULE_AUTHOR("Heiko Stuebner");
-MODULE_LICENSE("GPL v2");