| Message ID | 20230217170348.7402-1-alejandro.lucero-palau@amd.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2,net-next] sfc: fix ia64 builds without CONFIG_RTC_LIB | expand |
On 2/18/23 12:03 AM, alejandro.lucero-palau@amd.com wrote: > - memset(&build_date, 0, sizeof(build_date) > + memset(&build_date, 0, sizeof(build_date); Missing ")" for the memset.
On Fri, 2023-02-17 at 17:03 +0000, alejandro.lucero-palau@amd.com wrote: > From: Alejandro Lucero <alejandro.lucero-palau@amd.com> > > Add an embarrasingly missed semicolon breaking kernel building > in ia64 configs. > > Reported-by: kernel test robot <lkp@intel.com> > Link: https://lore.kernel.org/oe-kbuild-all/202302170047.EjCPizu3-lkp@intel.com/ > Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100") > Signed-off-by: Alejandro Lucero <alejandro.lucero-palau@amd.com> > --- > drivers/net/ethernet/sfc/efx_devlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c > index d2eb6712ba35..3eb355fd4282 100644 > --- a/drivers/net/ethernet/sfc/efx_devlink.c > +++ b/drivers/net/ethernet/sfc/efx_devlink.c > @@ -323,7 +323,7 @@ static void efx_devlink_info_running_v2(struct efx_nic *efx, > GET_VERSION_V2_OUT_SUCFW_BUILD_DATE); > rtc_time64_to_tm(tstamp, &build_date); > #else > - memset(&build_date, 0, sizeof(build_date) > + memset(&build_date, 0, sizeof(build_date); You missed the feedback on previous version from Manank reporting you should also add a final ')' above. Should be: + memset(&build_date, 0, sizeof(build_date)); Please try to build test the next version before submitting it, thanks! Paolo
On 2/17/23 17:46, Paolo Abeni wrote: > On Fri, 2023-02-17 at 17:03 +0000, alejandro.lucero-palau@amd.com > wrote: >> From: Alejandro Lucero <alejandro.lucero-palau@amd.com> >> >> Add an embarrasingly missed semicolon breaking kernel building >> in ia64 configs. >> >> Reported-by: kernel test robot <lkp@intel.com> >> Link: https://lore.kernel.org/oe-kbuild-all/202302170047.EjCPizu3-lkp@intel.com/ >> Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100") >> Signed-off-by: Alejandro Lucero <alejandro.lucero-palau@amd.com> >> --- >> drivers/net/ethernet/sfc/efx_devlink.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c >> index d2eb6712ba35..3eb355fd4282 100644 >> --- a/drivers/net/ethernet/sfc/efx_devlink.c >> +++ b/drivers/net/ethernet/sfc/efx_devlink.c >> @@ -323,7 +323,7 @@ static void efx_devlink_info_running_v2(struct efx_nic *efx, >> GET_VERSION_V2_OUT_SUCFW_BUILD_DATE); >> rtc_time64_to_tm(tstamp, &build_date); >> #else >> - memset(&build_date, 0, sizeof(build_date) >> + memset(&build_date, 0, sizeof(build_date); > You missed the feedback on previous version from Manank reporting you > should also add a final ')' above. Should be: > > + memset(&build_date, 0, sizeof(build_date)); > > Please try to build test the next version before submitting it, thanks! I thought I did so, but obviously wrongly. The shortcut for configuring the kernel without CONFIG_RTC_LIC did not work but I did not notice. It will not happen again. Thanks > Paolo >
On 2/17/23 17:46, Paolo Abeni wrote: > On Fri, 2023-02-17 at 17:03 +0000, alejandro.lucero-palau@amd.com > wrote: >> From: Alejandro Lucero <alejandro.lucero-palau@amd.com> >> >> Add an embarrasingly missed semicolon breaking kernel building >> in ia64 configs. >> >> Reported-by: kernel test robot <lkp@intel.com> >> Link: https://lore.kernel.org/oe-kbuild-all/202302170047.EjCPizu3-lkp@intel.com/ >> Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100") >> Signed-off-by: Alejandro Lucero <alejandro.lucero-palau@amd.com> >> --- >> drivers/net/ethernet/sfc/efx_devlink.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c >> index d2eb6712ba35..3eb355fd4282 100644 >> --- a/drivers/net/ethernet/sfc/efx_devlink.c >> +++ b/drivers/net/ethernet/sfc/efx_devlink.c >> @@ -323,7 +323,7 @@ static void efx_devlink_info_running_v2(struct efx_nic *efx, >> GET_VERSION_V2_OUT_SUCFW_BUILD_DATE); >> rtc_time64_to_tm(tstamp, &build_date); >> #else >> - memset(&build_date, 0, sizeof(build_date) >> + memset(&build_date, 0, sizeof(build_date); > You missed the feedback on previous version from Manank reporting you > should also add a final ')' above. Should be: > > + memset(&build_date, 0, sizeof(build_date)); > > Please try to build test the next version before submitting it, thanks! I thought I did so, but obviously wrongly. The shortcut for configuring the kernel without CONFIG_RTC_LIC did not work but I did not notice. It will not happen again. Thanks > Paolo >
diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c index d2eb6712ba35..3eb355fd4282 100644 --- a/drivers/net/ethernet/sfc/efx_devlink.c +++ b/drivers/net/ethernet/sfc/efx_devlink.c @@ -323,7 +323,7 @@ static void efx_devlink_info_running_v2(struct efx_nic *efx, GET_VERSION_V2_OUT_SUCFW_BUILD_DATE); rtc_time64_to_tm(tstamp, &build_date); #else - memset(&build_date, 0, sizeof(build_date) + memset(&build_date, 0, sizeof(build_date); #endif build_id = MCDI_DWORD(outbuf, GET_VERSION_V2_OUT_SUCFW_CHIP_ID);