| Message ID | 75cbde02c45a75268b19dc8091a3af13ca1c2903.1676393253.git.anand.jain@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] fstests: btrfs/249: add _wants_kernel_commit | expand |
On Wed, Feb 15, 2023 at 7:54 AM Anand Jain <anand.jain@oracle.com> wrote: > > Add the _wants_kernel_commit tag for the benifit of testing on the older > kernels. And the _fixed_by_git_commit tag for btrfs-progs too. The subject is also no longer up to date too. s/benifit/benefit/ Otherwise looks good, thanks Reviewed-by: Filipe Manana <fdmanana@suse.com> > > Signed-off-by: Anand Jain <anand.jain@oracle.com> > --- > v2: Include the necessary btrfs-progs patch. > > tests/btrfs/249 | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/tests/btrfs/249 b/tests/btrfs/249 > index 7cc4996e387b..06cc444b5d7a 100755 > --- a/tests/btrfs/249 > +++ b/tests/btrfs/249 > @@ -12,9 +12,6 @@ > # Create a sprout filesystem (an rw device on top of a seed device) > # Dump 'btrfs filesystem usage', check it didn't fail > # > -# Tests btrfs-progs bug fixed by the kernel patch and a btrfs-prog patch > -# btrfs: sysfs add devinfo/fsid to retrieve fsid from the device > -# btrfs-progs: read fsid from the sysfs in device_is_seed > > . ./common/preamble > _begin_fstest auto quick seed volume > @@ -29,6 +26,10 @@ _supported_fs btrfs > _require_scratch_dev_pool 3 > _require_command "$WIPEFS_PROG" wipefs > _require_btrfs_forget_or_module_loadable > +_wants_kernel_commit a26d60dedf9a \ > + "btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device" > +_fixed_by_git_commit btrfs-progs xxxxxxxxxxxx \ > + "btrfs-progs: read fsid from the sysfs in device_is_seed" > > _scratch_dev_pool_get 2 > # use the scratch devices as seed devices > -- > 2.31.1 >
On 15/02/2023 18:55, Filipe Manana wrote: > On Wed, Feb 15, 2023 at 7:54 AM Anand Jain <anand.jain@oracle.com> wrote: >> >> Add the _wants_kernel_commit tag for the benifit of testing on the older >> kernels. > > And the _fixed_by_git_commit tag for btrfs-progs too. > The subject is also no longer up to date too. > > s/benifit/benefit/ > > Otherwise looks good, thanks > > Reviewed-by: Filipe Manana <fdmanana@suse.com> Thanks. Fixed them in v3. -Anand. > > >> >> Signed-off-by: Anand Jain <anand.jain@oracle.com> >> --- >> v2: Include the necessary btrfs-progs patch. >> >> tests/btrfs/249 | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/tests/btrfs/249 b/tests/btrfs/249 >> index 7cc4996e387b..06cc444b5d7a 100755 >> --- a/tests/btrfs/249 >> +++ b/tests/btrfs/249 >> @@ -12,9 +12,6 @@ >> # Create a sprout filesystem (an rw device on top of a seed device) >> # Dump 'btrfs filesystem usage', check it didn't fail >> # >> -# Tests btrfs-progs bug fixed by the kernel patch and a btrfs-prog patch >> -# btrfs: sysfs add devinfo/fsid to retrieve fsid from the device >> -# btrfs-progs: read fsid from the sysfs in device_is_seed >> >> . ./common/preamble >> _begin_fstest auto quick seed volume >> @@ -29,6 +26,10 @@ _supported_fs btrfs >> _require_scratch_dev_pool 3 >> _require_command "$WIPEFS_PROG" wipefs >> _require_btrfs_forget_or_module_loadable >> +_wants_kernel_commit a26d60dedf9a \ >> + "btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device" >> +_fixed_by_git_commit btrfs-progs xxxxxxxxxxxx \ >> + "btrfs-progs: read fsid from the sysfs in device_is_seed" >> >> _scratch_dev_pool_get 2 >> # use the scratch devices as seed devices >> -- >> 2.31.1 >>
diff --git a/tests/btrfs/249 b/tests/btrfs/249 index 7cc4996e387b..06cc444b5d7a 100755 --- a/tests/btrfs/249 +++ b/tests/btrfs/249 @@ -12,9 +12,6 @@ # Create a sprout filesystem (an rw device on top of a seed device) # Dump 'btrfs filesystem usage', check it didn't fail # -# Tests btrfs-progs bug fixed by the kernel patch and a btrfs-prog patch -# btrfs: sysfs add devinfo/fsid to retrieve fsid from the device -# btrfs-progs: read fsid from the sysfs in device_is_seed . ./common/preamble _begin_fstest auto quick seed volume @@ -29,6 +26,10 @@ _supported_fs btrfs _require_scratch_dev_pool 3 _require_command "$WIPEFS_PROG" wipefs _require_btrfs_forget_or_module_loadable +_wants_kernel_commit a26d60dedf9a \ + "btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device" +_fixed_by_git_commit btrfs-progs xxxxxxxxxxxx \ + "btrfs-progs: read fsid from the sysfs in device_is_seed" _scratch_dev_pool_get 2 # use the scratch devices as seed devices
Add the _wants_kernel_commit tag for the benifit of testing on the older kernels. Signed-off-by: Anand Jain <anand.jain@oracle.com> --- v2: Include the necessary btrfs-progs patch. tests/btrfs/249 | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)