| Message ID | 20230217141059.392471-12-nick.alcock@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | MODULE_LICENSE removals, second tranche | expand |
On Fri, Feb 17, 2023, at 15:10, Nick Alcock wrote: > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock <nick.alcock@oracle.com> > Suggested-by: Luis Chamberlain <mcgrof@kernel.org> > Cc: Luis Chamberlain <mcgrof@kernel.org> > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com> > Cc: Hector Martin <marcan@marcan.st> > Cc: Sven Peter <sven@svenpeter.dev> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: asahi@lists.linux.dev > Cc: linux-arm-kernel@lists.infradead.org > --- Acked-by: Sven Peter <sven@svenpeter.dev> Sven > drivers/soc/apple/apple-pmgr-pwrstate.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/soc/apple/apple-pmgr-pwrstate.c > b/drivers/soc/apple/apple-pmgr-pwrstate.c > index e1122288409a..2c15474c7b53 100644 > --- a/drivers/soc/apple/apple-pmgr-pwrstate.c > +++ b/drivers/soc/apple/apple-pmgr-pwrstate.c > @@ -319,6 +319,5 @@ static struct platform_driver apple_pmgr_ps_driver > = { > > MODULE_AUTHOR("Hector Martin <marcan@marcan.st>"); > MODULE_DESCRIPTION("PMGR power state driver for Apple SoCs"); > -MODULE_LICENSE("GPL v2"); > > module_platform_driver(apple_pmgr_ps_driver); > -- > 2.39.1.268.g9de2f9a303
On Fri, 17 Feb 2023 at 14:20, Nick Alcock <nick.alcock@oracle.com> wrote: > > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock <nick.alcock@oracle.com> > Suggested-by: Luis Chamberlain <mcgrof@kernel.org> > Cc: Luis Chamberlain <mcgrof@kernel.org> > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com> > Cc: Hector Martin <marcan@marcan.st> > Cc: Sven Peter <sven@svenpeter.dev> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: asahi@lists.linux.dev > Cc: linux-arm-kernel@lists.infradead.org > --- Reviewed-by: Eric Curtin <ecurtin@redhat.com> Is mise le meas/Regards, Eric Curtin > drivers/soc/apple/apple-pmgr-pwrstate.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/soc/apple/apple-pmgr-pwrstate.c b/drivers/soc/apple/apple-pmgr-pwrstate.c > index e1122288409a..2c15474c7b53 100644 > --- a/drivers/soc/apple/apple-pmgr-pwrstate.c > +++ b/drivers/soc/apple/apple-pmgr-pwrstate.c > @@ -319,6 +319,5 @@ static struct platform_driver apple_pmgr_ps_driver = { > > MODULE_AUTHOR("Hector Martin <marcan@marcan.st>"); > MODULE_DESCRIPTION("PMGR power state driver for Apple SoCs"); > -MODULE_LICENSE("GPL v2"); > > module_platform_driver(apple_pmgr_ps_driver); > -- > 2.39.1.268.g9de2f9a303 > >
diff --git a/drivers/soc/apple/apple-pmgr-pwrstate.c b/drivers/soc/apple/apple-pmgr-pwrstate.c index e1122288409a..2c15474c7b53 100644 --- a/drivers/soc/apple/apple-pmgr-pwrstate.c +++ b/drivers/soc/apple/apple-pmgr-pwrstate.c @@ -319,6 +319,5 @@ static struct platform_driver apple_pmgr_ps_driver = { MODULE_AUTHOR("Hector Martin <marcan@marcan.st>"); MODULE_DESCRIPTION("PMGR power state driver for Apple SoCs"); -MODULE_LICENSE("GPL v2"); module_platform_driver(apple_pmgr_ps_driver);
Since commit 8b41fc4454e ("kbuild: create modules.builtin without Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations are used to identify modules. As a consequence, uses of the macro in non-modules will cause modprobe to misidentify their containing object file as a module when it is not (false positives), and modprobe might succeed rather than failing with a suitable error message. So remove it in the files in this commit, none of which can be built as modules. Signed-off-by: Nick Alcock <nick.alcock@oracle.com> Suggested-by: Luis Chamberlain <mcgrof@kernel.org> Cc: Luis Chamberlain <mcgrof@kernel.org> Cc: linux-modules@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com> Cc: Hector Martin <marcan@marcan.st> Cc: Sven Peter <sven@svenpeter.dev> Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: asahi@lists.linux.dev Cc: linux-arm-kernel@lists.infradead.org --- drivers/soc/apple/apple-pmgr-pwrstate.c | 1 - 1 file changed, 1 deletion(-)