mbox series

[v2,0/3] Resolve warnings from AMDGPU

Message ID 20230217181409.218008-1-arthurgrillo@riseup.net (mailing list archive)
Headers show
Series Resolve warnings from AMDGPU | expand

Message

Arthur Grillo Feb. 17, 2023, 6:14 p.m. UTC
Hi,

This series resolve some of the warnings that appear when compiling AMDGPU
with W=1.

Each patch is focused in a specific warning.

This is my First Patch for the GSoC Project Idea about increasing code
coverage of the DRM code[1].

Thanks for reviewing!

Best regards,
Arthur Grillo

[1]: https://www.x.org/wiki/DRMcoverage2023/#firstpatch

---

v1 -> v2: https://lore.kernel.org/all/20230213204923.111948-1-arthurgrillo@riseup.net/

- Use dm_odm_combine_mode_disabled dm_odm_combine_mode_2to1 instead of an enum casting
- Maintain register read

---

Arthur Grillo (3):
  drm/amd/display: Fix implicit enum conversion
  drm/amd/display: Remove unused local variables
  drm/amd/display: Remove unused local variables and function

 .../amd/display/dc/dcn10/dcn10_link_encoder.c |  3 +-
 .../drm/amd/display/dc/dcn201/dcn201_dpp.c    |  7 ----
 .../drm/amd/display/dc/dcn201/dcn201_hwseq.c  |  2 -
 .../gpu/drm/amd/display/dc/dcn30/dcn30_afmt.c |  2 -
 .../gpu/drm/amd/display/dc/dcn30/dcn30_hubp.c |  4 --
 .../drm/amd/display/dc/dcn30/dcn30_hwseq.c    |  3 --
 .../gpu/drm/amd/display/dc/dcn31/dcn31_apg.c  | 41 -------------------
 .../drm/amd/display/dc/dcn32/dcn32_resource.c |  5 +--
 .../display/dc/dcn32/dcn32_resource_helpers.c |  4 --
 .../dc/dml/dcn20/display_mode_vba_20.c        |  9 ++--
 .../dc/dml/dcn20/display_mode_vba_20v2.c      | 11 ++---
 .../dc/dml/dcn21/display_mode_vba_21.c        | 12 +++---
 .../dc/dml/dcn31/display_rq_dlg_calc_31.c     |  2 -
 .../dc/link/protocols/link_dp_capability.c    |  4 --
 14 files changed, 19 insertions(+), 90 deletions(-)

Comments

Christian König Feb. 20, 2023, 8:11 a.m. UTC | #1
Acked-by: Christian König <christian.koenig@amd.com> for the whole series.

Am 17.02.23 um 19:14 schrieb Arthur Grillo:
> Hi,
>
> This series resolve some of the warnings that appear when compiling AMDGPU
> with W=1.
>
> Each patch is focused in a specific warning.
>
> This is my First Patch for the GSoC Project Idea about increasing code
> coverage of the DRM code[1].
>
> Thanks for reviewing!
>
> Best regards,
> Arthur Grillo
>
> [1]: https://www.x.org/wiki/DRMcoverage2023/#firstpatch
>
> ---
>
> v1 -> v2: https://lore.kernel.org/all/20230213204923.111948-1-arthurgrillo@riseup.net/
>
> - Use dm_odm_combine_mode_disabled dm_odm_combine_mode_2to1 instead of an enum casting
> - Maintain register read
>
> ---
>
> Arthur Grillo (3):
>    drm/amd/display: Fix implicit enum conversion
>    drm/amd/display: Remove unused local variables
>    drm/amd/display: Remove unused local variables and function
>
>   .../amd/display/dc/dcn10/dcn10_link_encoder.c |  3 +-
>   .../drm/amd/display/dc/dcn201/dcn201_dpp.c    |  7 ----
>   .../drm/amd/display/dc/dcn201/dcn201_hwseq.c  |  2 -
>   .../gpu/drm/amd/display/dc/dcn30/dcn30_afmt.c |  2 -
>   .../gpu/drm/amd/display/dc/dcn30/dcn30_hubp.c |  4 --
>   .../drm/amd/display/dc/dcn30/dcn30_hwseq.c    |  3 --
>   .../gpu/drm/amd/display/dc/dcn31/dcn31_apg.c  | 41 -------------------
>   .../drm/amd/display/dc/dcn32/dcn32_resource.c |  5 +--
>   .../display/dc/dcn32/dcn32_resource_helpers.c |  4 --
>   .../dc/dml/dcn20/display_mode_vba_20.c        |  9 ++--
>   .../dc/dml/dcn20/display_mode_vba_20v2.c      | 11 ++---
>   .../dc/dml/dcn21/display_mode_vba_21.c        | 12 +++---
>   .../dc/dml/dcn31/display_rq_dlg_calc_31.c     |  2 -
>   .../dc/link/protocols/link_dp_capability.c    |  4 --
>   14 files changed, 19 insertions(+), 90 deletions(-)
>