| Message ID | 20230221070837.1502935-1-anders.roxell@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] selftests: damon: add config file | expand |
Hi Anders, Thank you for this patch! On Tue, 21 Feb 2023 08:08:36 +0100 Anders Roxell <anders.roxell@linaro.org> wrote: > Building and running the subsuite 'damon' of kselftest, shows the > following issues: > selftests: damon: debugfs_attrs.sh > /sys/kernel/debug/damon not found > > By creating a config file enabling DAMON fragments in the > selftests/damon/ directory the tests pass. > I think we could put Fixes tag as below? Fixes: b348eb7abd09 ("mm/damon: add user space selftests") Though this may not need to be merged in stable. > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > --- > tools/testing/selftests/damon/config | 8 ++++++++ > 1 file changed, 8 insertions(+) > create mode 100644 tools/testing/selftests/damon/config > > diff --git a/tools/testing/selftests/damon/config b/tools/testing/selftests/damon/config > new file mode 100644 > index 000000000000..a6b636e438b9 > --- /dev/null > +++ b/tools/testing/selftests/damon/config > @@ -0,0 +1,8 @@ > +CONFIG_DEBUG_SYSFS=y 's/SYS//'? Or, I guess this is not needed at all? > +CONFIG_DAMON=y > +CONFIG_DAMON_SYSFS=y > +CONFIG_DAMON_DBGFS=y > +CONFIG_DAMON_PADDR=y > +CONFIG_DAMON_VADDR=y > +CONFIG_DAMON_RECLAIM=y > +CONFIG_DAMON_LRU_SORT=y Thanks, SJ > -- > 2.39.1
On Tue, 21 Feb 2023 at 18:19, SeongJae Park <sj@kernel.org> wrote: > > Hi Anders, > > > Thank you for this patch! > > On Tue, 21 Feb 2023 08:08:36 +0100 Anders Roxell <anders.roxell@linaro.org> wrote: > > > Building and running the subsuite 'damon' of kselftest, shows the > > following issues: > > selftests: damon: debugfs_attrs.sh > > /sys/kernel/debug/damon not found > > > > By creating a config file enabling DAMON fragments in the > > selftests/damon/ directory the tests pass. > > > > I think we could put Fixes tag as below? > > Fixes: b348eb7abd09 ("mm/damon: add user space selftests") Make sense, I'll add it. > > Though this may not need to be merged in stable. > > > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > > --- > > tools/testing/selftests/damon/config | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > create mode 100644 tools/testing/selftests/damon/config > > > > diff --git a/tools/testing/selftests/damon/config b/tools/testing/selftests/damon/config > > new file mode 100644 > > index 000000000000..a6b636e438b9 > > --- /dev/null > > +++ b/tools/testing/selftests/damon/config > > @@ -0,0 +1,8 @@ > > +CONFIG_DEBUG_SYSFS=y > > 's/SYS//'? Or, I guess this is not needed at all? This can be dropped. Thank you. I'll respin the patch shortly. Cheers, Anders > > > +CONFIG_DAMON=y > > +CONFIG_DAMON_SYSFS=y > > +CONFIG_DAMON_DBGFS=y > > +CONFIG_DAMON_PADDR=y > > +CONFIG_DAMON_VADDR=y > > +CONFIG_DAMON_RECLAIM=y > > +CONFIG_DAMON_LRU_SORT=y > > > Thanks, > SJ > > > -- > > 2.39.1
diff --git a/tools/testing/selftests/damon/config b/tools/testing/selftests/damon/config new file mode 100644 index 000000000000..a6b636e438b9 --- /dev/null +++ b/tools/testing/selftests/damon/config @@ -0,0 +1,8 @@ +CONFIG_DEBUG_SYSFS=y +CONFIG_DAMON=y +CONFIG_DAMON_SYSFS=y +CONFIG_DAMON_DBGFS=y +CONFIG_DAMON_PADDR=y +CONFIG_DAMON_VADDR=y +CONFIG_DAMON_RECLAIM=y +CONFIG_DAMON_LRU_SORT=y
Building and running the subsuite 'damon' of kselftest, shows the following issues: selftests: damon: debugfs_attrs.sh /sys/kernel/debug/damon not found By creating a config file enabling DAMON fragments in the selftests/damon/ directory the tests pass. Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- tools/testing/selftests/damon/config | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 tools/testing/selftests/damon/config