mbox series

[5.10.y-cip,0/2] Watchdog driver fix and pinctrl improvement

Message ID 20230221080232.24958-1-biju.das.jz@bp.renesas.com (mailing list archive)
Headers show
Series Watchdog driver fix and pinctrl improvement | expand

Message

Biju Das Feb. 21, 2023, 8:02 a.m. UTC
This patch series aims to fix reset issue with watchdog driver
and remove unnecessary check from pinctrl driver for RZ/G2L alike
SoCs.

Biju Das (1):
  pinctrl: renesas: rzg2l: remove unnecessary check from
    rzg2l_dt_node_to_map()

Lad Prabhakar (1):
  watchdog: rzg2l_wdt: Issue a reset before we put the PM clocks

 drivers/pinctrl/renesas/pinctrl-rzg2l.c |  3 +--
 drivers/watchdog/rzg2l_wdt.c            | 10 ++++------
 2 files changed, 5 insertions(+), 8 deletions(-)

Comments

Pavel Machek Feb. 21, 2023, 11:40 a.m. UTC | #1
Hi!

> This patch series aims to fix reset issue with watchdog driver
> and remove unnecessary check from pinctrl driver for RZ/G2L alike
> SoCs.

Thanks for the series, I can apply if there are no other comments and
if it passes testing.

> Lad Prabhakar (1):
>   watchdog: rzg2l_wdt: Issue a reset before we put the PM clocks

This one is fine, thank you.

> Biju Das (1):
>   pinctrl: renesas: rzg2l: remove unnecessary check from
>     rzg2l_dt_node_to_map()

This one is just a cleanup. I can take it since it is your code and
since it is obviously correct.

Best regards,
								Pavel
Nobuhiro Iwamatsu Feb. 21, 2023, 11:26 p.m. UTC | #2
Hi,

> -----Original Message-----
> From: Biju Das <biju.das.jz@bp.renesas.com>
> Sent: Tuesday, February 21, 2023 5:03 PM
> To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □SWC◯A
> CT) <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek
> <pavel@denx.de>
> Cc: Chris Paterson <chris.paterson2@renesas.com>; Biju Das
> <biju.das.jz@bp.renesas.com>; Prabhakar Mahadev Lad
> <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Subject: [PATCH 5.10.y-cip 0/2] Watchdog driver fix and pinctrl improvement
> 
> This patch series aims to fix reset issue with watchdog driver and remove
> unnecessary check from pinctrl driver for RZ/G2L alike SoCs.
> 
> Biju Das (1):
>   pinctrl: renesas: rzg2l: remove unnecessary check from
>     rzg2l_dt_node_to_map()
> 
> Lad Prabhakar (1):
>   watchdog: rzg2l_wdt: Issue a reset before we put the PM clocks
> 
>  drivers/pinctrl/renesas/pinctrl-rzg2l.c |  3 +--
>  drivers/watchdog/rzg2l_wdt.c            | 10 ++++------
>  2 files changed, 5 insertions(+), 8 deletions(-)
> 
I reviewed this series, LGTM.
If no opinion, I will apply this series.

Best regards,
  Nobuhiro
Pavel Machek Feb. 22, 2023, 12:02 p.m. UTC | #3
Hi!

> > This patch series aims to fix reset issue with watchdog driver and remove
> > unnecessary check from pinctrl driver for RZ/G2L alike SoCs.
> > 
> > Biju Das (1):
> >   pinctrl: renesas: rzg2l: remove unnecessary check from
> >     rzg2l_dt_node_to_map()
> > 
> > Lad Prabhakar (1):
> >   watchdog: rzg2l_wdt: Issue a reset before we put the PM clocks
> > 
> >  drivers/pinctrl/renesas/pinctrl-rzg2l.c |  3 +--
> >  drivers/watchdog/rzg2l_wdt.c            | 10 ++++------
> >  2 files changed, 5 insertions(+), 8 deletions(-)
> > 
> I reviewed this series, LGTM.
> If no opinion, I will apply this series.

Go ahead, it looks good to me and it passed basic testing.

Best regards,
								Pavel
Nobuhiro Iwamatsu Feb. 23, 2023, 9:10 p.m. UTC | #4
Hi Pavel,

> -----Original Message-----
> From: Pavel Machek <pavel@denx.de>
> Sent: Wednesday, February 22, 2023 9:02 PM
> To: iwamatsu nobuhiro(岩松 信洋 □SWC◯ACT)
> <nobuhiro1.iwamatsu@toshiba.co.jp>
> Cc: biju.das.jz@bp.renesas.com; cip-dev@lists.cip-project.org;
> pavel@denx.de; chris.paterson2@renesas.com;
> prabhakar.mahadev-lad.rj@bp.renesas.com
> Subject: Re: [PATCH 5.10.y-cip 0/2] Watchdog driver fix and pinctrl
> improvement
> 
> Hi!
> 
> > > This patch series aims to fix reset issue with watchdog driver and
> > > remove unnecessary check from pinctrl driver for RZ/G2L alike SoCs.
> > >
> > > Biju Das (1):
> > >   pinctrl: renesas: rzg2l: remove unnecessary check from
> > >     rzg2l_dt_node_to_map()
> > >
> > > Lad Prabhakar (1):
> > >   watchdog: rzg2l_wdt: Issue a reset before we put the PM clocks
> > >
> > >  drivers/pinctrl/renesas/pinctrl-rzg2l.c |  3 +--
> > >  drivers/watchdog/rzg2l_wdt.c            | 10 ++++------
> > >  2 files changed, 5 insertions(+), 8 deletions(-)
> > >
> > I reviewed this series, LGTM.
> > If no opinion, I will apply this series.
> 
> Go ahead, it looks good to me and it passed basic testing.
> 

OK, I applied and pushed.

> Best regards,
> 								Pavel

Best regards,
  Nobuhiro